Commit Graph

4581 Commits

Author SHA1 Message Date
Chris Hill-Scott
5f40eabdf3 Improve page titles later on in the one off flow
Now that the page title for picking a sender/reply to has been improved,
I think these pages are also less clear than they could be.

This commit changes the page titles to (I hope) be clearer about what is
needed from the user on these pages.
2017-11-20 16:54:07 +00:00
Chris Hill-Scott
4a1dad9a66 Hide form legend on choose reply page
The `<h1>` on this page says all the user needs to know. In research
we saw that users didn’t even read the legend, even when prompted to!
2017-11-20 16:53:11 +00:00
Chris Hill-Scott
ecd43cee5e Fix misleading <h1> in one-off flow
Changing the `<h1>` in https://github.com/alphagov/notifications-admin/pull/1638
turned out to be quite confusing. The combination of the word
"recipient" and a selection of email addresses on the page was confusing.

This commit changes the page title to be much more explicit about what
is expected from the page, rather than what is consistent with the text
of the link that the user clicked.
2017-11-20 16:53:00 +00:00
Chris Hill-Scott
4105b6ff55 Fix misleading <h1> in one-off flow
Changing the `<h1>` in https://github.com/alphagov/notifications-admin/pull/1638
turned out to be quite confusing. The combination of the word
"recipient" and a selection of email addresses on the page was confusing.

This commit changes the page title to be much more explicit about what
is expected from the page, rather than what is consistent with the text
of the link that the user clicked.
2017-11-20 16:50:33 +00:00
Chris Hill-Scott
2bf2b4b460 Merge pull request #1619 from alphagov/remove-references-to-computed-column
Remove references to computed column
2017-11-20 10:27:30 +00:00
Richard Chapman
2ce3cca7a8 Merge pull request #1652 from alphagov/rc-update-template-usage-to-use-new-end-point
Refactor to be more pythonic and convert float to int
2017-11-17 15:01:32 +00:00
Richard Chapman
9eb544338d Refactor to be more pythonic and convert float to int
- Implementation wasn't pythonic so updated it to be more inline with the
rest of the code for maintainability.
- The API is return a float in some cases for the month which is causing
the date to string method to fail.
2017-11-17 14:35:25 +00:00
Chris Hill-Scott
832c1cf75f Merge pull request #1634 from alphagov/smaller-font-for-bigger-numbers
Make dashboard totals smaller if numbers are big
2017-11-17 13:29:39 +00:00
Pete Herlihy
0cf152a369 Merge pull request #1651 from alphagov/104-109
104 to 109 and 45-46 orgs
2017-11-17 11:24:46 +00:00
Pete Herlihy
a8b854425a 104 to 109 and 45-46 orgs
Department for Education – Find a Career
Gravesham Borough Council	– Gravesham BC
Crown Commercial Service – CCS Power BI
Department for International Trade – Export Support Alpha
Crown Commercial Service – GCloud Assurance
2017-11-17 10:39:38 +00:00
Richard Chapman
5750a204ab Merge pull request #1650 from alphagov/rc-update-template-usage-to-use-new-end-point
Added new template usage page which will replace template-activity
2017-11-17 09:32:06 +00:00
Richard Chapman
de9548bba2 Only Allow Admins
Changed the decorator to only allow admin users access to the page.
2017-11-17 09:26:03 +00:00
Richard Chapman
d03df16db5 Added new template usage page which will replace template-activity
The current template-activity page is slow as it is using the end point
which uses notification_history  and hence is timing out. This adds a
new pages (so that they can be compared side by side) which will be
hidden until is is approved with the larger data set and tested.
2017-11-16 16:55:07 +00:00
Chris Hill-Scott
7d1cf2169d Show text message sender in send one-off flow
If you’ve chosen a text message sender then it’s good to see
confirmation of your choice.

This replicates what we do when you choose an email reply-to address.
2017-11-16 16:43:44 +00:00
Chris Hill-Scott
8d38215e86 Remove confusing argument name
Brings in new utils which changes the name of this argument to be closer
to what the API uses.
2017-11-16 13:35:17 +00:00
Chris Hill-Scott
274249b4d9 Merge pull request #1635 from alphagov/pdf-of-sent-letter
Add a link to download a PDF of a sent letter
2017-11-16 11:44:43 +00:00
Chris Hill-Scott
9afd047226 Merge pull request #1636 from alphagov/dont-list-all-address-columns
Don’t list all letter address cols if some missing
2017-11-16 11:44:36 +00:00
Chris Hill-Scott
a358acfd05 Remove references to computed service attribute
`prefix_sms` is the real database column, which should be referred to
from now on.
2017-11-16 11:35:05 +00:00
Chris Hill-Scott
65f20694cc Merge pull request #1648 from alphagov/add-hint-user-no-phone
Add a hint to explain why SMS auth is unavailable
2017-11-16 10:20:51 +00:00
Leo Hemsted
96ad2a09be Merge pull request #1649 from alphagov/existing-user-email-auth-invite
Existing user email auth invite
2017-11-16 10:16:56 +00:00
Leo Hemsted
b8c8372f77 Merge pull request #1617 from alphagov/remove-flask-script
remove flask-script
2017-11-15 17:47:30 +00:00
Leo Hemsted
ddf88b70c0 clean up logic around existing users accepting invites
* if the service issuing the invite does not have permission to edit
  auth types, don't let them do anything. This will stop them turning
  existing email_auth users back to sms auth
* if the user hasn't got a mobile number, but the invite is for sms
  login, don't do anything either. They won't have a phone number if
  they signed up via an email_auth invite previously.

in these cases, we accept the invite and add the user to the service
as normal, however, just don't update the user's auth type.
2017-11-15 17:19:32 +00:00
Chris Hill-Scott
8f4081bdb4 Add a hint to explain why SMS auth is unavailable
If we’re going to ‘disable’ radio buttons then we should always tell
users why the radio button is disabled.

This is what we found with the API key choices anyway.
2017-11-15 16:20:49 +00:00
Leo Hemsted
ab4504f517 fix logged in user not having auth type set from invite 2017-11-15 15:42:23 +00:00
Venus Bailey
f039e64a6d Merge pull request #1594 from alphagov/vb-free-sms-history
Use annual_billing tables at backend for getting and updating free_sm…
2017-11-15 14:57:46 +00:00
Chris Hill-Scott
fdb8ec67c1 Merge pull request #1647 from alphagov/quis-patch-1
Fix typo in tests
2017-11-15 13:30:02 +00:00
Chris Hill-Scott
d117f313a2 Fix typo in tests 2017-11-15 13:28:35 +00:00
Chris Hill-Scott
c39821f72e Merge pull request #1646 from alphagov/type-oh-no
Fix spelling mistake
2017-11-15 13:24:14 +00:00
Chris Hill-Scott
427300f201 Fix spelling mistake 2017-11-15 13:24:04 +00:00
Chris Hill-Scott
1e05e16aa1 Merge pull request #1645 from alphagov/pyup-update-pytest-3.2.3-to-3.2.5
Update pytest to 3.2.5
2017-11-15 13:13:53 +00:00
Chris Hill-Scott
6c8c76247c Merge pull request #1642 from alphagov/meta
Add a meta description tag to the product page
2017-11-15 13:07:26 +00:00
pyup-bot
96b1241806 Update pytest from 3.2.3 to 3.2.5 2017-11-15 12:05:25 +00:00
Chris Hill-Scott
d6fec9f921 Add named argument for clarity 2017-11-15 09:59:52 +00:00
Chris Hill-Scott
a8e62a564d Add meta description tag to homepage
Google tries to auto-generate a snippet of a site’s content to show in
search results. Currently it’s not doing a great job of this for Notify.

There’s a chance that if we give it better content in the site’s meta
description then it will use that instead. Worth a go…

The content is adapted from the blue box on the product page.

It’s 145 characters, which is within the 160 characters recommended[1]

It matches the content in the page, and contains words that users are
likely to be searching for (GOV.UK Notify, emails, text messages).

It’s only on the homepage, because it shouldn’t be duplicated across
multiple pages.

https://yoast.com/meta-descriptions/
2017-11-15 09:53:08 +00:00
Leo Hemsted
3bb083bc89 Merge pull request #1641 from alphagov/user-profile-changes
User profile changes
2017-11-14 17:06:56 +00:00
Leo Hemsted
5353a26bbf make sure auth type is set when registering 2017-11-14 17:01:04 +00:00
Leo Hemsted
6df775fb11 use mapping_table on user-profile page 2017-11-14 16:54:53 +00:00
Leo Hemsted
1559c074d1 Merge pull request #1640 from alphagov/email-invite
Email invites!
2017-11-14 16:45:51 +00:00
venusbb
a9f06c23f7 Commit out using the new end points until data is migrated 2017-11-14 16:23:08 +00:00
Leo Hemsted
8c14113da5 only show mobile number on register from invite page if user is sms_auth
also clean up the way the form is invoked - it now populates from an
invited_user object
2017-11-14 15:53:38 +00:00
Leo Hemsted
c8dbd819ef add tests for registering from an email_auth invite 2017-11-14 15:18:14 +00:00
Leo Hemsted
4c39562821 make big old test give some clues about where it fails by checking response codes of requests 2017-11-14 15:18:14 +00:00
Leo Hemsted
65ba7e88c8 refactor RegisterFromInvite to make auth_type required, and update test fixtures 2017-11-14 15:18:14 +00:00
chrisw
79393c97ef Updated invite email auth user flow 2017-11-14 15:18:14 +00:00
venusbb
581759931f Merge branch 'master' of https://github.com/alphagov/notifications-admin into vb-free-sms-history 2017-11-14 09:40:05 +00:00
Chris Hill-Scott
694a92e92a Merge pull request #1638 from alphagov/fix-misleading-wording-choose-sms-sender
Fix misleading wording on choose text message sender/email reply to pages
2017-11-13 12:23:36 +00:00
Chris Hill-Scott
b6b0e81349 Merge pull request #1637 from alphagov/pyup-update-pyexcel-io-0.5.3-to-0.5.4
Update pyexcel-io to 0.5.4
2017-11-13 12:23:30 +00:00
Chris Hill-Scott
23a1c388f3 Add a link to download a PDF of a sent letter
This is useful for service teams to keep a copy for their records. The
letter won’t be available in Notify once the 7 day retention period has
passed.
2017-11-13 12:17:16 +00:00
Chris Hill-Scott
87a3bd38eb Retitle choose sender page as first page in flow
We have a sort of principle that when clicking a link, the page you land
on should be titled the same as the link you clicked.

This also reduces unnecessary repetition between the page title and the
form label.
2017-11-13 11:59:39 +00:00
Chris Hill-Scott
beffb9e123 Reword choose sender/reply to address pages
Make it clear that:

- In the case of text messages, it’s about who the message comes from
- In the case of emails, it’s about where the user will reply to
2017-11-13 11:56:05 +00:00