mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-08-11 09:28:27 -04:00
Fix misleading <h1> in one-off flow
Changing the `<h1>` in https://github.com/alphagov/notifications-admin/pull/1638 turned out to be quite confusing. The combination of the word "recipient" and a selection of email addresses on the page was confusing. This commit changes the page title to be much more explicit about what is expected from the page, rather than what is consistent with the text of the link that the user clicked.
This commit is contained in:
@@ -217,7 +217,7 @@ def set_sender(service_id, template_id):
|
||||
def get_sender_context(sender_details, template_type):
|
||||
context = {
|
||||
'email': {
|
||||
'title': 'Send to one recipient',
|
||||
'title': 'Where should replies go?',
|
||||
'description': 'Where should replies go?',
|
||||
'field_name': 'email_address'
|
||||
},
|
||||
@@ -227,7 +227,7 @@ def get_sender_context(sender_details, template_type):
|
||||
'field_name': 'contact_block'
|
||||
},
|
||||
'sms': {
|
||||
'title': 'Send to one recipient',
|
||||
'title': 'Who should the message come from?',
|
||||
'description': 'Who should the message come from?',
|
||||
'field_name': 'sms_sender'
|
||||
}
|
||||
|
||||
@@ -44,14 +44,14 @@ test_non_spreadsheet_files = glob(path.join('tests', 'non_spreadsheet_files', '*
|
||||
(
|
||||
mock_get_service_email_template,
|
||||
multiple_reply_to_email_addresses,
|
||||
'Send to one recipient',
|
||||
'Where should replies go?',
|
||||
'Where should replies go?',
|
||||
),
|
||||
(
|
||||
mock_get_service_template,
|
||||
multiple_sms_senders,
|
||||
'Send to one recipient',
|
||||
'Who should the message come from?'
|
||||
'Who should the message come from?',
|
||||
'Who should the message come from?',
|
||||
)
|
||||
])
|
||||
def test_show_correct_title_and_description_for_sender_type(
|
||||
|
||||
Reference in New Issue
Block a user