From 4105b6ff55e142b5224ce73dfc11b7f60433ec91 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 20 Nov 2017 16:26:09 +0000 Subject: [PATCH] Fix misleading `

` in one-off flow Changing the `

` in https://github.com/alphagov/notifications-admin/pull/1638 turned out to be quite confusing. The combination of the word "recipient" and a selection of email addresses on the page was confusing. This commit changes the page title to be much more explicit about what is expected from the page, rather than what is consistent with the text of the link that the user clicked. --- app/main/views/send.py | 4 ++-- tests/app/main/views/test_send.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/main/views/send.py b/app/main/views/send.py index 2eab37327..e0db1e8d1 100644 --- a/app/main/views/send.py +++ b/app/main/views/send.py @@ -217,7 +217,7 @@ def set_sender(service_id, template_id): def get_sender_context(sender_details, template_type): context = { 'email': { - 'title': 'Send to one recipient', + 'title': 'Where should replies go?', 'description': 'Where should replies go?', 'field_name': 'email_address' }, @@ -227,7 +227,7 @@ def get_sender_context(sender_details, template_type): 'field_name': 'contact_block' }, 'sms': { - 'title': 'Send to one recipient', + 'title': 'Who should the message come from?', 'description': 'Who should the message come from?', 'field_name': 'sms_sender' } diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py index 7b2dcc370..5de52ebee 100644 --- a/tests/app/main/views/test_send.py +++ b/tests/app/main/views/test_send.py @@ -44,14 +44,14 @@ test_non_spreadsheet_files = glob(path.join('tests', 'non_spreadsheet_files', '* ( mock_get_service_email_template, multiple_reply_to_email_addresses, - 'Send to one recipient', + 'Where should replies go?', 'Where should replies go?', ), ( mock_get_service_template, multiple_sms_senders, - 'Send to one recipient', - 'Who should the message come from?' + 'Who should the message come from?', + 'Who should the message come from?', ) ]) def test_show_correct_title_and_description_for_sender_type(