darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-19 22:13:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1638 from alphagov/fix-misleading-wording-choose-sms-sender

Browse Source 
Fix misleading wording on choose text message sender/email reply to pages
This commit is contained in:
Chris Hill-Scott
2017-11-13 12:23:36 +00:00
committed by GitHub
parent b6b0e81349 87a3bd38eb
commit 694a92e92a
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/main/views/send.py
View File

@@ -217,18 +217,18 @@ def set_sender(service_id, template_id):
def get_sender_context(sender_details, template_type):
context = {
'email': {
'title': "Choose where to send replies",
'description': "Select an email address that recipients can reply to",
'title': 'Send to one recipient',
'description': 'Where should replies go?',
'field_name': 'email_address'
},
'letter': {
'title': 'Choose sender address',
'description': 'Select an address that recipients can reply to',
'title': 'Send to one recipient',
'description': 'What should appear in the top right of the letter?',
'field_name': 'contact_block'
},
'sms': {
'title': 'Chose text message sender',
'description': 'Select a text message sender that the recipients can reply to',
'title': 'Send to one recipient',
'description': 'Who should the message come from?',
'field_name': 'sms_sender'
}
}[template_type]

8
tests/app/main/views/test_send.py
View File

@@ -44,14 +44,14 @@ test_non_spreadsheet_files = glob(path.join('tests', 'non_spreadsheet_files', '*
(
mock_get_service_email_template,
multiple_reply_to_email_addresses,
'Choose where to send replies',
'Select an email address that recipients can reply to'
'Send to one recipient',
'Where should replies go?',
),
(
mock_get_service_template,
multiple_sms_senders,
'Chose text message sender',
'Select a text message sender that the recipients can reply to'
'Send to one recipient',
'Who should the message come from?'
)
])
def test_show_correct_title_and_description_for_sender_type(