Commit Graph

4775 Commits

Author SHA1 Message Date
Chris Hill-Scott
0b56b6338d Mark agreement signed by Mansfield Council 2019-01-18 10:05:58 +00:00
Alexey Bezhan
ec0575009b Merge pull request #2667 from alphagov/template-and-notification-stats-use-one-api-call
Use single api call for service notification stats and template usage stats
2019-01-17 15:35:00 +00:00
Alexey Bezhan
20d5cdf6c3 Merge pull request #2663 from alphagov/adding_support_for_new_api_template_statistics_response
Add support for new template statistics API response
2019-01-17 13:42:43 +00:00
Chris Hill-Scott
9d2917e095 Mark agreement signed by Cornwall Council 2019-01-17 10:48:56 +00:00
Chris Hill-Scott
94cb5429e6 Merge pull request #2665 from alphagov/fix-showing-name-of-service-you-dont-belong-to
Hide ‘back to …’ link if it’s not your service
2019-01-16 11:35:53 +00:00
Chris Hill-Scott
72c60ea9a4 Merge pull request #2658 from alphagov/sticky-footer-edit
Use sticky footer on edit template page
2019-01-16 11:26:53 +00:00
Pea Tyczynska
52526f2b9f Test aggregate_notifications_stats 2019-01-16 11:24:24 +00:00
Pea Tyczynska
06ab25665e Use single api call for service notification stats and template
usage stats.
2019-01-16 10:35:59 +00:00
Chris Hill-Scott
cb5fee10b9 Add scroll overflow 2019-01-16 09:45:19 +00:00
Chris Hill-Scott
61903a88eb Fix spacing on breaking change page
Quick fix so the text doesn’t overlap.
2019-01-16 09:45:13 +00:00
Chris Hill-Scott
558ae87baa Hide ‘back to …’ link if it’s not your service
This can happen if you click a link for a service you don’t have access
to. We shouldn’t show the back to service link in this case because:
- you shouldn’t be able to find out the service’s name from just knowing
  the link
- if you click the link you only get a `403` anyway
2019-01-15 17:31:55 +00:00
Pea Tyczynska
e5647703b3 Remove support for old template statistics api response 2019-01-15 16:44:37 +00:00
Pea Tyczynska
4fe239abb2 Add support for new template statistics API response
The new API response for template statistics returns separate
count for each status. We get rid of template stats for cancelled
notifications and group the rest of the statuses together.
2019-01-15 16:22:27 +00:00
Alexey Bezhan
46bfb541c8 Group new template-statistics response by template
New API template-statistics response returns notification counts for
each template and status combination. This can be used for both
service statistics counts and template statistics by grouping the
counts either by status or by template.
2019-01-15 15:55:04 +00:00
Chris Hill-Scott
7c92847b85 Merge pull request #2662 from alphagov/fix-status-display-notifications
Fix display of permanent failure on notifications page
2019-01-15 14:32:40 +00:00
Chris Hill-Scott
feabcbc7bf Fix display of perm. failure on notifications page
It had too much whitespace because it was accidentally being given the
wrong class.

This commit undoes the change that caused it (which was while working on
letters) and beefs up our tests for email and text messages (so if this
happened again the tests would catch it).
2019-01-15 13:51:32 +00:00
Chris Hill-Scott
309de074c3 Don’t give postage choice on service and template
We are moving from the postage being set on the service to being set on
the template. Once a service has been migrated to have the new
permission they should no longer be able to set the postage at a service
level, only at the template level.
2019-01-15 12:06:56 +00:00
Chris Hill-Scott
899303d040 Mark agreement signed by Blackpool council 2019-01-15 11:14:55 +00:00
Chris Hill-Scott
94c7a1acef Mark agreement signed by Basildon council 2019-01-14 17:44:19 +00:00
Chris Hill-Scott
0df88f923c Refactor sticky button into component 2019-01-14 15:05:08 +00:00
Chris Hill-Scott
509a9e861d Use sticky footer on edit template page
If you have a long template it’s annoying to have to scroll all the
way to the bottom to click save, when you’ve only changed a small thing
near the staert of the content.
2019-01-14 15:05:04 +00:00
Chris Hill-Scott
e565a36f1d Mark agreement signed by Redcar and Cleveland 2019-01-14 11:15:44 +00:00
Chris Hill-Scott
6ad2a6c075 Merge pull request #2654 from alphagov/bradford.gov.uk
Mark agreement signed by Bradford
2019-01-14 10:43:54 +00:00
Chris Hill-Scott
5c4ff09d48 Treat permanent failure for letters the same as cancelled 2019-01-14 10:16:01 +00:00
Chris Hill-Scott
c1158d7d70 Explain technical failure on the notification page 2019-01-11 16:56:09 +00:00
Chris Hill-Scott
989875294b Make technical failure letters show up on the activity page 2019-01-11 16:55:37 +00:00
Pea (Malgorzata Tyczynska)
55279c91b5 Merge pull request #2646 from alphagov/cancelled_letters
Cancelled notifications do not show as failures on dashboard stats
2019-01-11 16:04:34 +00:00
Chris Hill-Scott
8ee1f2a136 Mark agreement signed by Bradford 2019-01-11 16:03:53 +00:00
Chris Hill-Scott
3f507bfcd5 Merge pull request #2652 from alphagov/parliament.scot
Add Scottish Parliament to list of government email addresses
2019-01-11 10:35:17 +00:00
Chris Hill-Scott
f4fb2ad06b Mark agreement signed by West Lothian 2019-01-11 10:19:37 +00:00
Chris Hill-Scott
a89b0825d8 Add Scottish Parliament to list of government email addresses
We have the Welsh and UK parliaments already.

Northern Ireland’s devolved legislature use `niassembly.gov.uk`, so they’re covered by virtue of their domain ending in .gov.uk
2019-01-10 17:35:47 +00:00
Pea Tyczynska
bb1e9d2a0f Add validation-failed status to FAILURE_STATUSES in admin utils 2019-01-10 15:54:31 +00:00
Pea Tyczynska
9f99ebd53b notifications page title for failed letters is titled 'Failed letters' 2019-01-10 15:27:05 +00:00
Pea Tyczynska
dcc590ec96 Cancelled notifications do not show as failures on dashboard stats
Also update tests after we no longer show cancelled letters
2019-01-10 15:27:04 +00:00
Pete Herlihy
4c8225406c Updated Essex Council contract status and added aliases 2019-01-10 14:00:54 +00:00
Chris Hill-Scott
63cd0a7908 Mark agreement signed by Comhairle nan Eilean Siar 2019-01-10 10:03:59 +00:00
Katie Smith
1c6a71700d Update error messages for validation-failed precompiled letters 2019-01-09 13:10:36 +00:00
Katie Smith
da50f77538 Show error message if precompiled PDF cannot be opened
If PDF files have a validation error which means that they can't be
opened by PyPDF2 we would previously show the 500 status error page. We
now catch PyPDF2.utils.PdfReadErrors so that we can display a custom
error message on the notification page instead.
2019-01-09 13:10:36 +00:00
Katie Smith
bb7e9726d3 Stop showing validation-failed letters as cancelled in table
Changed the table for displaying all notifications to show letters which
have the status of 'validation-failed' as 'Validation failed' instead of
'Cancelled'.

The individual notification page for a letter which has failed
validation has not been changed since this already has a description
(letter has content outside the printable area).
2019-01-09 13:10:36 +00:00
Chris Hill-Scott
8b39bc14d1 Merge pull request #2643 from alphagov/dont-count-pages-api-message-log
Don't request pagination links for API Message log page
2019-01-09 12:27:35 +00:00
Chris Hill-Scott
606641a35e Merge pull request #2645 from alphagov/cne-siar.gov.uk
Add Comhairle nan Eilean Siar to domains list
2019-01-09 12:26:46 +00:00
Chris Hill-Scott
a34e1ea1f0 Merge pull request #2638 from alphagov/copy-template-from-folders
Allow users to navigate folders when copying
2019-01-09 12:26:29 +00:00
Chris Hill-Scott
668b0a91b2 Add Comhairle nan Eilean Siar to domains list
Comhairle nan Eilean Siar (Scottish Gaelic pronunciation: [ˈkʰõ.ərˠʎə nə ˈɲelan ˈʃiəɾ]) is the local government council for Na h-Eileanan Siar council area of Scotland, comprising the Outer Hebrides.
2019-01-09 12:02:02 +00:00
Chris Hill-Scott
30886c3cdb Merge pull request #2626 from alphagov/empty-service-state-folders
Use grey buttons to add templates when service is new
2019-01-09 10:26:43 +00:00
Alexey Bezhan
6cd18f87de Don't request pagination links for API Message log page
Counting pages for API notifications takes a long time for services
with a lot of sent messages (since it issues a `count(*)` query for
the given filter). Since API message log doesn't have a "Next page"
link we can skip the count by setting a flag on the API request.
2019-01-08 15:35:44 +00:00
Chris Hill-Scott
2ef4d1c401 Resolve aliases for Ayrshire 2019-01-08 15:12:44 +00:00
Pete Herlihy
59f260c785 And South Ayrshire... 2019-01-08 13:59:40 +00:00
Chris Hill-Scott
61b902554f …and Aberdeenshire 2019-01-08 13:03:06 +00:00
Chris Hill-Scott
206a7806d4 Allow users to navigate folders when copying
We already have a pattern for navigation folders and searching for
templates – let’s use it for the copy page too. And I reckon we can
represent services as folders if the user has multiple services they
could copy a template from.
2019-01-08 12:21:32 +00:00
Chris Hill-Scott
a1e02d1fec Mark agreement signed by North Lincs, Walsall and East Dunbartonshire 2019-01-08 11:54:14 +00:00