Commit Graph

4775 Commits

Author SHA1 Message Date
Pea (Malgorzata Tyczynska)
0b22fff751 Merge pull request #2639 from alphagov/quick_fix_letter_status
Format letter statuses so they make more sense to our users
2019-01-08 11:06:35 +00:00
Chris Hill-Scott
cbe5e77e69 Mark agreement signed by Hounslow council 2019-01-07 15:46:32 +00:00
Chris Hill-Scott
933dd1245b Merge pull request #2637 from alphagov/doncaster.gov.uk
Mark agreement signed by Doncaster Council
2019-01-07 15:42:23 +00:00
Pea Tyczynska
b8318c491b Format letter statuses so they make more sense to our users 2019-01-07 15:17:09 +00:00
Chris Hill-Scott
d13c071431 Mark agreement signed by Doncaster Council 2019-01-07 10:22:28 +00:00
Chris Hill-Scott
f5321346c4 Add left padding to nested radios
This makes them align horizontally with the label of their parent, so
that the layout is a bit calmer.
2019-01-04 15:30:39 +00:00
Chris Hill-Scott
3be03072a7 Reflect expanded scope of radio SASS file 2019-01-04 15:15:59 +00:00
Chris Hill-Scott
4aa4970fc9 Add grey lines to visually show level of nesting
Uses some CSS to draw some grey lines to show which radios descend from
which.

I don’t feel like the intentation is enough, and it looks a bit messy
because the circles of the radio buttons don’t have straight edges
easily suggest visual alignment.

Copies the design from conditionally revealing content in the design
system:
https://design-system.service.gov.uk/components/radios/#conditionally-revealing-content

Implementation is done with pseudo elements, because borders can’t be
positionned exactly enough.
2019-01-04 15:15:59 +00:00
Chris Hill-Scott
39506c4794 Rename ‘All templates’ 2019-01-04 15:15:58 +00:00
Tom Byers
33800c5f27 Add styles for nested lists of radios
Assumes lists that are descendants of a radio
control should be indented at the same amount as
their label text.
2019-01-04 11:59:25 +00:00
Tom Byers
9bce22f766 Swap order of move_to validators
If Optional runs before required_for_ops, it stops
the validation chain so it doesn't get to
required_for_ops. The move_to field isn't required
for the 'move-to-new-folder' operation, so this has
been removed.

This also adds comments explaining why we set
default to an empty string when instantiating the
move_to field.
2019-01-03 17:09:00 +00:00
Katie Smith
3cf36c592f Change move folder form to not have default radio btn and to show hint
Updated the move folder form to add a hint for the radio button for the
current folder saying 'current folder'. This hint does not get shown if
you are viewing all folders (so you are not inside a folder).

Also stopped a default radio button from being selected on the form.
2019-01-03 16:51:47 +00:00
Tom Byers
501ec2a534 Make all options descend from 'all templates' 2019-01-03 16:51:47 +00:00
Tom Byers
3c4a186a25 Display the template folders nested on the move template/folder form
Before, all the folders were displayed in a list which was ordered but
not nested. This changes the move form to nest the template folders.
2019-01-03 16:51:47 +00:00
Chris Hill-Scott
36656fd6ba Merge pull request #2628 from alphagov/hide-postage-for-those-who-cant-choose
Don’t show postage to users who can’t choose it
2019-01-03 16:26:45 +00:00
Chris Hill-Scott
c02a5800c3 And Midlothian 2019-01-03 16:12:58 +00:00
Chris Hill-Scott
5b6f53ffd1 Mark agreement signed by Stoke on Trent council 2019-01-03 16:07:50 +00:00
Chris Hill-Scott
3a2cfda8b2 Don’t show postage to users who can’t choose it
If you can’t choose postage on a per-template basis, you shouldn’t be
see the thing that indicates that postage can be changed.
2019-01-03 16:04:16 +00:00
Katie Smith
ed84e0958a Stop Redis exception by not passing Redis an empty set to delete
We use `redis_client.delete` to delete multiple keys at once, but this
raises a `redis.exceptions.ResponseError` if it is called with an empty list
or set. We should only call `redis_client.delete` when there is at least
one item to delete.
2019-01-03 15:11:31 +00:00
Chris Hill-Scott
ecf6ebb126 Equalise space before/after paragraph 2019-01-03 11:19:32 +00:00
Chris Hill-Scott
a9baa36005 Hide ‘nothing selected’ if nothing to select
It’s doesn’t make sense to show the state if the state can’t change.
This is especially true when you’re in a brand new, empty service.
2019-01-03 11:16:56 +00:00
Chris Hill-Scott
aaf3322662 Use folder buttons in empty state
It’s confusing to have one way of adding things when your service is new
(green button) but a different way once you’ve added your first thing
(the new grey buttons).

For services that have a `edit_folders` permission, this commit
standardises on the grey buttons for a consistent experience.
2019-01-03 11:14:22 +00:00
Chris Hill-Scott
bbaa51443a Merge pull request #2624 from alphagov/knowsley.gov.uk
Mark agreement signed by Knowsley Council
2019-01-02 16:09:02 +00:00
Pea (Malgorzata Tyczynska)
5d99b2d2f6 Merge pull request #2616 from alphagov/choose_postage
Choose and display postage on template
2019-01-02 15:39:15 +00:00
Chris Hill-Scott
c37bcf3084 Mark agreement signed by Knowsley Council 2019-01-02 15:05:25 +00:00
Chris Hill-Scott
adca4622e4 Fix copypaste 2019-01-02 13:14:23 +00:00
Chris Hill-Scott
b55e0ee392 Mark agreement signed by Newham council 2019-01-02 13:13:01 +00:00
Chris Hill-Scott
729d1ffc3e Mark agreement signed by Manchester City Council 2019-01-02 11:37:34 +00:00
Chris Hill-Scott
b634f19637 Resolve Staffordshire aliases 2019-01-02 11:03:03 +00:00
Chris Hill-Scott
79fe224188 Mark agreement signed by Staffordshire Councl 2019-01-02 11:02:06 +00:00
Chris Hill-Scott
9a01cb9323 Merge pull request #2615 from alphagov/fix-find-sticky
Fix sticky with find as you type
2019-01-02 10:13:22 +00:00
Pete Herlihy
4a35dc65c7 Updated to 516 services from 154 organisations 2018-12-31 13:37:51 +00:00
Pea Tyczynska
97058d3c5b Add service setting switch to choose postage per template 2018-12-27 18:05:30 +00:00
Pea Tyczynska
50935e79ca Test mock_update_service_template called with right args 2018-12-21 17:18:18 +00:00
Pea Tyczynska
85b8b343e2 Service deafault radio checked by default, existing tests pass. 2018-12-21 17:13:18 +00:00
Chris Hill-Scott
6487273ced Fix sticky with find as you type
It was losing its position because filtering the list of templates with
find as you type was causing the height of the page to change.
2018-12-21 14:37:01 +00:00
Chris Hill-Scott
5d8147bbbd Merge pull request #2614 from alphagov/remove-branding-radio
Remove unused CSS
2018-12-21 12:50:16 +00:00
Chris Hill-Scott
bf75fec5ae Remove unused CSS
This is from when we used to show the email logos inside the label of
the radio buttons.

Changing the CSS will also change its hash, will will cache-bust
CloudFront. Which is why I’m doing this now.
2018-12-21 12:42:08 +00:00
Chris Hill-Scott
fa1b6417aa Merge pull request #2613 from alphagov/southglos.gov.uk
Mark agreement signed by South Glos council
2018-12-21 12:34:59 +00:00
Chris Hill-Scott
bb5854cef5 Mark agreement signed by South Glos council 2018-12-21 12:28:42 +00:00
Chris Hill-Scott
a1981b502c Mark agreement signed by Devon County Council 2018-12-21 12:04:09 +00:00
Chris Hill-Scott
fba9ae0617 Merge pull request #2608 from alphagov/tameside.gov.uk
Mark agreement signed by Tameside Council
2018-12-21 10:30:04 +00:00
Chris Hill-Scott
aef66b7eab Mark agreement signed by Tameside Council 2018-12-20 17:32:27 +00:00
Chris Hill-Scott
1284704f36 Mark agreement signed by City of York 2018-12-20 13:06:14 +00:00
Chris Hill-Scott
cdb65e0677 Merge pull request #2605 from alphagov/islington.gov.uk
Mark agreement signed by Islington Council
2018-12-20 12:19:10 +00:00
Chris Hill-Scott
cd0fcbb8cc Merge pull request #2606 from alphagov/reading.gov.uk
Mark agreement signed by Reading Borough Council
2018-12-20 12:19:00 +00:00
Chris Hill-Scott
531094c500 Merge pull request #2598 from alphagov/sthelens.gov.uk
Mark agreement signed by St Helen’s council
2018-12-20 12:18:52 +00:00
Chris Hill-Scott
65c98bfdb5 Mark agreement signed by Reading Borough Council 2018-12-20 12:09:24 +00:00
Chris Hill-Scott
c4ba86e5b7 Mark agreement signed by Islington Council 2018-12-19 16:10:10 +00:00
Leo Hemsted
1bcee4c1b0 render if currentState is defined
(this fixes bug where on error, it would show all states)
2018-12-19 15:25:43 +00:00