darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-18 09:24:35 -05:00
Code Issues Packages Projects Releases Wiki Activity
7,170 Commits 49 Branches 59 Tags
203393de235631db0ce3c38dec85da170a634fba
Commit Graph

4775 Commits

Author SHA1 Message Date
Leo Hemsted
258cd5e2ec Merge pull request #2572 from alphagov/flash-errors 
Show move errors on the template folder management flow
 2018-12-19 15:10:06 +00:00
Chris Hill-Scott
0a576c70e5 Mark agreement signed by London Borough of Hillingdon 2018-12-19 14:30:00 +00:00
Pea Tyczynska
695f1150b5 service_default postage resets template postage to None 2018-12-19 12:24:02 +00:00
Chris Hill-Scott
e34d44ffab services++; 2018-12-19 11:39:55 +00:00
Pete Herlihy
3daf7fa5b5 Updated service count and org count passing 500... 
B.O.O.M.
 2018-12-19 11:39:55 +00:00
Chris Hill-Scott
017004dcde Mark agreement signed by East Devon Council 2018-12-19 10:28:03 +00:00
Pea Tyczynska
687e9e5866 Change postage while editing template 2018-12-18 18:22:03 +00:00
Pea Tyczynska
a60d269900 Show postage on template page if service can choose postage and 
postage set on the template.
 2018-12-18 15:52:53 +00:00
Chris Hill-Scott
eeb58e0f63 Mark agreement signed by St Helen’s council 2018-12-18 14:38:53 +00:00
Chris Hill-Scott
d2d22cc425 Make message limit dynamic 
Because we sometimes bump it in exceptional circumstances.
 2018-12-17 15:37:42 +00:00
Leo Hemsted
94da05ebc4 only catch HTTPError 
also add tests
 2018-12-17 15:25:27 +00:00
Leo Hemsted
5c3c4ec78c change error message for not selecting a template 
needed to subclass RadioField for this
 2018-12-17 15:25:27 +00:00
Leo Hemsted
6f8dc7e6d3 fix being able to add template without selecting a radio button 2018-12-17 15:25:27 +00:00
Leo Hemsted
180654046a flash error message when moving folder to itself 2018-12-17 15:25:27 +00:00
Chris Hill-Scott
43b9e860f3 Mark agreement signed by Nottingham council 2018-12-17 15:08:56 +00:00
Chris Hill-Scott
448c85d240 Merge pull request #2593 from alphagov/portsmouth.gov.uk 
Mark agreement signed by Portsmouth
 2018-12-17 13:37:35 +00:00
Tom Byers
f6a6de41aa Merge pull request #2590 from alphagov/fix-sticky-init 
Fix issues with JS for sticky elements
 2018-12-17 13:29:19 +00:00
Chris Hill-Scott
7ed94488f1 Mark agreement signed by Portsmouth 2018-12-17 13:13:01 +00:00
Chris Hill-Scott
9ca7227275 Mark agreement signed by Lewisham council 2018-12-17 11:18:31 +00:00
Chris Hill-Scott
b3b2024530 Merge pull request #2584 from fidejoseph/patch-6 
Update email_domains.yml
 2018-12-17 10:48:39 +00:00
Chris Hill-Scott
3f7994f560 Merge pull request #2591 from alphagov/redbridge.gov.uk 
Mark agreement signed by Redbridge Council
 2018-12-17 10:34:57 +00:00
Chris Hill-Scott
c30af92050 Merge pull request #2574 from alphagov/selected-template-counter 
Add counter of selected templates and folders
 2018-12-17 10:34:45 +00:00
Chris Hill-Scott
d4e8cdaa44 Add Lewisham 2018-12-17 10:25:25 +00:00
Chris Hill-Scott
552919a415 Mark agreement signed by Redbridge Council 2018-12-17 10:21:07 +00:00
Tom Byers
573d2d1d65 Fix code for sticky JS when window resizes 
Includes:
- change .stopped method to .isStopped() for
  consistency
- replace code in checkResize that adjusts
  dimensions for setElementDimensions
- add code that deals with the window size being
  too small to run whenever positions are calculated
- add reset method for when screen is too small
  for sticking behaviour
- move guard out of methods for stopping and
  sticking (it hid info that was useful at the
  point they were called)
 2018-12-14 16:33:00 +00:00
Tom Byers
b55acc4981 Add comments 2018-12-14 16:33:00 +00:00
Tom Byers
108cec7938 Remove fixedTop property from sticky elements 
It's no longer used by this code.
 2018-12-14 16:33:00 +00:00
Tom Byers
030701ab1b Make folder controls update sticky JS on change 
Also removes a call the `render` method which
duplicates one already made by the
`selectActionButtons` method on load.
 2018-12-14 16:33:00 +00:00
Tom Byers
9823ff831f Add publich recalculate method 
Allows other JS to tell sticky elements to
recalculate their dimensions and then position
(and then check to see if their state needs
changing).

We need this because we change the content of our
element so its dimensions change.

The recalculation code also updates the shim for
elements that are 'stuck' so the horizontal space
the element would occupy in the flow of the page
is correct.
 2018-12-14 16:30:07 +00:00
Tom Byers
6fb2d14cc3 Move shim handling to StickyElement 
Includes other code that splits the height
StickyElement stores into two properties:
1. `verticalSpace`
2. `height`

`verticalSpace` is the vertical space the element
occupies in the document flow when not stuck.

`height` is the visual space of the element,
including padding and border.
 2018-12-14 16:16:40 +00:00
Chris Hill-Scott
0fe6dc952e Add Welsh alias for Ceredigion Council 2018-12-14 15:16:07 +00:00
Chris Hill-Scott
0da5c9afe6 Mark agreement signed by Bournemouth Council 2018-12-14 14:51:10 +00:00
Chris Hill-Scott
fa765b2ade Mark agreement signed by Solihull Council 2018-12-14 10:27:03 +00:00
fidejoseph
ad01fc585d Update email_domains.yml 
Unity Partnership is wholly owned by Oldham Council
 2018-12-13 14:57:22 +00:00
Chris Hill-Scott
86401bb533 Merge pull request #2582 from alphagov/southend.gov.uk 
Mark agreement signed by Southend Council
 2018-12-13 13:11:39 +00:00
Chris Hill-Scott
5ec673b84d Merge pull request #2578 from alphagov/add-existing-live-to-go-live 
Note existing live services in go live ticket
 2018-12-13 10:43:57 +00:00
Chris Hill-Scott
2dcec3a23d Merge pull request #2576 from alphagov/492-143 
Update services and organisation count
 2018-12-13 10:41:57 +00:00
Chris Hill-Scott
b51410baba Merge pull request #2575 from alphagov/remove-commas-volumes 
Strip commas from estimated volumes
 2018-12-13 10:41:50 +00:00
Chris Hill-Scott
400d45835c Merge pull request #2580 from alphagov/no-go-live-non-gov 
Don’t let non-government users request to go live
 2018-12-13 10:41:34 +00:00
Chris Hill-Scott
f44ff0bfc9 Refactor live services check 
Changes the check to say ‘does the user have any live services’ rather
than ‘are all their services in trial mode’. The former is closer to
meaning the thing we care about.

Also has the opportunity to short-circuit without having to go through
the full list.
 2018-12-13 10:37:44 +00:00
Chris Hill-Scott
0c807d399b Mark agreement signed by Southend Council 2018-12-12 16:37:57 +00:00
Chris Hill-Scott
ceaf31bf89 Merge pull request #2579 from alphagov/halton.gov.uk 
Mark agreement signed by Halton Borough Council
 2018-12-12 13:56:40 +00:00
Chris Hill-Scott
a8b916b57f Refactor gov user check into a decorator 
We quite often use it in the same way as `@user_has_permissions`.
 2018-12-12 13:42:26 +00:00
Chris Hill-Scott
4c1ce7bb24 Add Islington council to domain list 
Not sure why they were missing…
 2018-12-12 13:38:36 +00:00
Chris Hill-Scott
9a70f6a7f4 Don’t let non-government users request to go live 
Only users who work for government can accept the terms of use. This
will save us from having to email these requesters back telling them
they need to find someone else to submit the request.
 2018-12-12 12:56:13 +00:00
Chris Hill-Scott
72584572e7 Mark agreement signed by Halton Borough Council 2018-12-12 12:50:55 +00:00
Pea (Malgorzata Tyczynska)
1e3be7d640 Merge pull request #2577 from alphagov/disable_ajax_if_inactive 
Page stops auto-refreshing when it's not active
 2018-12-12 12:32:52 +00:00
Chris Hill-Scott
126db71de6 Refactor government user check onto model 2018-12-12 12:29:08 +00:00
Chris Hill-Scott
688bdd1d7a Note existing live services in go live ticket 
It’s useful for analysing our growth to know if someone who’s requesting
to go live is already a live user of Notify.
 2018-12-12 12:22:38 +00:00
Pea Tyczynska
b65f5abf92 Page stops auto-refreshing when it's not active 2018-12-12 11:42:54 +00:00