Update error messages for validation-failed precompiled letters

This commit is contained in:
Katie Smith
2019-01-09 13:09:51 +00:00
parent da50f77538
commit 1c6a71700d
3 changed files with 5 additions and 6 deletions

View File

@@ -12,6 +12,6 @@
Provided as PDF on {{ created_at|format_datetime_short }}
</p>
<p class="notification-status-cancelled">
Couldnt read this file
Validation failed this isnt a PDF file that Notify can read
</p>
{% endblock %}

View File

@@ -16,7 +16,7 @@
<p>
{% if is_precompiled_letter %}
Provided as PDF, sent
Provided as PDF
{% else %}
{% if help %}
{{ template.name }}
@@ -43,8 +43,7 @@
</p>
{% elif notification_status == 'validation-failed' %}
<p class="notification-status-cancelled">
Cancelled {{ updated_at|format_datetime_short }}
(letter has content outside the printable area)
Validation failed content is outside the printable area
</p>
{% else %}
<p>

View File

@@ -202,7 +202,7 @@ def test_notification_page_shows_page_for_letter_notification(
),
(
'validation-failed',
'Cancelled 1 January at 1:02am (letter has content outside the printable area)',
'Validation failed content is outside the printable area',
),
))
@freeze_time("2016-01-01 01:01")
@@ -426,7 +426,7 @@ def test_notifification_page_shows_error_message_if_precompiled_letter_cannot_be
)
error_message = page.find('p', class_='notification-status-cancelled').text
assert normalize_spaces(error_message) == "Couldnt read this file"
assert normalize_spaces(error_message) == "Validation failed this isnt a PDF file that Notify can read"
def test_should_404_for_unknown_extension(