darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-17 12:29:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove the word ‘printable’

Browse Source 
Don’t think it’s necessary. Makes things consistent with the sent letter
page, which only says ‘Download as a PDF’.

This inconsistency would be more glaring now these pieces of text appear
in the same place, in adjacent steps of a journey.
This commit is contained in:
Chris Hill-Scott
2018-11-22 12:17:11 +00:00
parent b317bd7a0b
commit 741a8856fa
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/check/ok.html
View File

@@ -39,7 +39,7 @@
{% if template.template_type != 'letter' or not request.args.from_test %}
<button type="submit" class="button">Send {{ count_of_recipients }} {{ message_count_label(count_of_recipients, template.template_type, suffix='') }}</button>
{% else %}
<a href="{{ url_for('main.check_messages_preview', service_id=current_service.id, template_id=template.id, upload_id=upload_id, filetype='pdf') }}" download class="button">Download as a printable PDF</a>
<a href="{{ url_for('main.check_messages_preview', service_id=current_service.id, template_id=template.id, upload_id=upload_id, filetype='pdf') }}" download class="button">Download as a PDF</a>
{% endif %}
<a href="{{ back_link }}" class="page-footer-back-link">Back</a>
</form>

2
app/templates/views/notifications/check.html
View File

@@ -65,7 +65,7 @@
{% endif %}
<a href="{{ back_link }}" class="page-footer-back-link">Back</a>
{% if template.template_type == 'letter' %}
<a href="{{ url_for('main.check_notification_preview', service_id=current_service.id, template_id=template.id, filetype='pdf') }}" download class="page-footer-right-aligned-link">Download as a printable PDF</a>
<a href="{{ url_for('main.check_notification_preview', service_id=current_service.id, template_id=template.id, filetype='pdf') }}" download class="page-footer-right-aligned-link">Download as a PDF</a>
{% endif %}
</form>
</div>

4
tests/app/main/views/test_send.py
View File

@@ -2803,7 +2803,7 @@ def test_one_off_letters_have_download_link(
template_id=fake_uuid,
filetype='pdf',
)
assert page.select_one('a[download]').text == 'Download as a printable PDF'
assert page.select_one('a[download]').text == 'Download as a PDF'
def test_send_one_off_letter_errors_in_trial_mode(
@@ -2848,7 +2848,7 @@ def test_send_one_off_letter_errors_in_trial_mode(
assert not page.select('[type=submit]')
assert page.select_one('.page-footer-back-link').text == 'Back'
assert page.select_one('a[download]').text == 'Download as a printable PDF'
assert page.select_one('a[download]').text == 'Download as a PDF'
def test_check_messages_shows_over_max_row_error(