From 741a8856fa1e2f74411555f97c5657a268d7550c Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 22 Nov 2018 12:17:11 +0000 Subject: [PATCH] =?UTF-8?q?Remove=20the=20word=20=E2=80=98printable?= =?UTF-8?q?=E2=80=99?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Don’t think it’s necessary. Makes things consistent with the sent letter page, which only says ‘Download as a PDF’. This inconsistency would be more glaring now these pieces of text appear in the same place, in adjacent steps of a journey. --- app/templates/views/check/ok.html | 2 +- app/templates/views/notifications/check.html | 2 +- tests/app/main/views/test_send.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/templates/views/check/ok.html b/app/templates/views/check/ok.html index b35e6a040..52804960e 100644 --- a/app/templates/views/check/ok.html +++ b/app/templates/views/check/ok.html @@ -39,7 +39,7 @@ {% if template.template_type != 'letter' or not request.args.from_test %} {% else %} - Download as a printable PDF + Download as a PDF {% endif %} Back diff --git a/app/templates/views/notifications/check.html b/app/templates/views/notifications/check.html index 8ab9434cc..21854b4b7 100644 --- a/app/templates/views/notifications/check.html +++ b/app/templates/views/notifications/check.html @@ -65,7 +65,7 @@ {% endif %} Back {% if template.template_type == 'letter' %} - Download as a printable PDF + Download as a PDF {% endif %} diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py index 3325501c4..b8e9073f7 100644 --- a/tests/app/main/views/test_send.py +++ b/tests/app/main/views/test_send.py @@ -2803,7 +2803,7 @@ def test_one_off_letters_have_download_link( template_id=fake_uuid, filetype='pdf', ) - assert page.select_one('a[download]').text == 'Download as a printable PDF' + assert page.select_one('a[download]').text == 'Download as a PDF' def test_send_one_off_letter_errors_in_trial_mode( @@ -2848,7 +2848,7 @@ def test_send_one_off_letter_errors_in_trial_mode( assert not page.select('[type=submit]') assert page.select_one('.page-footer-back-link').text == 'Back' - assert page.select_one('a[download]').text == 'Download as a printable PDF' + assert page.select_one('a[download]').text == 'Download as a PDF' def test_check_messages_shows_over_max_row_error(