Commit Graph

3240 Commits

Author SHA1 Message Date
Imdad Ahad
46ca086aa2 Update command to populate monthly billing data for email and sms 2017-08-11 16:57:18 +01:00
Imdad Ahad
69845e9f37 Add helper methods to retrieve billing data from the new table:
Get yearly and monthly billing data from the new table
with filter by notification type. Additionally let's calculate
current day delta totals
2017-08-11 16:57:18 +01:00
Imdad Ahad
35ad5d74f9 Retrieve billing data (for month) by notification type:
* Previously we were only returning SMS. Let's make this return for
a given notification type.
* General refactor of the monthly retrieval query
* Return an empty BillingData tuple if email billing data is empty
2017-08-11 16:57:18 +01:00
Imdad Ahad
839c161628 Update monthly billing for SMS and Email:
* Refactor code to update for EMAIL_TYPE and SMS_TYPE
* Make tests more robust (overlapping rates, multiple months, multiple noti
* types)
*
2017-08-11 16:57:18 +01:00
Imdad Ahad
ae76fd0f30 Small refactor to a test 2017-08-11 16:57:18 +01:00
Imdad Ahad
63e1167098 Make sure we update the correct month for billing:
When populating the monthly billing records on a schedule, we need
to ensure the correct month is being updated.

As an example, if the current datetime is 31 Mar 2016, 23:00. The
BST equivalent is the 1st April. Therefore we need to ensure we
update billing for April, not March. This takes care of that.
2017-08-11 16:57:17 +01:00
Imdad Ahad
782f3ea693 Rename method to get start and end date of a month for clarity 2017-08-11 16:56:47 +01:00
Imdad Ahad
19b09f2a27 Rename method to convert from utc to bst for consistency 2017-08-11 16:56:46 +01:00
kentsanggds
955ec60fe3 Merge pull request #1157 from alphagov/ken-add-inbound-number-model-dao
Add inbound number model and DAO
2017-08-11 15:17:47 +01:00
Rebecca Law
8658f691e7 Merge pull request #1173 from alphagov/turn-off-purge-dvla-resp-files
Stop purging the DVLA response files from S3
2017-08-11 13:40:20 +01:00
Ken Tsang
2b92c95c22 Update migration script 2017-08-11 13:25:09 +01:00
Ken Tsang
976be24cbc Refactor test 2017-08-11 12:56:59 +01:00
Ken Tsang
9a55e167f7 Refactored inbound_number dao 2017-08-11 12:56:59 +01:00
Ken Tsang
cfabab0785 Refactor code to add updated_at 2017-08-11 12:56:59 +01:00
Ken Tsang
2cfe85a2af Refactored inbound_number dao tests 2017-08-11 12:56:59 +01:00
Ken Tsang
e80bc9deb2 Refactor conftest 2017-08-11 12:56:59 +01:00
Ken Tsang
d101e262b5 Renamed migration scripts 2017-08-11 12:56:59 +01:00
Ken Tsang
668811197c Remove whitespace 2017-08-11 12:56:59 +01:00
Ken Tsang
c9f871c0c9 Refatored tests and fixtures for inbound_number 2017-08-11 12:56:59 +01:00
Ken Tsang
a127a6e871 Added active flag setting in inbound_number_dao 2017-08-11 12:56:59 +01:00
Ken Tsang
5e2d0bf5c6 Update test fixture to provide default provider 2017-08-11 12:56:59 +01:00
Ken Tsang
ffc2da2369 Update serialization for services 2017-08-11 12:56:59 +01:00
Ken Tsang
61c09f142c Refactored model and dao 2017-08-11 12:56:59 +01:00
Ken Tsang
3c392596a3 Add backref in InboundNumber model 2017-08-11 12:56:59 +01:00
Ken Tsang
4efb3238db Added test for allocating a service an inbound number twice 2017-08-11 12:56:59 +01:00
Ken Tsang
4de6060694 Add data models, dao for inbound_numbers 2017-08-11 12:56:59 +01:00
Imdad Ahad
d3e5f3a753 Merge pull request #1150 from alphagov/imdad-migration-remove-month-year-monthly-billing
Drop unused month and year columns from MonthlyBilling
2017-08-11 12:31:38 +01:00
Rebecca Law
4b33f7e987 Stop purging the DVLA response files from S3
We are not processing the data in these files yet so we need to stop deleting them until the data is recorded.
2017-08-11 12:00:20 +01:00
Imdad Ahad
dcecd21f82 Drop unused month and year columns from monthlybilling 2017-08-11 10:44:34 +01:00
Rebecca Law
1b7f3f0238 Merge pull request #1138 from alphagov/pyup-update-flask-migrate-1.3.1-to-2.1.0
Update flask-migrate to 2.1.0
2017-08-10 14:05:48 +01:00
Chris Hill-Scott
432a047b6c Merge pull request #1170 from alphagov/newline-replacement-letters-bugfix
Bump utils to 18.0.1
2017-08-10 12:37:12 +01:00
Chris Hill-Scott
4db008d0a1 Merge pull request #1169 from alphagov/pyup-update-pytest-3.2.0-to-3.2.1
Update pytest to 3.2.1
2017-08-10 12:37:04 +01:00
Chris Hill-Scott
0207c186e8 Bump utils to 18.0.1
Brings in:
- [ ] https://github.com/alphagov/notifications-utils/pull/203
2017-08-10 12:04:25 +01:00
Rebecca Law
318d6aeb7b Remove comment 2017-08-10 11:32:16 +01:00
Rebecca Law
d9d100e20b Merge branch 'master' into pyup-update-flask-migrate-1.3.1-to-2.1.0 2017-08-10 11:22:05 +01:00
Rebecca Law
333ed8f806 Merge pull request #1115 from alphagov/pyup-pin-notifications-python-client-4.3.1
Pin notifications-python-client to latest version 4.3.1
2017-08-10 11:21:03 +01:00
Rebecca Law
32928db6e7 Merge branch 'master' into pyup-pin-notifications-python-client-4.3.1 2017-08-10 10:25:46 +01:00
Rebecca Law
0f26584761 Merge pull request #1164 from alphagov/check-service-name-is-unique
Check service name is unique
2017-08-10 10:21:58 +01:00
pyup-bot
06d4da57ae Update pytest from 3.2.0 to 3.2.1 2017-08-09 22:10:25 +01:00
Leo Hemsted
c1d22047be Merge pull request #1166 from alphagov/fix-logs
fix broken cloudfoundry logs
2017-08-09 16:09:04 +01:00
Leo Hemsted
83fc529cc5 fix broken cloudfoundry logs
wasn't setting log path properly
2017-08-09 16:07:35 +01:00
Leo Hemsted
210cb75706 Merge pull request #1165 from alphagov/logs-cleanup
don't capture logs directly from stdout
2017-08-09 15:48:29 +01:00
Rebecca Law
b227ed450a Got rid of an if 2017-08-09 15:42:40 +01:00
Leo Hemsted
e7b13e727a don't capture logs directly from stdout
previously in run_app_paas.sh, we captured stdout from the app and
piped that into the log file. However, this came up with a bunch of
problems, mainly:

* exceptions with stack traces often weren't formatted properly,
  and kibana could not parse them
* celery logs were duplicated - we'd collect both the json logs and
  the human readable stdout logs.

instead, with the updated utils library, we can use that to log json
straight to the appropriate directory directly.
2017-08-09 15:29:39 +01:00
Rebecca Law
1ec6a3b73d Created a new service endpoint that checks if the service name or email_from is unique.
Why is this needed?
When a user updates a service name they enter the new name in a form, are then asked to confirm the change by entering their password. Then the API call to update_service is called. If we let the update serivce API call fail with the integrity constraint it will be ackward for the user.
2017-08-09 15:12:52 +01:00
Leo Hemsted
14dd18aefc Merge pull request #1163 from alphagov/letter-template-subject
make sure template serialises letter subjects
2017-08-09 12:33:34 +01:00
Leo Hemsted
da02ffa32f ensure template history serializes using template serialize fn 2017-08-09 12:24:35 +01:00
Leo Hemsted
c9762f75a1 make sure template serialises letter subjects 2017-08-09 11:56:52 +01:00
Imdad Ahad
4d53481737 Merge pull request #1134 from alphagov/imdad-feat-check-notification-table-for-last-template-usage
Update the last template usage query to check Notification table
2017-08-09 10:22:21 +01:00
Leo Hemsted
6c0b59b544 Merge pull request #1158 from alphagov/address-line-2
address_line_2 is a required field
2017-08-07 15:09:54 +01:00