darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-11 09:27:56 -04:00
Code Issues Packages Projects Releases Wiki Activity

make sure template serialises letter subjects

Browse Source
This commit is contained in:
Leo Hemsted
2017-08-09 11:56:52 +01:00
parent 6c0b59b544
commit c9762f75a1
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/models.py
View File

@@ -464,7 +464,7 @@ class Template(db.Model):
"created_by": self.created_by.email_address,
"version": self.version,
"body": self.content,
"subject": self.subject if self.template_type == EMAIL_TYPE else None
"subject": self.subject if self.template_type != SMS_TYPE else None
}
return serialized

15
tests/app/test_model.py
View File

@@ -203,3 +203,18 @@ def test_letter_notification_serializes_with_address(client, sample_letter_notif
assert res['line_5'] is None
assert res['line_6'] is None
assert res['postcode'] == 'SW1 1AA'
def test_sms_notification_serializes_without_subject(client, sample_template):
res = sample_template.serialize()
assert res['subject'] is None
def test_email_notification_serializes_with_subject(client, sample_email_template):
res = sample_email_template.serialize()
assert res['subject'] == 'Email Subject'
def test_letter_notification_serializes_with_subject(client, sample_letter_template):
res = sample_letter_template.serialize()
assert res['subject'] == 'Template Subject'