darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-24 11:31:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #247 from alphagov/add_context_to_auth_code

Browse Source 
Updated text send to user for the authorization code.
This commit is contained in:
NIcholas Staples
2016-04-20 12:08:11 +01:00
parent 7187ba6dc7 bee23281fc
commit abdbdc7335
2 changed files with 13 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/celery/tasks.py
View File

@@ -321,7 +321,8 @@ def send_sms_code(encrypted_verification):
verification_message = encryption.decrypt(encrypted_verification)
try:
mmg_client.send_sms(validate_and_format_phone_number(verification_message['to']),
verification_message['secret_code'],
"{} is your Notify authentication code".format(
verification_message['secret_code']),
'send-sms-code')
except MMGClientException as e:
current_app.logger.exception(e)
@@ -341,7 +342,8 @@ def send_email_code(encrypted_verification_message):
aws_ses_client.send_email(current_app.config['VERIFY_CODE_FROM_EMAIL_ADDRESS'],
verification_message['to'],
"Verification code",
verification_message['secret_code'])
"{} is your Notify authentication code".format(
verification_message['secret_code']))
except AwsSesClientException as e:
current_app.logger.exception(e)

16
tests/app/celery/test_tasks.py
View File

@@ -744,9 +744,10 @@ def test_should_send_sms_code(mocker):
mocker.patch('app.mmg_client.send_sms')
send_sms_code(encrypted_notification)
mmg_client.send_sms.assert_called_once_with(format_phone_number(validate_phone_number(notification['to'])),
notification['secret_code'],
'send-sms-code')
mmg_client.send_sms.assert_called_once_with(
format_phone_number(validate_phone_number(notification['to'])),
"{} is your Notify authentication code".format(notification['secret_code']),
'send-sms-code')
def test_should_throw_mmg_client_exception(mocker):
@@ -756,9 +757,10 @@ def test_should_throw_mmg_client_exception(mocker):
encrypted_notification = encryption.encrypt(notification)
mocker.patch('app.mmg_client.send_sms', side_effect=MMGClientException(mmg_error))
send_sms_code(encrypted_notification)
mmg_client.send_sms.assert_called_once_with(format_phone_number(validate_phone_number(notification['to'])),
notification['secret_code'],
'send-sms-code')
mmg_client.send_sms.assert_called_once_with(
format_phone_number(validate_phone_number(notification['to'])),
"{} is your Notify authentication code".format(notification['secret_code']),
'send-sms-code')
def test_should_send_email_code(mocker):
@@ -774,7 +776,7 @@ def test_should_send_email_code(mocker):
current_app.config['VERIFY_CODE_FROM_EMAIL_ADDRESS'],
verification['to'],
"Verification code",
verification['secret_code']
"{} is your Notify authentication code".format(verification['secret_code'])
)