From bee23281fc2beb61037f530639946a64e1a5993a Mon Sep 17 00:00:00 2001 From: Nicholas Staples Date: Wed, 20 Apr 2016 12:02:17 +0100 Subject: [PATCH] Updated text send to user for the authorization code. --- app/celery/tasks.py | 6 ++++-- tests/app/celery/test_tasks.py | 16 +++++++++------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/app/celery/tasks.py b/app/celery/tasks.py index 98a44c453..fcf70b54d 100644 --- a/app/celery/tasks.py +++ b/app/celery/tasks.py @@ -321,7 +321,8 @@ def send_sms_code(encrypted_verification): verification_message = encryption.decrypt(encrypted_verification) try: mmg_client.send_sms(validate_and_format_phone_number(verification_message['to']), - verification_message['secret_code'], + "{} is your Notify authentication code".format( + verification_message['secret_code']), 'send-sms-code') except MMGClientException as e: current_app.logger.exception(e) @@ -341,7 +342,8 @@ def send_email_code(encrypted_verification_message): aws_ses_client.send_email(current_app.config['VERIFY_CODE_FROM_EMAIL_ADDRESS'], verification_message['to'], "Verification code", - verification_message['secret_code']) + "{} is your Notify authentication code".format( + verification_message['secret_code'])) except AwsSesClientException as e: current_app.logger.exception(e) diff --git a/tests/app/celery/test_tasks.py b/tests/app/celery/test_tasks.py index bd3829dec..c814a055c 100644 --- a/tests/app/celery/test_tasks.py +++ b/tests/app/celery/test_tasks.py @@ -744,9 +744,10 @@ def test_should_send_sms_code(mocker): mocker.patch('app.mmg_client.send_sms') send_sms_code(encrypted_notification) - mmg_client.send_sms.assert_called_once_with(format_phone_number(validate_phone_number(notification['to'])), - notification['secret_code'], - 'send-sms-code') + mmg_client.send_sms.assert_called_once_with( + format_phone_number(validate_phone_number(notification['to'])), + "{} is your Notify authentication code".format(notification['secret_code']), + 'send-sms-code') def test_should_throw_mmg_client_exception(mocker): @@ -756,9 +757,10 @@ def test_should_throw_mmg_client_exception(mocker): encrypted_notification = encryption.encrypt(notification) mocker.patch('app.mmg_client.send_sms', side_effect=MMGClientException(mmg_error)) send_sms_code(encrypted_notification) - mmg_client.send_sms.assert_called_once_with(format_phone_number(validate_phone_number(notification['to'])), - notification['secret_code'], - 'send-sms-code') + mmg_client.send_sms.assert_called_once_with( + format_phone_number(validate_phone_number(notification['to'])), + "{} is your Notify authentication code".format(notification['secret_code']), + 'send-sms-code') def test_should_send_email_code(mocker): @@ -774,7 +776,7 @@ def test_should_send_email_code(mocker): current_app.config['VERIFY_CODE_FROM_EMAIL_ADDRESS'], verification['to'], "Verification code", - verification['secret_code'] + "{} is your Notify authentication code".format(verification['secret_code']) )