darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-10 19:34:27 -04:00
Code Issues Packages Projects Releases Wiki Activity
7,804 Commits 59 Branches 61 Tags
e4b1759b3baba40eb2e0b5a2ab6bdde1fe524be5
Commit Graph

7804 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chris Hill-Scott
e4b1759b3b Merge pull request #2965 from alphagov/no-copy-paste-in-zendesk 
Remove redundant info from go live emails
 2019-05-14 11:43:19 +01:00
Chris Hill-Scott
d01ed30da0 Keep email address in go live ticket 
It’s useful because it’s not easy to see in the Zendesk UI.
 2019-05-14 11:17:47 +01:00
Tom Byers
8266f3d65c Merge pull request #2969 from alphagov/revert-2956-progressively-enhance-folder-permissions 
Revert "Progressively enhance folder permissions"
 2019-05-13 16:38:14 +01:00
Tom Byers
0e6caa7fda Revert "Progressively enhance folder permissions" 2019-05-13 16:19:24 +01:00
Tom Byers
b2a38fe222 Merge pull request #2956 from alphagov/progressively-enhance-folder-permissions 
Progressively enhance folder permissions
 2019-05-13 14:41:43 +01:00
Tom Byers
6f12a39b58 Move folder-black.png image into correct folder 
Was placed in app/assets/stylesheets/ by mistake
in fe457464a8
 2019-05-13 14:08:07 +01:00
Pea (Malgorzata Tyczynska)
828579ce05 Merge pull request #2958 from alphagov/precompiled_for_everyone 
Remove precompiled letters permission: precompiled for everyone
 2019-05-13 14:03:14 +01:00
Chris Hill-Scott
2b63b005ef Merge pull request #2967 from alphagov/fix-linking-notification-status 
Only link to message status if message has failed
 2019-05-13 13:55:37 +01:00
Chris Hill-Scott
61d9371134 Merge pull request #2966 from alphagov/folder-name-textbox-width 
Make folder name textbox full width
 2019-05-13 13:55:31 +01:00
Chris Hill-Scott
2737a8e438 Merge pull request #2938 from alphagov/schedule-buttons 
Style radio select component controls as buttons not links
 2019-05-13 13:55:22 +01:00
Chris Hill-Scott
3c6598cbc2 Only link to message status if message has failed 
This retores the behaviour to as it was before
https://github.com/alphagov/notifications-admin/pull/2962
which inadvertently started linking to the guidance for messages that
were delivered or in sending.
 2019-05-13 13:29:47 +01:00
Tom Byers
cd5f6251d1 Adjust selection summary spacing 
Co-Authored-By: Chris Hill-Scott <me@quis.cc>
 2019-05-13 13:15:45 +01:00
Tom Byers
bbc962298c Make selection summary use tabular numbers 
Stops them jumping around as much when the numbers change. As requested in: https://github.com/alphagov/notifications-admin/pull/2956/files#r283271635

Co-Authored-By: Chris Hill-Scott <me@quis.cc>
 2019-05-13 13:07:28 +01:00
Chris Hill-Scott
e8c1a7deea Make folder name textbox full width 
Folder names can be quite long. It’s annoying if they get cut off.
 2019-05-13 11:04:50 +01:00
Tom Byers
fe457464a8 Fixes for folder .svg icon 
Match format of .svg file to others in the same
folder to fix issues in IE11.

Add a .png alternative for IE8 users.
 2019-05-10 14:59:31 +01:00
Tom Byers
d75c26eb83 Make done button, and its surround, sticky 2019-05-10 14:21:58 +01:00
Tom Byers
19b68048d0 Fix undefined local variables in sticky JS 
Running the sticky JS in Jest raised errors due to
these variables not being assigned properly.

It's JavaScript so any variable not defined by the
`var` prefix will automatically become a property
of the global object. That is not what is intended
by the code so requires changing.
 2019-05-10 14:20:44 +01:00
Tom Byers
bb16626209 Split module out into objects for each component 
Is clearer than just having one large hierarchical
object and makes the relationships between the
module and its components clearer.
 2019-05-10 14:20:14 +01:00
Tom Byers
7328649537 Combine 'Change' and 'Done' buttons into one 
Includes addition of classes by JS to ensure CSS
selectors don't have to reference the data
attributes.
 2019-05-10 14:16:03 +01:00
Chris Hill-Scott
507b5b9933 Remove line about checklist from go live email 
It’s impossible for people to go live without technically completing the
checklist now.
 2019-05-10 10:46:15 +01:00
Katie Smith
1d7ce85443 Merge pull request #2962 from alphagov/update-links 
Fix broken links
 2019-05-10 10:35:19 +01:00
Katie Smith
f3f8f4085f Fix broken links 
There were still a few links pointing to `/features/using-notify`
 2019-05-10 09:05:07 +01:00
Chris Hill-Scott
d6b6f1689f Remove copy-pasteable version of go live info 
We’ve automated this now so we don’t need it in a format that’s easy to
copy and paste into a spreadsheet.
 2019-05-09 17:41:27 +01:00
Chris Hill-Scott
b786997c6b Merge pull request #2963 from alphagov/fix-missing-save-button-callbacks 
Fix missing save button on callbacks page
 2019-05-09 16:53:02 +01:00
Chris Hill-Scott
4673113451 Fix missing save button on callbacks page 
😳

74fb30ce5f (diff-d32e9daf34b835cda7c3b407e14a8feeL31)
 2019-05-09 16:44:34 +01:00
Pea (Malgorzata Tyczynska)
3e0ca91912 Merge pull request #2960 from alphagov/update_utils_version 
Update utils version to fix duplicate columns in csv upload bug
 2019-05-09 15:14:39 +01:00
Pea Tyczynska
a99a08ebf2 Update utils version to fix duplicate columns in csv upload bug 
When one of our users uploaded a csv with two phone number columns
and missing data for one of those duplicate columns, our app
crashed. We fixed the code in utils that was crashing now and
we are propagating this change to our service through updating
utils version in this commit.
 2019-05-09 14:54:38 +01:00
Chris Hill-Scott
923ac7190c Add a hint when no team members are selected 
This helps clarify that you will still be able to see the folder.
Follows the phrasing used for the "No folders…" message.
 2019-05-09 13:43:04 +01:00
Tom Byers
1ffa8c8915 Only show the folder icon if fields are folders 2019-05-09 11:25:28 +01:00
Chris Hill-Scott
78699ac995 Merge pull request #2953 from alphagov/numbers-in-excel-reports 
Don’t convert Excel reports to CSV before output
 2019-05-09 11:18:07 +01:00
Pea Tyczynska
18b545af51 Remove precompiled letters permission as everyone can send precompiled now 2019-05-09 11:01:11 +01:00
Chris Hill-Scott
3dc2130926 Align baseline of summary text with button text 2019-05-09 10:30:46 +01:00
Chris Hill-Scott
89478ac2ca Use larger folder icon 2019-05-09 10:27:14 +01:00
Chris Hill-Scott
f274759cd8 Add larger version of black folder icon 
This is for use in the folder permissions UI. It’s designed to be sized
at the same width as a GOV.UK style checkbox. The CSS to render it is
something like:

```css
background-image: file-url('folder-black.svg');
background-repeat: no-repeat;
background-size: 39px auto;
background-position: 0px 4px;
```
 2019-05-09 10:21:30 +01:00
Tom Byers
db12ec3a5c Make buttons work outside of context 
This is important for users who find buttons via
interfaces that present them out of the context of
the page, like screenreaders.
 2019-05-08 17:16:08 +01:00
Tom Byers
42a9a0cf23 Make selection summary a live region 
Live regions need to be in the original HTML of
the page to work. We were generating the summary
in JS.

This changes the JS to only generate the contents
of the summary so changes to its contents are
announces by the existing live-region.
 2019-05-08 17:16:06 +01:00
Tom Byers
089ebf2c7a Add tests for collapsible checkboxes 2019-05-08 17:08:20 +01:00
Tom Byers
90ad8b4ed0 Add helpers for JS tests 
To help with asserting some things which were
repeated in the tests.
 2019-05-08 17:08:20 +01:00
Tom Byers
33d074c00a Allow nested checkboxes to be collapsible 
Expands the API of the macro to allow nested
checkboxes to have a summary tracking the current
selection, the fieldset to expand/collapse and
buttons to be added to allow jumping between
states.

Includes making 'Done' button inline on mobile.
Helps differentiate it form the form submit.
 2019-05-08 17:08:16 +01:00
Tom Byers
20a94910cb Give permissions form legend heading styles 
Also includes putting the text at the foot of the
checkboxes into a hint below the legend.
 2019-05-08 11:35:58 +01:00
Chris Hill-Scott
20e774ca33 Use keyword argument for explicitness 2019-05-08 10:17:20 +01:00
Chris Hill-Scott
80dec99a56 Merge pull request #2946 from alphagov/use-service-organisation-for-service-agreement 
Look at service’s organisation on agreement page
 2019-05-07 16:10:18 +01:00
Chris Hill-Scott
55d4810c4b Don’t convert Excel reports to CSV before output 
Converting Python data to CSV makes every field a string. This means
that in the report we return to the user every field will be a string,
even if it’s come from an `int` type in Python. This is because the CSV
‘standard’ doesn’t support any kind of typing.

Excel does support types for fields, so we can make our reports more
useful by preserving these types. This is particularly relevant in the
report we generate for performance platform, which needs the `count`
column to be a number type.

This commit adds extra code paths to the `Spreadsheet` class which mean
that it can be instantiated from either CSV data or a list of Python
data. Previously we were converting the Python data to CSV as an
intermediate step, before instantiating the class.
 2019-05-07 16:07:23 +01:00
Chris Hill-Scott
5879df5c03 Move as_dict property to its own method 
This helps declutter the init method, and is one less thing to create in
memory when it’s not needed.
 2019-05-07 11:30:33 +01:00
Katie Smith
9199db3400 Merge pull request #2936 from alphagov/show-sms-provider-traffic 
Show monthly usage by SMS provider on Providers page
 2019-05-07 10:15:15 +01:00
Katie Smith
259a82e066 Update for new format of data returned from api 
- API will now send through `created_by_name` instead of `created_by`.
- API will always send through `current_month_billable_sms` but this can
now be `0` instead of `None`.
 2019-05-07 08:30:34 +01:00
Katie Smith
a74da6d14e Show monthly usage by SMS provider on Providers page 
This adds a '% monthly traffic' column to the SMS table on the Providers page
to let us see how much traffic is being sent to each SMS provider.
 2019-05-07 08:30:34 +01:00
Pea (Malgorzata Tyczynska)
a7d8918ee0 Merge pull request #2951 from alphagov/performance-platform-xlsx 
Provide Performance Platform report as Excel file
 2019-05-03 15:59:06 +01:00
Pea (Malgorzata Tyczynska)
9025975d92 Merge pull request #2952 from alphagov/fix-live-services-csv 
Add organisation type to live services csv report
 2019-05-03 15:48:50 +01:00
Chris Hill-Scott
3c38a7be05 Provide Performance Platform report as Excel file 
This is the format we need to upload it in, so this means not having to
manually re-save it as Excel.
 2019-05-03 15:40:53 +01:00