darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-17 12:39:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove precompiled letters permission as everyone can send precompiled now

Browse Source
This commit is contained in:
Pea Tyczynska
2019-05-09 11:01:11 +01:00
parent 80dec99a56
commit 18b545af51
2 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/main/views/service_settings.py
View File

@@ -62,7 +62,6 @@ from app.utils import (
PLATFORM_ADMIN_SERVICE_PERMISSIONS = OrderedDict([
('inbound_sms', {'title': 'Receive inbound SMS', 'requires': 'sms', 'endpoint': '.service_set_inbound_number'}),
('precompiled_letter', {'title': 'Send precompiled letters', 'requires': 'letter'}),
('email_auth', {'title': 'User auth type editing'}),
('upload_document', {'title': 'Uploading documents', 'endpoint': '.service_switch_can_upload_document'}),
('edit_folder_permissions', {'title': 'Folder permissions'}),

11
tests/app/main/views/service_settings/test_service_setting_permissions.py
View File

@@ -40,8 +40,6 @@ def test_service_set_permission_requires_platform_admin(
@pytest.mark.parametrize('permission, form_data, on', [
('upload_document', 'True', True),
('upload_document', 'False', False),
('precompiled_letter', 'True', True),
('precompiled_letter', 'False', False),
('inbound_sms', 'True', True),
('inbound_sms', 'False', False),
('email_auth', 'True', True),
@@ -73,12 +71,6 @@ def test_service_set_permission(
@pytest.mark.parametrize('service_fields, endpoint, kwargs, text', [
({'restricted': True}, '.service_switch_live', {}, 'Live Off Change'),
({'restricted': False}, '.service_switch_live', {}, 'Live On Change'),
({'permissions': ['letter', 'precompiled_letter']},
'.service_set_permission', {'permission': 'precompiled_letter'}, 'Send precompiled letters On Change'),
({'permissions': ['letter']},
'.service_set_permission', {'permission': 'precompiled_letter'}, 'Send precompiled letters Off Change'),
({'permissions': ['upload_document']},
'.service_switch_can_upload_document', {}, 'Uploading documents On Change'),
({'permissions': []},
@@ -120,11 +112,8 @@ def test_service_setting_button_toggles(
@pytest.mark.parametrize('permissions,permissions_text,visible', [
('sms', 'inbound SMS', True),
('inbound_sms', 'inbound SMS', False), # no sms parent permission
('letter', 'precompiled letters', True),
('precompiled_letter', 'precompiled letters', False), # no letter parent permission
# also test no permissions set
('', 'inbound SMS', False),
('', 'precompiled letters', False)
])
def test_service_settings_doesnt_show_option_if_parent_permission_disabled(
get_service_settings_page,