Commit Graph

9627 Commits

Author SHA1 Message Date
Chris Hill-Scott
dd6944e8ef Use tabular figures for template statistics
We use tabular (not lining) figures everywhere else that we display
counts, so that they don’t shift around as the AJAX updates the numbers.

There’s a good explanation of the difference here:
https://www.fonts.com/content/learning/fontology/level-3/numbers/proportional-vs-tabular-figures
2020-03-27 09:30:28 +00:00
Chris Hill-Scott
8a093fd34c Merge pull request #3338 from alphagov/remove-permission-checks-uploads
Clean up the codebase after moving everyone to the new uploads page
2020-03-26 17:00:16 +00:00
Chris Hill-Scott
d41d0cfb67 Merge pull request #3387 from alphagov/add-who-can-use-page
Add ‘Who it’s for’ page
2020-03-26 15:15:44 +00:00
Chris Hill-Scott
971ecde37a Update list of organisation types
Adds emergency services to cover more than just fire and police (eg
coastguard).

Adds armed forces and GP practices for people who might not be sure that
they’re covered under MOD and the NHS respectively.
2020-03-26 14:55:51 +00:00
Chris Hill-Scott
db2d312ba7 Link to ‘who it’s for’ when error creating account
If someone enters an email address from a domain we don’t recognise we
direct them straight to our support channel. This is causing increased
contact from suppliers and members of the public.

Now that we have a page which explains who can use Notify, let’s direct
people there first. Then if they really do need to contact support
(because we don’t recognise their organisation) then they can do so from
that page.
2020-03-26 14:55:51 +00:00
Chris Hill-Scott
41dd7a883b Add who’s its for page
We have a policy about how suppliers are allowed to use Notify. But we
don’t explain it anywhere. Which drives contact to our support form.

This commit that adds a new page that explains the policy.

I’ve moved the related content about who else can use Notify from the
get started page to this page as well, where it doesn’t need to sit in
a details element.
2020-03-26 14:55:51 +00:00
Chris Hill-Scott
38b4b4d994 Fix misaligned upload button when no letter permission
We should add spacing to the right, so if the first button is missing
the second one still sits flush-left.
2020-03-25 15:28:54 +00:00
Chris Hill-Scott
d83e7a8e9f Tidy up the jobs template 2020-03-25 15:27:26 +00:00
Chris Hill-Scott
481c9dba17 Remove unused model property 2020-03-25 13:58:23 +00:00
Chris Hill-Scott
7d57a4d9b8 Redirect the old jobs URL 2020-03-25 13:58:23 +00:00
Chris Hill-Scott
0fdabbdb5d Merge pull request #3386 from alphagov/triage-public-support
Direct members of the public raising support tickets to somewhere more useful
2020-03-25 13:27:43 +00:00
Chris Hill-Scott
2ca32019e4 Go back to triage page if you’ve come from there 2020-03-25 12:21:51 +00:00
Chris Hill-Scott
8335de1432 Use correct back link pattern on escalation page 2020-03-25 12:20:49 +00:00
Chris Hill-Scott
34a5ddaf2c Assume email always provided
There’s no way for a user to submit the form without it now.
2020-03-24 17:56:12 +00:00
Chris Hill-Scott
8e055a4375 Remove prefilled message thing 2020-03-24 17:56:12 +00:00
Chris Hill-Scott
697803a10c Add a ‘general’ ticket type
This is for tickets coming from non-logged-in users. It’s effectively
the same as reporting a problem, but doesn’t have the banner about
the status page (because we can’t tell if they’re actually reporting a
problem now we’re not asking).

It also gives a more generic page title.
2020-03-24 17:56:11 +00:00
Chris Hill-Scott
30a3418473 Refactor so constants are used everywhere 2020-03-24 17:48:13 +00:00
Chris Hill-Scott
55e377baf6 Rename and delete form templates
`report-a-problem’ becomes `form` because it’s not just being used for
problems.

'ask-a-question' gets deleted because it’s not being used.
2020-03-24 17:48:12 +00:00
Chris Hill-Scott
17a3ee920c Use the same template for problems and questions 2020-03-24 17:48:12 +00:00
Chris Hill-Scott
11cdf58256 Use the same form for problems and questions 2020-03-24 17:48:11 +00:00
Chris Hill-Scott
61ab9661fb Direct members of the public somewhere more useful
We can’t give advice to members of the public, but increasingly we’re
seeing them try to use our support form to ask.

It would be better for them if we can direct them straight to somewhere
more useful, before they have the chance to raise a support ticket.

This commit replaces the report a problem/ask a question triaging for
users who aren’t signed in. It’s not possible for non-signed-in users to
raise an priority 1 ticket, so we never need to triage the tickets in
this way.

Instead we can triage people based on whether they work in the public
sector or not. If they do then we send them on to the feedback form. If
not then they go to a new page which contains some useful links. We’ve
chosen these links based on some analysis of the support tickets we’ve
received recently[1]

1. https://docs.google.com/spreadsheets/d/1uBQn-ZnCYfz6ltFaUKZpytgvBF0-MeshCLZ1cD74R0c/edit?usp=sharing
2020-03-24 17:48:11 +00:00
Leo Hemsted
c693ef2abe Merge pull request #3385 from alphagov/bump-deployment-timeout
bump deployment timeout
2020-03-24 14:54:14 +00:00
Leo Hemsted
7df45d6cce bump deployment timeout
5 minutes isn't long enough to deploy ten instances of the admin app -
it turns out it takes marginally longer than 5 minutes to roll each
instance one after the next. this can lead to confusion as the build
fails, functional tests don't run, but the code may have deployed fine
and be running on production.
2020-03-23 14:38:01 +00:00
Chris Hill-Scott
b67b9c0414 Merge pull request #3383 from alphagov/drop-ajax-notifications-page
Drop frequency of AJAX updates on notifications page
2020-03-23 13:46:40 +00:00
Chris Hill-Scott
aba5e19805 Drop frequency of AJAX updates on notifications page
This is another page that puts load on the database, so let’s treat it
the same as the dashboard.
2020-03-23 12:56:26 +00:00
David McDonald
f5106cd450 Merge pull request #3382 from alphagov/require-email
Require email address for all support tickets
2020-03-23 11:58:42 +00:00
David McDonald
9a3e53f57d Mark field as optional
As suggested by the design system
2020-03-23 11:36:06 +00:00
David McDonald
d7385da0df Require email address for all support tickets
We are seeing little benefit of allowing users to not put in their email
address. This will mean that you must provide it for feedback, not just
problems with the site.

There could maybe be some more refactoring of the support templates as
this is now very similar to the report a problem page but this is a
quick fix so haven't gone too in depth.
2020-03-23 11:21:52 +00:00
Katie Smith
60626dfb55 Merge pull request #3381 from alphagov/update-failwhale
Add status page link to failwhale page
2020-03-20 14:18:41 +00:00
Tom Byers
a2f9f8d36a Merge pull request #3378 from alphagov/change-agreement-test-post-param
Remove POST param from agreement test
2020-03-20 10:57:02 +00:00
Katie Smith
317135736b Add status page link to failwhale page 2020-03-19 15:57:15 +00:00
Chris Hill-Scott
21310f9695 Merge pull request #3376 from alphagov/get-single-contact-list
Use new API endpoint to get single contact list
2020-03-19 15:16:33 +00:00
Chris Hill-Scott
eb0e6f20c2 Merge pull request #3380 from alphagov/slow-ajax-dashboard
Slow down the update interval on the dashboard
2020-03-19 12:48:01 +00:00
Chris Hill-Scott
d0f3875d29 Slow down the update interval on the dashboard
Dashboard is the most intensive page we AJAX, and also the highest
traffic one. We’ve already slowed it from 2 to 5 seconds, this slows it
further to 20 seconds to reduce the load.

This leaves other pages (for example looking at a single job) at the
platform-level default of 5 seconds, because we think they cause less
load and the real-timelyness isn’t critical to people’s business
processes.

For looking at a single notification we know from research that someone
sending these one-at-a-time often waits to see if they’re delivered,
so let’s bring this back down to the previous value of 2 seconds.
2020-03-19 12:35:34 +00:00
Chris Hill-Scott
4dbd9b0615 Merge pull request #3379 from alphagov/reduce-platform-admin-usage
Reduce usage of the platform admin index page
2020-03-19 11:23:34 +00:00
Chris Hill-Scott
2a76fd9ee8 Reduce usage of the platform admin index page
This page is slow to load which means:
- it’s annoying for us
- it’s potentially causing load on the database

This commit does two things to reduce the amount we’re unnecessarily
looking at this page:

1. Avoid redirecting to it when signing in as a platform admin user
2. Don’t go directly to it when clicking ‘platform admin’ at the top,
   but instead show a holding page (there’s a fair chance you’ve clicked
   that link in order to go and manage some email branding or find a
   user, not wait for stats to load)
2020-03-19 10:59:21 +00:00
Tom Byers
a5d8de5028 Remove POST param from agreement test
This test sent an empty string to represent the 'who' field not having a value. This is represented by a group of radios in the page.

In browsers, radios that aren't selected result in that field not being included in the HTTP parameters. This change makes the test match that.

The expected validation message is also changed to the one you see in a browser. Turns out [the WTForms DataRequired validator](https://wtforms.readthedocs.io/en/stable/validators.html#wtforms.validators.DataRequired) produces a different error message for an empty string vs the value being missing ("This field is required." vs "Not a valid choice").
2020-03-18 16:54:00 +00:00
David McDonald
b2a75af8bb Merge pull request #3367 from alphagov/validate-postcodes-for-csvs
Pull in version of utils that validates postcodes for CSVs
2020-03-18 14:10:24 +00:00
David McDonald
39fe27be39 Pull in version of utils that validates postcodes for CSVs
This will mean that a user can not send a CSV for letters with invalid
postcodes and must fix their data.

See https://github.com/alphagov/notifications-utils/pull/704
2020-03-18 12:02:31 +00:00
Chris Hill-Scott
e66f189b88 Merge pull request #3375 from alphagov/ship-contact-lists
Ship the contact lists feature
2020-03-17 12:56:37 +00:00
Chris Hill-Scott
82634f79de Use new API endpoint to get single contact list
When we first built the contact list feature this endpoint didn’t exist.
Now it does we can remove the slightly cludgy looping-through-all-the-lists
code.
2020-03-17 11:30:27 +00:00
Chris Hill-Scott
3dfa401de1 Ship the contact lists feature
This reveals the links that we were only showing to platform admin users
so that everyone can discover the new feature.
2020-03-17 10:22:22 +00:00
Chris Hill-Scott
fc58547be3 Tell the API which contact list a job’s come from
So that we can make enhancements to the UI in the future, for example
grouping jobs within their associated contact list.
2020-03-16 17:56:55 +00:00
Chris Hill-Scott
585fdd9076 Use the correct name for the contact list bucket
Everything else is production. The bucket is currently called
production. The fact that the CSV bucket is called `live-` is a legacy
thing that’s hard to change.
2020-03-16 17:56:55 +00:00
Chris Hill-Scott
b5d279e890 Redirect to uploads after save contact list
The saved uploads page just shows you the same thing you’ve seen on the
previous page – a list of email addresses.

It’s more useful to see the uploads page, so you can see where the thing
you’ve saved has gone. You can see it more in context.
2020-03-16 17:56:20 +00:00
Chris Hill-Scott
cb555a4cbe Merge pull request #3366 from alphagov/upload-contact-list
Let teams upload an emergency contact list for later use
2020-03-16 14:49:15 +00:00
Chris Hill-Scott
341b9009f3 Harmonise the typography when listing uploads
24px with 19px is what we use on the uploads page. On notifications page
we use 19px with 16px.

There’s some loose idea that the bigger size is for items that contain
other items.

This also increases the line height for recipients of PDF letters to
make things line up.
2020-03-16 14:14:29 +00:00
Chris Hill-Scott
00f953de6d Give Flask bytes to send, not string
For some reason this passed the tests, but didn’t work running locally.
2020-03-16 13:48:44 +00:00
Chris Hill-Scott
76319d947a Merge pull request #3373 from alphagov/remove-jobs-from-dashboard
Remove jobs from the dashboard
2020-03-16 13:17:06 +00:00
Chris Hill-Scott
f563c4a181 Update content based on KC’s suggestions 2020-03-16 13:09:40 +00:00