Commit Graph

2187 Commits

Author SHA1 Message Date
Chris Hill-Scott
cfadead292 Make it clearer what you’re downloading
The previous text didn’t make it clear _what_ you were downloading as a
CSV file, you had to infer it from the context.

And the fact that it’s a CSV file is immaterial, it’s the data you care
about, not the format.
2016-07-19 12:46:20 +01:00
Chris Hill-Scott
500a503f07 Rewrite job page test to use Beautiful Soup
Beautiful Soup makes it easier to do assertions on specific pieces of
text. The diffs are more useful than when you do `if 'text' in page`.
2016-07-18 09:07:02 +01:00
Chris Hill-Scott
6d5561267b Merge pull request #792 from alphagov/upgrade-utils-bleach-fix
Upgrade utils to fix bleach version issue
2016-07-15 13:47:36 +01:00
Chris Hill-Scott
93f7390f65 Upgrade utils to fix bleach version issue
Brings in:
- [x] https://github.com/alphagov/notifications-utils/pull/53
2016-07-15 13:42:43 +01:00
Chris Hill-Scott
1c8c86bd1c Merge pull request #781 from alphagov/template-previews
Adds previews of email templates
2016-07-15 10:35:15 +01:00
Adam Shimali
8f7eaa784b Merge pull request #787 from alphagov/message-limit-increase-fix
Increase daily message limit for unrestricted services
2016-07-14 13:36:51 +01:00
Adam Shimali
22601ab4f6 Increase daily message limit for unrestricted services.
This pr is for:

https://www.pivotaltracker.com/story/show/126230157
2016-07-14 11:38:54 +01:00
Chris Hill-Scott
4dcd8906c8 Merge pull request #784 from alphagov/wonky-tables
Fix wonky tables on dashboard and activity page
2016-07-14 09:16:16 +01:00
Chris Hill-Scott
9c83d559f3 Fix wonky tables on dashboard and activity page
Tables with a `layout` of `fixed` determine column widths from the
width of the column headings.

We weren’t setting the width of the first column heading, so our tables
were getting out of alignment.
2016-07-13 16:56:28 +01:00
Chris Hill-Scott
1f90a7eee0 Show full email template on single template page
There’s no point in collapsing […] the email on the single template
page because it’s the only thing on the page.

Users will probably be going back and forth quite a bit to edit their
template and see the changes; they shouldn’t have to expanded it evey
time to check they’ve got the heading syntax right, for example.
2016-07-13 08:55:59 +01:00
Chris Hill-Scott
c006b8748c Add conditional placeholder detection
Implements: https://github.com/alphagov/notifications-utils/pull/51

Copies the same regex.

Adds some CSS to display conditional placeholders differently to
normal placeholders (vertical rather that curved right-hand edge).
2016-07-12 17:11:52 +01:00
Chris Hill-Scott
d380eaf060 Allow images to be served from live domain
Currently images in our email template are hardcoded to be served from
the live domain[1].

In order for the admin app, running locally or in preview/staging, to be
able to load these images when previewing an email template, the CSP
headers need to allow this domain.

Also splits the header string up using string literal concatenation[2]
so that it’s easier to read.

1. https://notifications.service.gov.uk
2. https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation
2016-07-12 16:46:46 +01:00
Chris Hill-Scott
9f91694c71 Add a ‘private’ preview email template endpoint
This will make working on the email template easier.

Includes examples of features like lists, headings, blockquotes, etc.
2016-07-12 16:46:46 +01:00
Rebecca Law
76369b3d10 Merge pull request #772 from alphagov/email-registered-users
Add api client call to email users that are already registered
2016-07-12 13:12:01 +01:00
Rebecca Law
43938936f3 If a user has already registered with the email they will get a different email when the register again.
The email includes likes to sign in and send feedback
2016-07-12 11:53:30 +01:00
Rebecca Law
b4525d0a64 Merge branch 'master' into email-registered-users 2016-07-12 11:05:16 +01:00
catherineheywood
df63dc5245 Remove sections
Remove sections About GOV.UK Notify and Getting started
2016-07-12 09:20:41 +01:00
Chris Hill-Scott
f3cf4bf708 Fix mismatch HTML tags in doc 2016-07-12 09:08:42 +01:00
Chris Hill-Scott
9f67b137ad Merge pull request #775 from alphagov/reasons-for-failure
Make ‘temporary failure’ clearer in frontend and CSV downloads
2016-07-12 08:46:28 +01:00
catherineheywood
dd0ff77c83 Merge pull request #776 from alphagov/keys
Keys
2016-07-12 08:34:20 +01:00
Catherine Heywood
f17675155b improve readability 2016-07-11 15:46:42 +01:00
Catherine Heywood
4da3baffe4 link to API keys section 2016-07-11 15:45:07 +01:00
Catherine Heywood
1f38f8293b revert 2016-07-11 15:43:30 +01:00
Catherine Heywood
96eb67613e reformat info in table for test 2016-07-11 15:42:18 +01:00
Catherine Heywood
0ea063f968 add commas in table 2016-07-11 15:41:15 +01:00
Catherine Heywood
2a10134087 add 'to' 2016-07-11 15:40:36 +01:00
Catherine Heywood
23082d784b minor edit to respect style guide 2016-07-11 15:17:06 +01:00
Catherine Heywood
cd94e37b7c move table up 2016-07-11 15:07:55 +01:00
Catherine Heywood
ec77d60c8f API keys table 2016-07-11 15:06:25 +01:00
Catherine Heywood
4f4614a2ac API keys table 2016-07-11 15:05:52 +01:00
Catherine Heywood
280a140e4e API keys table 2016-07-11 15:05:23 +01:00
Catherine Heywood
66528d953d links to sections 2016-07-11 15:04:21 +01:00
Catherine Heywood
bef9e7cbe5 API keys table 2016-07-11 15:01:49 +01:00
Pete Herlihy
488de1ce7c Removed 'states are the same for email and text' blurb. 2016-07-11 15:01:28 +01:00
Catherine Heywood
dd729a76b2 API keys, work 2016-07-11 15:00:03 +01:00
Catherine Heywood
d1e885954b Add Test key 2016-07-11 14:55:11 +01:00
Catherine Heywood
fc3d155f3b add info about keys 2016-07-11 14:41:20 +01:00
Chris Hill-Scott
5f67560b1e Link to failure reasons from job/activity pages
If something has failed and you don’t know why, you should be able to
find out why. Let’s try adding a link to the page explaining why, so
it’s not just buried in the footer.
2016-07-11 14:01:42 +01:00
Chris Hill-Scott
d22b2f678d Make ‘message’ plural when talking about retries
In each of these cases the previous sentence talks about messages,
plural, so these lines should agree.
2016-07-11 13:57:05 +01:00
Chris Hill-Scott
90bdf51e3a Rename failure status on delivery page
…so that they agree with what we show in the interface/CSV, eg ‘phone
does not exist’ instead of ‘permanent failure’.
2016-07-11 13:55:02 +01:00
Chris Hill-Scott
8d59b51387 Use shorter sentences to describe sending state
It was running on a bit…
2016-07-11 13:54:37 +01:00
Chris Hill-Scott
50c20ce680 Add formatted notification status to CSV
This commit makes the CSV download use the same language for failure
reasons as the frontend.

It also adds a test around this stuff, which was patchily tested before.
2016-07-11 13:12:46 +01:00
Chris Hill-Scott
f9a9048579 Make ‘temporary failure’ error less cryptic
‘Phone number doesn’t exist’ as opposed to ‘Permanent failure’ has
tested well because it talks in terms of things people understand.

We should do the same for ‘Temporary failure’, because users are
unclear:
- why this is happening
- if it’s temporary, is Notify going to retry it (it’s not)

We think that ‘Phone/inbox not currently accepting messages’ answers
makes these things clearer.

I’ve reworded it slightly to:

- ‘Inbox not accepting messages right now’
- ‘Phone not accepting messages right now’
2016-07-11 11:18:01 +01:00
Chris Hill-Scott
d33c254fa5 Merge pull request #743 from alphagov/hide-delivery-download-tour
Hide download CSV link when in the tour
2016-07-08 16:31:16 +01:00
minglis
071117cbb1 Merge pull request #771 from alphagov/use-python-3-in-bootstrap
using python3 in falback venv
2016-07-08 14:45:36 +01:00
Martyn Inglis
0cc3bb5970 using python3 in falback venv 2016-07-08 14:38:59 +01:00
Rebecca Law
cdd666a23b Add api client call to email users that are already registered 2016-07-08 11:00:23 +01:00
Chris Hill-Scott
ec01eee7b9 Merge pull request #766 from alphagov/visual-refactor-team-page
Visual refactor team page
2016-07-08 09:02:20 +01:00
Chris Hill-Scott
5410fb2f64 Merge pull request #765 from alphagov/fix-large-file-uploads
Fix 500 being thrown when uploading large files
2016-07-07 15:33:31 +01:00
Leo Hemsted
a67fe56907 Merge pull request #763 from alphagov/api-key-types
Api key types
2016-07-07 14:58:31 +01:00