darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-27 05:41:00 -05:00
Code Issues Packages Projects Releases Wiki Activity
2,209 Commits 51 Branches 59 Tags
8f77f47bb2cfad2bc935d37d7bcffc23cefd26b5
Commit Graph

2209 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Pete Herlihy
8f77f47bb2 Merge pull request #806 from alphagov/whitelist-domain 
Added new domain to whitelisted users
 2016-07-26 10:56:30 +01:00
Leo Hemsted
86ce23f5da Merge pull request #802 from alphagov/dashboard-stats-untangling 
Remove notification-statistics endpoints from totals boxes
 2016-07-25 10:29:36 +01:00
Pete Herlihy
cf4c932706 Added new domain to whitelisted users 2016-07-22 11:14:25 +01:00
Leo Hemsted
6ff77c995e add tests for service_api_client 2016-07-21 17:32:28 +01:00
Leo Hemsted
0cc2a90a1a add tests for get_dashboard_totals 2016-07-20 14:12:22 +01:00
Leo Hemsted
fade656e3b add new get_detailed_service mock to tests that the dashboard 2016-07-20 14:12:22 +01:00
Leo Hemsted
3ffd6c744c separate detailed and normal service_api_client.get_service 
to make it easier to mock and control return values
 2016-07-20 14:12:22 +01:00
Leo Hemsted
3e6eedd079 use new detailed service endpoint for dashboard totals 
we don't want to use the old statistics endpoints any more
also a couple of quality of life changes
* moves some logic out of the _totals.html template
* tidies up statistics_utils
 2016-07-20 14:12:22 +01:00
Leo Hemsted
4451a8634d add detailed flag to GET service api client 
returns current (past 7 days) notification stats as well as service info
 2016-07-20 14:12:22 +01:00
Chris Hill-Scott
d9944107da Merge pull request #799 from dahfool/master 
replace require with es6 import statment
 2016-07-20 12:01:17 +01:00
Chris Hill-Scott
8d7c37886c Merge pull request #795 from alphagov/delivery-info-specific-time 
Make ‘Available for…’ text on job page relative
 2016-07-20 12:01:06 +01:00
Chris Hill-Scott
f6bdef4ca3 Add tests for time_left 
This commit extracts the code that works out the ‘Data available for…’
message so that it’s easy to unit test for.
 2016-07-20 11:50:22 +01:00
Chris Hill-Scott
9a5fbca707 Make ‘Available for…’ text on job page relative 
When we say ‘delivery information is available for 7 days’ you have to
infer _when_ the seven days starts. When you come back to the page it
still says ‘available for 7 days’ even if you only have a day left to
download it. This is confusing.

This commit changes the text to be relative to now, eg ‘available for 7
days’, ‘available for 1 day’.

The date is counted to midnight on the seventh day, which is when the
data is actually deleted.
 2016-07-19 15:25:17 +01:00
Gerald Isabelle
2440e5ed9a replace require with es6 import statment 2016-07-19 15:13:23 +01:00
Leo Hemsted
743a9d05d1 Merge pull request #794 from alphagov/refactior 
Rename api_client to service_api_client
 2016-07-19 13:26:34 +01:00
Chris Hill-Scott
b378e8aebd Merge pull request #796 from alphagov/hide-csv-on-dashboard-again 
Really hide the ‘download CSV’ link in the tour
 2016-07-19 13:20:50 +01:00
Chris Hill-Scott
52d5841bbe Reduce indentation by combining with statements 2016-07-19 12:47:16 +01:00
Chris Hill-Scott
86a4daa4e8 Don’t pass entire job thru to notifications page 
It only needs the `id`, and it only needs that to generate the download
URL, so let’s just pass the URL through instead.
 2016-07-19 12:47:06 +01:00
Chris Hill-Scott
55902d2927 Add a test for the ‘available for 7 days’ text 
So that we can check it’s still correct when we make it dynamic.
 2016-07-19 12:46:45 +01:00
Chris Hill-Scott
cfadead292 Make it clearer what you’re downloading 
The previous text didn’t make it clear _what_ you were downloading as a
CSV file, you had to infer it from the context.

And the fact that it’s a CSV file is immaterial, it’s the data you care
about, not the format.
 2016-07-19 12:46:20 +01:00
Chris Hill-Scott
83c1035f1b Really hide the ‘download CSV’ link in the tour 
Tried to do this in
https://github.com/alphagov/notifications-admin/pull/743

Didn’t account for it reappearing when the AJAX fired, because the AJAX
request didn’t account for whether or not the user was in the tour.
 2016-07-19 09:32:41 +01:00
Chris Hill-Scott
500a503f07 Rewrite job page test to use Beautiful Soup 
Beautiful Soup makes it easier to do assertions on specific pieces of
text. The diffs are more useful than when you do `if 'text' in page`.
 2016-07-18 09:07:02 +01:00
Leo Hemsted
5bd90bba64 make test folder structure align with app folder structure 2016-07-15 15:23:40 +01:00
Leo Hemsted
1cd2841c17 rename api_client to service_api_client 2016-07-15 15:23:23 +01:00
Chris Hill-Scott
6d5561267b Merge pull request #792 from alphagov/upgrade-utils-bleach-fix 
Upgrade utils to fix bleach version issue
 2016-07-15 13:47:36 +01:00
Chris Hill-Scott
93f7390f65 Upgrade utils to fix bleach version issue 
Brings in:
- [x] https://github.com/alphagov/notifications-utils/pull/53
 2016-07-15 13:42:43 +01:00
Chris Hill-Scott
1c8c86bd1c Merge pull request #781 from alphagov/template-previews 
Adds previews of email templates
 2016-07-15 10:35:15 +01:00
Adam Shimali
8f7eaa784b Merge pull request #787 from alphagov/message-limit-increase-fix 
Increase daily message limit for unrestricted services
 2016-07-14 13:36:51 +01:00
Adam Shimali
22601ab4f6 Increase daily message limit for unrestricted services. 
This pr is for:

https://www.pivotaltracker.com/story/show/126230157
 2016-07-14 11:38:54 +01:00
Chris Hill-Scott
4dcd8906c8 Merge pull request #784 from alphagov/wonky-tables 
Fix wonky tables on dashboard and activity page
 2016-07-14 09:16:16 +01:00
Chris Hill-Scott
9c83d559f3 Fix wonky tables on dashboard and activity page 
Tables with a `layout` of `fixed` determine column widths from the
width of the column headings.

We weren’t setting the width of the first column heading, so our tables
were getting out of alignment.
 2016-07-13 16:56:28 +01:00
Chris Hill-Scott
1f90a7eee0 Show full email template on single template page 
There’s no point in collapsing […] the email on the single template
page because it’s the only thing on the page.

Users will probably be going back and forth quite a bit to edit their
template and see the changes; they shouldn’t have to expanded it evey
time to check they’ve got the heading syntax right, for example.
 2016-07-13 08:55:59 +01:00
Chris Hill-Scott
c006b8748c Add conditional placeholder detection 
Implements: https://github.com/alphagov/notifications-utils/pull/51

Copies the same regex.

Adds some CSS to display conditional placeholders differently to
normal placeholders (vertical rather that curved right-hand edge).
 2016-07-12 17:11:52 +01:00
Chris Hill-Scott
d380eaf060 Allow images to be served from live domain 
Currently images in our email template are hardcoded to be served from
the live domain[1].

In order for the admin app, running locally or in preview/staging, to be
able to load these images when previewing an email template, the CSP
headers need to allow this domain.

Also splits the header string up using string literal concatenation[2]
so that it’s easier to read.

1. https://notifications.service.gov.uk
2. https://docs.python.org/3/reference/lexical_analysis.html#string-literal-concatenation
 2016-07-12 16:46:46 +01:00
Chris Hill-Scott
9f91694c71 Add a ‘private’ preview email template endpoint 
This will make working on the email template easier.

Includes examples of features like lists, headings, blockquotes, etc.
 2016-07-12 16:46:46 +01:00
Rebecca Law
76369b3d10 Merge pull request #772 from alphagov/email-registered-users 
Add api client call to email users that are already registered
 2016-07-12 13:12:01 +01:00
Rebecca Law
43938936f3 If a user has already registered with the email they will get a different email when the register again. 
The email includes likes to sign in and send feedback
 2016-07-12 11:53:30 +01:00
Rebecca Law
b4525d0a64 Merge branch 'master' into email-registered-users 2016-07-12 11:05:16 +01:00
catherineheywood
df63dc5245 Remove sections 
Remove sections About GOV.UK Notify and Getting started
 2016-07-12 09:20:41 +01:00
Chris Hill-Scott
f3cf4bf708 Fix mismatch HTML tags in doc 2016-07-12 09:08:42 +01:00
Chris Hill-Scott
9f67b137ad Merge pull request #775 from alphagov/reasons-for-failure 
Make ‘temporary failure’ clearer in frontend and CSV downloads
 2016-07-12 08:46:28 +01:00
catherineheywood
dd0ff77c83 Merge pull request #776 from alphagov/keys 
Keys
 2016-07-12 08:34:20 +01:00
Catherine Heywood
f17675155b improve readability 2016-07-11 15:46:42 +01:00
Catherine Heywood
4da3baffe4 link to API keys section 2016-07-11 15:45:07 +01:00
Catherine Heywood
1f38f8293b revert 2016-07-11 15:43:30 +01:00
Catherine Heywood
96eb67613e reformat info in table for test 2016-07-11 15:42:18 +01:00
Catherine Heywood
0ea063f968 add commas in table 2016-07-11 15:41:15 +01:00
Catherine Heywood
2a10134087 add 'to' 2016-07-11 15:40:36 +01:00
Catherine Heywood
23082d784b minor edit to respect style guide 2016-07-11 15:17:06 +01:00
Catherine Heywood
cd94e37b7c move table up 2016-07-11 15:07:55 +01:00