darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-25 03:30:53 -04:00
Code Issues Packages Projects Releases Wiki Activity

add tests for service_api_client

Browse Source
This commit is contained in:
Leo Hemsted
2016-07-21 17:32:28 +01:00
parent 0cc2a90a1a
commit 6ff77c995e
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/__init__.py
View File

@@ -325,7 +325,7 @@ def register_errorhandlers(application):
@application.errorhandler(HTTPError)
def render_http_error(error):
application.logger.error("API {} failed with status {} message {}".format(
error.response.url,
error.response.url if error.response else 'unknown',
error.status_code,
error.message
))

16
tests/app/notify_client/test_service_api_client.py
View File

@@ -19,3 +19,19 @@ def test_client_posts_archived_true_when_deleting_template(mocker):
client.delete_service_template(service_id, template_id)
mock_post.assert_called_once_with(expected_url, data=expected_data)
def test_client_gets_service_with_no_params(mocker):
client = ServiceAPIClient()
mock_post = mocker.patch('app.notify_client.service_api_client.ServiceAPIClient.get')
client.get_service('foo')
mock_post.assert_called_once_with('/service/foo', params={})
def test_client_gets_service_with_detailed_params(mocker):
client = ServiceAPIClient()
mock_post = mocker.patch('app.notify_client.service_api_client.ServiceAPIClient.get')
client.get_detailed_service('foo')
mock_post.assert_called_once_with('/service/foo', params={'detailed': True})