darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 18:22:37 -04:00
Code Issues Packages Projects Releases Wiki Activity
12,013 Commits 60 Branches 61 Tags
8576b4a6f07ba3d3f965cfd75975e3546fcc9e2d
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Pea Tyczynska c42fc071b5 Merge pull request #4020 from alphagov/update-service-name-hint-text 
Add additional instructions for the service name
 2021-09-14 12:18:46 +01:00
Pea Tyczynska af6b1d38b5 Merge pull request #3984 from alphagov/handle-cancel-letter-errors-from-api 
Catch cancel_letter errors from API
 2021-08-03 11:05:46 +01:00
Pea Tyczynska e1420e7ff7 Catch cancel_letter errors from API 
When we catch such error, if the message is recognised,
show the message and redirect user to view_notification page.
 2021-07-28 12:55:06 +01:00
Pea Tyczynska 61e52faaee Merge pull request #3962 from alphagov/fix-bug-conditional-multiline 
Bump utils to revert a bug to conditional multiline placeholders
 2021-07-09 14:05:46 +01:00
Pea Tyczynska 7f08ae7c29 Bump utils to revert a bug to conditional multiline placeholders 2021-07-09 13:51:39 +01:00
Pea Tyczynska 7930a53a58 Merge pull request #3935 from alphagov/more-detailed-request-go-live-ticket 
Make a label more descriptive in request-to-go-live ticket
 2021-06-18 10:01:50 +01:00
Pea Tyczynska d1dc1aec6c Make a label more descriptive in request-to-go-live ticket 
We have a label saying "other live services". This label means
other live services for a user making the request, but it could
also be interpreted as other live services for an organisation.

Hence, we are changing the label to "other live services for
that user" to avoid confusion
 2021-06-17 17:53:28 +01:00
Pea Tyczynska ac757b0fc1 Merge pull request #3904 from alphagov/platform-admin-reply-to 
Let platform admins add or update service reply to email address without the need for verification.
 2021-06-02 10:46:05 +01:00
Pea Tyczynska 4b3e826ec8 Let platform admins add or update service reply to email address 
without the need for verification.

This is for when the email takes too long to arrive and the service
users cannot update it as a result.

A more streamlined solution has been proposed where we could send
a link in the verification email to the users and clicking that
link would add/update reply-email-to address.
That would require a bit more work so right now I am proposing this
as a quick stop gap so that we don't have to go to the database
manually to add the reply-to email address.
 2021-05-28 15:06:31 +01:00
Pea Tyczynska a10304d9c6 Merge pull request #3892 from alphagov/update-remove-webauthn-cred 
Let admin user update and delete their security key
 2021-05-25 14:33:00 +01:00
Pea Tyczynska 04d1d97d4c Refactor loop to separate function and use user model 
when getting a list of security keys

Also test separately that we are correctly choosing key out of list
of security keys. Previously we have done it as a part
of testing pages where where we were calling API to get a list
of keys, but then choosing one of those keys based on id.

Also remove redundant second test credential after PR review

Also remove redundant return value from mocks in update name tests
 2021-05-25 14:17:58 +01:00
Pea Tyczynska 8501aa4ad6 Change name of the form and form field for consistency 
Following PR review.

Also update function name for update name of security key in
user api client to be more specific.
 2021-05-25 11:55:48 +01:00
Pea Tyczynska e384d3e0a1 Test all manage security keys pages against unauthorised access 2021-05-25 11:55:47 +01:00
Pea Tyczynska 724e345089 Do not call API if key name did not change 
To avoid unnecessary calls to API.
 2021-05-25 11:55:47 +01:00
Pea Tyczynska a907f261a5 Catch last credential error from API 
When we are unable to delete security key because it's the last
one for that user, API throws an error. Here we catch that error
and display useful message to the user.

Use security key instead of webauthn credential

in user facing message - for consistency and readability.

We use security key term in user facing stuff and webauthn
credential in the code.
 2021-05-25 11:55:37 +01:00
Pea Tyczynska a946ad6ec2 Let admin user delete their security key 
Show confiem delete dialogue first to confirm if key should be deleted.
 2021-05-25 11:40:42 +01:00
Pea Tyczynska 00c022eba5 Let admin user update their security key name 2021-05-25 11:40:41 +01:00
Pea Tyczynska 56eac279df Show manage security key page with name change form 2021-05-25 11:40:41 +01:00
Pea Tyczynska c33465e7cf Add link and placeholder view for managing a security key 2021-05-25 11:40:33 +01:00
Pea Tyczynska 714afff156 Merge pull request #3884 from alphagov/add-webauthn-as-auth-type 
Add webauthn as an auth type
 2021-05-13 14:32:03 +01:00
Pea Tyczynska 2a756f90d4 Add webauth as an auth type 
When showing what auth type user uses to sign in, add a text
for users with webauthn.

On password change or sign in, throw not implemented error
if user uses webauthn auth.
 2021-05-12 17:40:31 +01:00
Pea Tyczynska c55cc4574e Merge pull request #3854 from alphagov/admin-cancel-broadcast 
Allow platform admins to cancel broadcasts.
 2021-04-21 12:52:14 +01:00
Pea Tyczynska d77ec8a5ca Test that user without permission cannot reject broadcast 2021-04-20 17:27:56 +01:00
Pea Tyczynska 28378fdd3d Test that user without permission cannot accept broadcast 
Also fix incorrect docstring.
 2021-04-20 17:27:56 +01:00
Pea Tyczynska 6999d3bceb Refactor platform admin user fixtures 
To make the code more DRY
 2021-04-20 17:27:56 +01:00
Pea Tyczynska 0c0d9dd72f Admins won't see buttons for broadcast actions they can't do 
These actions are creating, accepting and rejecting broadcasts.
 2021-04-20 17:27:56 +01:00
Pea Tyczynska 002dd7485d Allow platform admins to cancel broadcasts. 
Do not allow platform admins to:
- create broadcasts
- approve broadcasts
- reject broadcasts

that is, unless they have a send_messages permission
for a given service.

This is so platform admins have the minimum permissions necessary
to cancel a broadcast that might have been sent out accidentally.
 2021-04-20 17:27:55 +01:00
Pea Tyczynska a22fb3eb4e Merge pull request #3839 from alphagov/billing-report 
Transform usage report to billing report
 2021-03-30 15:27:10 +01:00
Pea Tyczynska daba419b39 Fix tests - add flake8 exception and change endpoint name in navigation tests 2021-03-30 15:16:02 +01:00
Pea Tyczynska f7142a1518 Catch validation error from API 
When dates chosen for billing report are not in the same
financial year, API throws an error. This error was not being
caught so far. This PR starts to catch it and display a banner
with error message on the page, instead of page crashing.
 2021-03-30 14:13:57 +01:00
Pea Tyczynska 38cfee6390 Rename usage report to billing report 
Because only services with bills to pay are included, and
we started including billing details.

Also rename endpoints and file names to match this.
 2021-03-30 14:13:54 +01:00
Pea Tyczynska 95f46ced8a Add billing details fields to Usage for all services report 2021-03-30 14:11:42 +01:00
Pea Tyczynska 2a9ebfb1cc Merge pull request #3849 from alphagov/allow-double-hyphens-in-email-domains 
Bump utils to allow double hyphens in email address domain
 2021-03-30 11:06:14 +01:00
Pea Tyczynska a631942d55 Bump utils to allow double hyphens in email address domain 
It was requested by our user and it is an allowed domain format
with Amazon SES, so we started allowing it in our validation.
 2021-03-29 17:38:37 +01:00
Pea Tyczynska 0199709adb Merge pull request #3788 from alphagov/org-billing-details 
View and edit notes and billing details for organisation
 2021-02-16 15:31:43 +00:00
Pea Tyczynska 47f20ae438 Change content following content review 2021-02-16 15:20:15 +00:00
Pea Tyczynska 7c34a9bd46 Update pyaml 2021-02-16 14:48:43 +00:00
Pea Tyczynska 5a342b2a39 Test that only platform admins can update org notes 2021-02-16 14:46:14 +00:00
Pea Tyczynska d7596f81fb Add screen reader suffixes on all org settings 
So screen reader users have consistent experience.
 2021-02-16 14:46:14 +00:00
Pea Tyczynska 741beeb903 Add test case for when organisation notes do not change 2021-02-16 14:46:14 +00:00
Pea Tyczynska b2e4f76f94 Fix import order 2021-02-16 14:46:13 +00:00
Pea Tyczynska eb9e6e2c71 Update organisation billing details 2021-02-16 14:46:13 +00:00
Pea Tyczynska 36c72bb4cc View edit organisation billing details page 2021-02-16 14:46:13 +00:00
Pea Tyczynska f4dc2a173e Link to edit billing details page for organisation 2021-02-16 14:46:13 +00:00
Pea Tyczynska 8ea748f6e4 Update organisation notes 2021-02-16 14:46:12 +00:00
Pea Tyczynska e090d97997 View edit organisation notes page 
Also fix page title for edit service notes page.
 2021-02-16 14:46:12 +00:00
Pea Tyczynska 56b777872e Organisation billing details visible on organisation settings page 2021-02-16 14:46:12 +00:00
Pea Tyczynska f0d94a009e Organisation notes visible on organisation settings page 2021-02-16 14:46:11 +00:00
Pea Tyczynska 5bc229222b Merge pull request #3779 from alphagov/show-billing-details-for-service 
Show billing details for service
 2021-02-03 10:52:50 +00:00
Pea Tyczynska 25534dbee3 Remove 'billing' from option labels 
They were unnecessary it turned out.
 2021-02-03 10:30:02 +00:00
Pea TyczynskaandChris Hill-Scott 0f6cbdf27e Add extra spacing to billing details and remove unnecessary autofocus 
Add more spacing between characters for billing reference number and PO number, so they are easier to read. 

Also remove unnecessary autofocus.

Co-authored-by: Chris Hill-Scott <me@quis.cc>
 2021-02-03 10:30:02 +00:00
Pea Tyczynska c60be7000a Add notes to edit billing details page 
As per ticket and as per Caley's request, so everything can be
edited together.

Also pluralise labels for billing contact info, to indicate
that putting multiple in is ok, and widen the input fields so
that it is more comfortable to input multiple contact details.
 2021-02-03 10:30:02 +00:00
Pea Tyczynska 079f371bc5 Update attribute names following changes in API 2021-02-03 10:30:01 +00:00
Pea Tyczynska 8f21caa87a Change service billing details 
View page that lets you change service billing details and
update details on form submission.
 2021-02-03 10:30:01 +00:00
Pea Tyczynska 73031962a7 Change link leads to edit billing details view 2021-02-03 10:29:19 +00:00
Pea Tyczynska d82f90754f Fix permissions for edit service note page 2021-02-03 10:29:18 +00:00
Pea Tyczynska 4a7bfcc9c5 Add billing details property 
This property lets service settings know if there are any
billing details to preview.
 2021-02-03 10:29:18 +00:00
Pea Tyczynska 8219e5a2f9 Show billing details row for admins on service settings page 2021-02-03 10:29:18 +00:00
Pea Tyczynska f5e639050b Merge pull request #3784 from alphagov/notes-fix 
Allow to update service notes
 2021-02-02 17:37:27 +00:00
Pea Tyczynska 77008fe3cc Update requirements - install patch for jinja2 vulnerability 2021-02-02 17:13:18 +00:00
Pea Tyczynska 42b17d40b4 Test allowed attributes are really allowed 2021-02-02 16:38:56 +00:00
Pea Tyczynska 33dbfbaa65 Sort allowed attributes alphabetically 2021-02-01 17:36:04 +00:00
Pea Tyczynska f107fe260a Allow to update service notes 2021-02-01 17:13:53 +00:00
Pea Tyczynska e2ecff050d Merge pull request #3772 from alphagov/add-service-notes 
Add service notes
 2021-01-20 17:19:22 +00:00
Pea Tyczynska 5eb6ac2311 Add test for textarea 
Also remove redundant error handling - if unexpected error happens,
it will be handled at the app level.
 2021-01-19 18:25:52 +00:00
Pea TyczynskaandChris Hill-Scott 5ec49fc976 Refactor form instantiation 
Form can be pre-filled with existing data upon instantiation.
WTForms will know not to do this on POST request.

Co-authored-by: Chris Hill-Scott <me@quis.cc>
 2021-01-19 18:24:56 +00:00
Pea M. Tyczynska e6f15fb8b4 Merge pull request #3683 from alphagov/remove-unused-textbox-imports 
Remove unused textbox imports
 2020-10-16 10:48:12 +01:00
Pea M. Tyczynska b60d25da67 Merge pull request #3670 from alphagov/show-broadcast-tour-when-password-reset 
Take user to page they are meant to visit in various sign-in flow scenarios
 2020-10-12 12:27:37 +01:00
Pea M. Tyczynska f4f2e5d13a Merge pull request #3622 from alphagov/searchbox-make-autofocus-optional 
Autofocus off by default on live-search
 2020-09-29 10:58:00 +01:00
Pea M. Tyczynska 88a5fd56bf Merge pull request #3609 from alphagov/send-polygons-to-api 
Send simple polygons to API along with areas
 2020-09-08 12:23:12 +01:00
Pea M. Tyczynska 84e3a7ffd5 Merge pull request #3601 from alphagov/only-govt-users-can-be-invited-to-broadcast-services 
Broadcast: only approved domain users can be invited
 2020-08-28 15:04:50 +01:00
Pea M. Tyczynska a50ed17c14 Merge pull request #3582 from alphagov/fix-skiplink 
Fix or remove skip links on bulk send and contact list upload pages
 2020-08-20 10:23:36 +01:00
Pea M. Tyczynska 9b69d16963 Merge pull request #3554 from alphagov/convert-single-line-textboxes-to-govuk-frontend 
Convert single line textboxes to govuk frontend
 2020-08-18 11:29:44 +01:00
Pea M. Tyczynska 3bbce24b06 Merge pull request #3558 from alphagov/only-allow-new-template-if-permission-is-there 
Services can only create templates of types they have turned on
 2020-08-17 14:39:16 +01:00
Pea M. Tyczynska bad1e69cc3 Merge pull request #3499 from alphagov/hint-text-org 
When changing service name, use organisation of the service for hint
 2020-07-02 12:24:51 +01:00
Pea M. Tyczynska 0ad449883d Merge pull request #3484 from alphagov/add-service-name-hint-text-for-local-authorities 
Add service name hint text for local authorities
 2020-07-02 10:11:34 +01:00
Pea M. TyczynskaandChris Hill-Scott 1b2727197a Use en dashes for better formatting 
Co-authored-by: Chris Hill-Scott <me@quis.cc>
 2020-07-01 15:30:57 +01:00
Pea M. Tyczynska 33d749ab4c Merge pull request #3460 from alphagov/handle-session-expiring-name-change 
Handle session expiring during service name change
 2020-05-27 12:27:36 +01:00
Pea M. Tyczynska 33786fc3d9 Merge pull request #3423 from alphagov/update-healthcheck-page 
Update _status page - remove references to Travis
 2020-04-24 14:37:41 +01:00
Pea M. Tyczynska 32eef2f203 Merge pull request #3401 from alphagov/tighten-erorr-check 
Tighten error check for duplicate reply to email addresses
 2020-04-06 11:30:27 +01:00
Pea M. Tyczynska a709ee4a29 Merge pull request #3397 from alphagov/postcode-validation 
Handle postcode validation for precompiled letters
 2020-04-02 14:12:39 +01:00
Pea M. Tyczynska 2bb47af3c3 Merge pull request #3389 from alphagov/fix-unhandled-errpr 
Fix bug where adding same reply-to-email twice for the same service caused a 5xx
 2020-03-31 14:08:02 +01:00
Pea M. Tyczynska 4b95fecd4f Merge pull request #3349 from alphagov/fix-logo-upload 
Fix logo upload - we need to rewind the bytestream after we read it
 2020-03-04 17:32:15 +00:00
Pea M. Tyczynska 8ecccca6c2 Merge pull request #3348 from alphagov/no-embedded-images-in-SVG-logo-files 
Do not allow to upload SVG logos with embedded raster images in them
 2020-03-04 15:41:03 +00:00
Pea M. Tyczynska b6e0b7f97d Merge pull request #3307 from alphagov/send-by-email-setting 
Users now able to set the send by email setting by themselves
 2020-02-27 16:15:16 +00:00
Pea M. Tyczynska a8ca8c1835 Merge pull request #3311 from alphagov/revert-3295-restyle-template-stats 
Revert "Restyle template statistics and received text messages"
 2020-02-18 15:04:59 +00:00
Pea M. Tyczynska e97f9f7fa4 Merge pull request #3310 from alphagov/fix-reset-password 
Fix reset password flow
 2020-02-18 15:03:11 +00:00
Pea M. Tyczynska 49eb2a8354 Merge pull request #3281 from alphagov/re-validate-email 
Check access to email address after 90 days
 2020-02-18 11:10:31 +00:00
Pea M. Tyczynskaandkarlchillmaid c24a60a6a7 Update content following content review 
Co-Authored-By: karlchillmaid <karl.chillmaid@digital.cabinet-office.gov.uk>

Also update content for resend email and sms 2FA code page
 2020-02-17 11:36:05 +00:00
Pea M. Tyczynska b5723a1aef Merge pull request #3285 from alphagov/uploads-fix-letter-link 
Fix bug where job url type was constructed for letter on uploads page
 2020-02-04 16:26:49 +00:00
Pea M. Tyczynska ba6b412bca Merge pull request #3268 from alphagov/proper-form-for-letter-branding 
Parametrise branding request flow so it serves both email and letter branding
 2020-01-23 16:50:41 +00:00
Pea M. Tyczynska fdff9d3b83 Ensure gov.uk branding only available for emails and not for letters 
Also align and statements
 2020-01-23 16:34:58 +00:00
Pea M. TyczynskaandChris Hill-Scott cc61e87701 Parametrized options label for the branding request form 
Co-Authored-By: Chris Hill-Scott <me@quis.cc>
 2020-01-21 16:47:42 +00:00
Pea M. Tyczynska b3380ad7b5 Merge pull request #3250 from alphagov/fix-re-upload-button 
Fix exception in track-error js module that broke our re-upload button
 2020-01-09 16:36:44 +00:00
Pea M. Tyczynska 0d8824c3e9 Merge pull request #3193 from alphagov/validate-against-empty-messages 
Validate CSVs against rows with empty messages
 2019-12-03 14:12:04 +00:00
Pea M. Tyczynska 5e60095584 Merge pull request #3200 from alphagov/finetune-letter-uploads-valdiation-failed 
Add re-upload button and back link to the preview page
 2019-11-27 15:17:19 +00:00
Pea (Malgorzata Tyczynska) d07a370658 Merge pull request #3179 from alphagov/validate-service-and-org-name 
Validate service and organisation name
 2019-11-20 13:37:10 +00:00
Pea (Malgorzata Tyczynska) 21a59598b2 Merge pull request #3170 from alphagov/show-users-why-their-precompiled-letter-failed-validation 
Show users why their precompiled letter failed validation
 2019-11-07 11:23:30 +00:00
Pea (Malgorzata Tyczynska) 53ef438a1e Merge pull request #3135 from alphagov/enforce_letter_10_page_limit 
Enforce letter 10 page limit
 2019-10-16 13:14:30 +01:00
Pea (Malgorzata Tyczynska) 28c901d5b9 Merge pull request #3130 from alphagov/notification-coubt 
Get notification count from api instead of getting list of notifications from api
 2019-10-08 12:19:55 +01:00