darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 17:38:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3784 from alphagov/notes-fix

Browse Source 
Allow to update service notes
This commit is contained in:
Pea Tyczynska
2021-02-02 17:37:27 +00:00
committed by GitHub
parent 0cedf39992 77008fe3cc
commit f5e639050b
5 changed files with 656 additions and 197 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
app/notify_client/service_api_client.py
View File

@@ -79,31 +79,32 @@ class ServiceAPIClient(NotifyAdminAPIClient):
"""
data = _attach_current_user(kwargs)
disallowed_attributes = set(data.keys()) - {
'name',
'message_limit',
'active',
'restricted',
'consent_to_research',
'contact_link',
'count_as_live',
'created_by',
'email_branding',
'email_from',
'free_sms_fragment_limit',
'go_live_at',
'go_live_user',
'letter_branding',
'letter_contact_block',
'message_limit',
'name',
'notes',
'organisation_type',
'permissions',
'prefix_sms',
'rate_limit',
'reply_to_email_address',
'research_mode',
'restricted',
'sms_sender',
'created_by',
'letter_branding',
'email_branding',
'letter_contact_block',
'permissions',
'organisation_type',
'free_sms_fragment_limit',
'prefix_sms',
'contact_link',
'volume_email',
'volume_sms',
'volume_letter',
'consent_to_research',
'count_as_live',
'go_live_user',
'go_live_at',
'rate_limit',
'volume_sms',
}
if disallowed_attributes:
raise TypeError('Not allowed to update service attributes: {}'.format(

2
requirements.in
View File

@@ -25,7 +25,7 @@ awscli-cwlogs>=1.4,<1.5
itsdangerous==1.1.0
git+https://github.com/alphagov/notifications-utils.git@43.7.0#egg=notifications-utils==43.7.0
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.1-alpha#egg=govuk-frontend-jinja==0.5.1-alpha
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.8-alpha#egg=govuk-frontend-jinja==0.5.8-alpha
# gds-metrics requires prometheseus 0.2.0, override that requirement as later versions bring significant performance gains
prometheus-client==0.9.0

283
requirements.txt
View File

@@ -4,81 +4,214 @@
#
# pip-compile requirements.in
#
ago==0.0.93 # via -r requirements.in
awscli-cwlogs==1.4.6 # via -r requirements.in
awscli==1.18.211 # via awscli-cwlogs, notifications-utils
bleach==3.2.1 # via notifications-utils
blinker==1.4 # via -r requirements.in, gds-metrics
boto3==1.16.51 # via notifications-utils
botocore==1.19.51 # via awscli, boto3, s3transfer
cachetools==4.2.0 # via notifications-utils
certifi==2020.12.5 # via requests
chardet==4.0.0 # via requests
click==7.1.2 # via flask
colorama==0.4.3 # via awscli
dnspython==1.16.0 # via eventlet
docopt==0.6.2 # via notifications-python-client
docutils==0.15.2 # via awscli
et-xmlfile==1.0.1 # via openpyxl
eventlet==0.30.0 # via -r requirements.in
flask-login==0.5.0 # via -r requirements.in
flask-redis==0.4.0 # via notifications-utils
flask-wtf==0.14.3 # via -r requirements.in
flask==1.1.2 # via -r requirements.in, flask-login, flask-redis, flask-wtf, gds-metrics, notifications-utils
future==0.18.2 # via notifications-python-client
gds-metrics==0.2.4 # via -r requirements.in
geojson==2.5.0 # via notifications-utils
govuk-bank-holidays==0.8 # via -r requirements.in, notifications-utils
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.1-alpha#egg=govuk-frontend-jinja==0.5.1-alpha # via -r requirements.in
greenlet==0.4.17 # via eventlet
gunicorn==20.0.4 # via -r requirements.in
humanize==3.2.0 # via -r requirements.in
idna==2.10 # via requests
itsdangerous==1.1.0 # via -r requirements.in, flask, flask-wtf, notifications-utils
jdcal==1.4.1 # via openpyxl
jinja2==2.11.2 # via flask, govuk-frontend-jinja, notifications-utils
jmespath==0.10.0 # via boto3, botocore
lml==0.1.0 # via pyexcel, pyexcel-io
lxml==4.6.2 # via pyexcel-ezodf, pyexcel-ods3
markupsafe==1.1.1 # via jinja2, wtforms
mistune==0.8.4 # via notifications-utils
monotonic==1.5 # via notifications-python-client, notifications-utils
notifications-python-client==5.7.1 # via -r requirements.in
git+https://github.com/alphagov/notifications-utils.git@43.7.0#egg=notifications-utils==43.7.0 # via -r requirements.in
openpyxl==3.0.5 # via pyexcel-xlsx
orderedset==2.0.3 # via notifications-utils
packaging==20.8 # via bleach
phonenumbers==8.12.15 # via notifications-utils
prometheus-client==0.9.0 # via -r requirements.in, gds-metrics
pyasn1==0.4.8 # via rsa
pyexcel-ezodf==0.3.4 # via pyexcel-ods3
pyexcel-io==0.6.4 # via -r requirements.in, pyexcel, pyexcel-ods3, pyexcel-xls, pyexcel-xlsx
pyexcel-ods3==0.6.0 # via -r requirements.in
pyexcel-xls==0.6.2 # via -r requirements.in
pyexcel-xlsx==0.6.0 # via -r requirements.in
pyexcel==0.6.6 # via -r requirements.in
pyjwt==2.0.0 # via notifications-python-client
pyparsing==2.4.7 # via packaging
pypdf2==1.26.0 # via notifications-utils
python-dateutil==2.8.1 # via awscli-cwlogs, botocore
python-json-logger==2.0.1 # via notifications-utils
pytz==2020.5 # via -r requirements.in, notifications-utils
pyyaml==5.3.1 # via awscli, notifications-utils
redis==3.5.3 # via flask-redis
requests==2.25.1 # via awscli-cwlogs, govuk-bank-holidays, notifications-python-client, notifications-utils
rsa==4.5 # via awscli
s3transfer==0.3.3 # via awscli, boto3
shapely==1.7.1 # via -r requirements.in
six==1.15.0 # via awscli-cwlogs, bleach, eventlet, govuk-bank-holidays, python-dateutil
smartypants==2.0.1 # via notifications-utils
statsd==3.3.0 # via notifications-utils
texttable==1.6.3 # via pyexcel
urllib3==1.26.2 # via botocore, requests
webencodings==0.5.1 # via bleach
werkzeug==1.0.1 # via flask
wtforms==2.3.3 # via flask-wtf
xlrd==1.2.0 # via pyexcel-xls
xlwt==1.3.0 # via pyexcel-xls
ago==0.0.93
# via -r requirements.in
awscli-cwlogs==1.4.6
# via -r requirements.in
awscli==1.18.211
# via
# awscli-cwlogs
# notifications-utils
bleach==3.2.1
# via notifications-utils
blinker==1.4
# via
# -r requirements.in
# gds-metrics
boto3==1.16.51
# via notifications-utils
botocore==1.19.51
# via
# awscli
# boto3
# s3transfer
cachetools==4.2.0
# via notifications-utils
certifi==2020.12.5
# via requests
chardet==4.0.0
# via requests
click==7.1.2
# via flask
colorama==0.4.3
# via awscli
dnspython==1.16.0
# via eventlet
docopt==0.6.2
# via notifications-python-client
docutils==0.15.2
# via awscli
et-xmlfile==1.0.1
# via openpyxl
eventlet==0.30.0
# via -r requirements.in
flask-login==0.5.0
# via -r requirements.in
flask-redis==0.4.0
# via notifications-utils
flask-wtf==0.14.3
# via -r requirements.in
flask==1.1.2
# via
# -r requirements.in
# flask-login
# flask-redis
# flask-wtf
# gds-metrics
# notifications-utils
future==0.18.2
# via notifications-python-client
gds-metrics==0.2.4
# via -r requirements.in
geojson==2.5.0
# via notifications-utils
govuk-bank-holidays==0.8
# via
# -r requirements.in
# notifications-utils
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.8-alpha#egg=govuk-frontend-jinja==0.5.8-alpha
# via -r requirements.in
greenlet==0.4.17
# via eventlet
gunicorn==20.0.4
# via -r requirements.in
humanize==3.2.0
# via -r requirements.in
idna==2.10
# via requests
itsdangerous==1.1.0
# via
# -r requirements.in
# flask
# flask-wtf
# notifications-utils
jdcal==1.4.1
# via openpyxl
jinja2==2.11.3
# via
# flask
# govuk-frontend-jinja
# notifications-utils
jmespath==0.10.0
# via
# boto3
# botocore
lml==0.1.0
# via
# pyexcel
# pyexcel-io
lxml==4.6.2
# via
# pyexcel-ezodf
# pyexcel-ods3
markupsafe==1.1.1
# via
# jinja2
# wtforms
mistune==0.8.4
# via notifications-utils
monotonic==1.5
# via
# notifications-python-client
# notifications-utils
notifications-python-client==5.7.1
# via -r requirements.in
git+https://github.com/alphagov/notifications-utils.git@43.7.0#egg=notifications-utils==43.7.0
# via -r requirements.in
openpyxl==3.0.5
# via pyexcel-xlsx
orderedset==2.0.3
# via notifications-utils
packaging==20.8
# via bleach
phonenumbers==8.12.15
# via notifications-utils
prometheus-client==0.9.0
# via
# -r requirements.in
# gds-metrics
pyasn1==0.4.8
# via rsa
pyexcel-ezodf==0.3.4
# via pyexcel-ods3
pyexcel-io==0.6.4
# via
# -r requirements.in
# pyexcel
# pyexcel-ods3
# pyexcel-xls
# pyexcel-xlsx
pyexcel-ods3==0.6.0
# via -r requirements.in
pyexcel-xls==0.6.2
# via -r requirements.in
pyexcel-xlsx==0.6.0
# via -r requirements.in
pyexcel==0.6.6
# via -r requirements.in
pyjwt==2.0.0
# via notifications-python-client
pyparsing==2.4.7
# via packaging
pypdf2==1.26.0
# via notifications-utils
python-dateutil==2.8.1
# via
# awscli-cwlogs
# botocore
python-json-logger==2.0.1
# via notifications-utils
pytz==2020.5
# via
# -r requirements.in
# notifications-utils
pyyaml==5.3.1
# via
# awscli
# notifications-utils
redis==3.5.3
# via flask-redis
requests==2.25.1
# via
# awscli-cwlogs
# govuk-bank-holidays
# notifications-python-client
# notifications-utils
rsa==4.5
# via awscli
s3transfer==0.3.3
# via
# awscli
# boto3
shapely==1.7.1
# via -r requirements.in
six==1.15.0
# via
# awscli-cwlogs
# bleach
# eventlet
# govuk-bank-holidays
# python-dateutil
smartypants==2.0.1
# via notifications-utils
statsd==3.3.0
# via notifications-utils
texttable==1.6.3
# via pyexcel
urllib3==1.26.2
# via
# botocore
# requests
webencodings==0.5.1
# via bleach
werkzeug==1.0.1
# via flask
wtforms==2.3.3
# via flask-wtf
xlrd==1.2.0
# via pyexcel-xls
xlwt==1.3.0
# via pyexcel-xls
# The following packages are considered to be unsafe in a requirements file:
# setuptools

482
requirements_for_test.txt
View File

@@ -4,109 +4,385 @@
#
# pip-compile requirements_for_test.in
#
ago==0.0.93 # via -r requirements.txt
apipkg==1.5 # via execnet
attrs==20.3.0 # via flake8-bugbear, pytest
awscli-cwlogs==1.4.6 # via -r requirements.txt
awscli==1.18.211 # via -r requirements.txt, awscli-cwlogs, notifications-utils
beautifulsoup4==4.8.1 # via -r requirements_for_test.in
bleach==3.2.1 # via -r requirements.txt, notifications-utils
blinker==1.4 # via -r requirements.txt, gds-metrics
boto3==1.16.51 # via -r requirements.txt, notifications-utils
botocore==1.19.51 # via -r requirements.txt, awscli, boto3, s3transfer
cachetools==4.2.0 # via -r requirements.txt, notifications-utils
certifi==2020.12.5 # via -r requirements.txt, requests
chardet==4.0.0 # via -r requirements.txt, requests
click==7.1.2 # via -r requirements.txt, flask
colorama==0.4.3 # via -r requirements.txt, awscli
dnspython==1.16.0 # via -r requirements.txt, eventlet
docopt==0.6.2 # via -r requirements.txt, notifications-python-client
docutils==0.15.2 # via -r requirements.txt, awscli
entrypoints==0.3 # via flake8
et-xmlfile==1.0.1 # via -r requirements.txt, openpyxl
eventlet==0.30.0 # via -r requirements.txt
execnet==1.7.1 # via pytest-xdist
flake8-bugbear==19.8.0 # via -r requirements_for_test.in
flake8-print==3.1.4 # via -r requirements_for_test.in
flake8==3.7.9 # via -r requirements_for_test.in, flake8-bugbear, flake8-print
flask-login==0.5.0 # via -r requirements.txt
flask-redis==0.4.0 # via -r requirements.txt, notifications-utils
flask-wtf==0.14.3 # via -r requirements.txt
flask==1.1.2 # via -r requirements.txt, flask-login, flask-redis, flask-wtf, gds-metrics, notifications-utils
freezegun==0.3.12 # via -r requirements_for_test.in
future==0.18.2 # via -r requirements.txt, notifications-python-client
gds-metrics==0.2.4 # via -r requirements.txt
geojson==2.5.0 # via -r requirements.txt, notifications-utils
govuk-bank-holidays==0.8 # via -r requirements.txt, notifications-utils
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.1-alpha#egg=govuk-frontend-jinja==0.5.1-alpha # via -r requirements.txt
greenlet==0.4.17 # via -r requirements.txt, eventlet
gunicorn==20.0.4 # via -r requirements.txt
humanize==3.2.0 # via -r requirements.txt
idna==2.10 # via -r requirements.txt, requests
importlib-metadata==3.3.0 # via pluggy, pytest
isort==4.3.21 # via -r requirements_for_test.in
itsdangerous==1.1.0 # via -r requirements.txt, flask, flask-wtf, notifications-utils
jdcal==1.4.1 # via -r requirements.txt, openpyxl
jinja2-cli[yaml]==0.7.0 # via -r requirements_for_test.in
jinja2==2.11.2 # via -r requirements.txt, flask, govuk-frontend-jinja, jinja2-cli, notifications-utils
jmespath==0.10.0 # via -r requirements.txt, boto3, botocore
lml==0.1.0 # via -r requirements.txt, pyexcel, pyexcel-io
lxml==4.6.2 # via -r requirements.txt, pyexcel-ezodf, pyexcel-ods3
markupsafe==1.1.1 # via -r requirements.txt, jinja2, wtforms
mccabe==0.6.1 # via flake8
mistune==0.8.4 # via -r requirements.txt, notifications-utils
monotonic==1.5 # via -r requirements.txt, notifications-python-client, notifications-utils
more-itertools==8.6.0 # via pytest
notifications-python-client==5.7.1 # via -r requirements.txt
git+https://github.com/alphagov/notifications-utils.git@43.7.0#egg=notifications-utils==43.7.0 # via -r requirements.txt
openpyxl==3.0.5 # via -r requirements.txt, pyexcel-xlsx
orderedset==2.0.3 # via -r requirements.txt, notifications-utils
packaging==20.8 # via -r requirements.txt, bleach, pytest
phonenumbers==8.12.15 # via -r requirements.txt, notifications-utils
pluggy==0.13.1 # via pytest
prometheus-client==0.9.0 # via -r requirements.txt, gds-metrics
py==1.10.0 # via pytest, pytest-forked
pyasn1==0.4.8 # via -r requirements.txt, rsa
pycodestyle==2.5.0 # via flake8, flake8-print
pyexcel-ezodf==0.3.4 # via -r requirements.txt, pyexcel-ods3
pyexcel-io==0.6.4 # via -r requirements.txt, pyexcel, pyexcel-ods3, pyexcel-xls, pyexcel-xlsx
pyexcel-ods3==0.6.0 # via -r requirements.txt
pyexcel-xls==0.6.2 # via -r requirements.txt
pyexcel-xlsx==0.6.0 # via -r requirements.txt
pyexcel==0.6.6 # via -r requirements.txt
pyflakes==2.1.1 # via flake8
pyjwt==2.0.0 # via -r requirements.txt, notifications-python-client
pyparsing==2.4.7 # via -r requirements.txt, packaging
pypdf2==1.26.0 # via -r requirements.txt, notifications-utils
pytest-env==0.6.2 # via -r requirements_for_test.in
pytest-forked==1.3.0 # via pytest-xdist
pytest-mock==1.11.2 # via -r requirements_for_test.in
pytest-xdist==1.31.0 # via -r requirements_for_test.in
pytest==5.3.2 # via -r requirements_for_test.in, pytest-env, pytest-forked, pytest-mock, pytest-xdist
python-dateutil==2.8.1 # via -r requirements.txt, awscli-cwlogs, botocore, freezegun
python-json-logger==2.0.1 # via -r requirements.txt, notifications-utils
pytz==2020.5 # via -r requirements.txt, notifications-utils
pyyaml==5.3.1 # via -r requirements.txt, awscli, jinja2-cli, notifications-utils
redis==3.5.3 # via -r requirements.txt, flask-redis
requests-mock==1.7.0 # via -r requirements_for_test.in
requests==2.25.1 # via -r requirements.txt, awscli-cwlogs, govuk-bank-holidays, notifications-python-client, notifications-utils, requests-mock
rsa==4.5 # via -r requirements.txt, awscli
s3transfer==0.3.3 # via -r requirements.txt, awscli, boto3
shapely==1.7.1 # via -r requirements.txt
six==1.15.0 # via -r requirements.txt, awscli-cwlogs, bleach, eventlet, flake8-print, freezegun, govuk-bank-holidays, pytest-xdist, python-dateutil, requests-mock
smartypants==2.0.1 # via -r requirements.txt, notifications-utils
soupsieve==2.1 # via beautifulsoup4
statsd==3.3.0 # via -r requirements.txt, notifications-utils
texttable==1.6.3 # via -r requirements.txt, pyexcel
typing-extensions==3.7.4.3 # via importlib-metadata
urllib3==1.26.2 # via -r requirements.txt, botocore, requests
wcwidth==0.2.5 # via pytest
webencodings==0.5.1 # via -r requirements.txt, bleach
werkzeug==1.0.1 # via -r requirements.txt, flask
wtforms==2.3.3 # via -r requirements.txt, flask-wtf
xlrd==1.2.0 # via -r requirements.txt, pyexcel-xls
xlwt==1.3.0 # via -r requirements.txt, pyexcel-xls
zipp==3.4.0 # via importlib-metadata
ago==0.0.93
# via -r requirements.txt
apipkg==1.5
# via execnet
attrs==20.3.0
# via
# flake8-bugbear
# pytest
awscli-cwlogs==1.4.6
# via -r requirements.txt
awscli==1.18.211
# via
# -r requirements.txt
# awscli-cwlogs
# notifications-utils
beautifulsoup4==4.8.1
# via -r requirements_for_test.in
bleach==3.2.1
# via
# -r requirements.txt
# notifications-utils
blinker==1.4
# via
# -r requirements.txt
# gds-metrics
boto3==1.16.51
# via
# -r requirements.txt
# notifications-utils
botocore==1.19.51
# via
# -r requirements.txt
# awscli
# boto3
# s3transfer
cachetools==4.2.0
# via
# -r requirements.txt
# notifications-utils
certifi==2020.12.5
# via
# -r requirements.txt
# requests
chardet==4.0.0
# via
# -r requirements.txt
# requests
click==7.1.2
# via
# -r requirements.txt
# flask
colorama==0.4.3
# via
# -r requirements.txt
# awscli
dnspython==1.16.0
# via
# -r requirements.txt
# eventlet
docopt==0.6.2
# via
# -r requirements.txt
# notifications-python-client
docutils==0.15.2
# via
# -r requirements.txt
# awscli
entrypoints==0.3
# via flake8
et-xmlfile==1.0.1
# via
# -r requirements.txt
# openpyxl
eventlet==0.30.0
# via -r requirements.txt
execnet==1.7.1
# via pytest-xdist
flake8-bugbear==19.8.0
# via -r requirements_for_test.in
flake8-print==3.1.4
# via -r requirements_for_test.in
flake8==3.7.9
# via
# -r requirements_for_test.in
# flake8-bugbear
# flake8-print
flask-login==0.5.0
# via -r requirements.txt
flask-redis==0.4.0
# via
# -r requirements.txt
# notifications-utils
flask-wtf==0.14.3
# via -r requirements.txt
flask==1.1.2
# via
# -r requirements.txt
# flask-login
# flask-redis
# flask-wtf
# gds-metrics
# notifications-utils
freezegun==0.3.12
# via -r requirements_for_test.in
future==0.18.2
# via
# -r requirements.txt
# notifications-python-client
gds-metrics==0.2.4
# via -r requirements.txt
geojson==2.5.0
# via
# -r requirements.txt
# notifications-utils
govuk-bank-holidays==0.8
# via
# -r requirements.txt
# notifications-utils
git+https://github.com/alphagov/govuk-frontend-jinja.git@v0.5.8-alpha#egg=govuk-frontend-jinja==0.5.8-alpha
# via -r requirements.txt
greenlet==0.4.17
# via
# -r requirements.txt
# eventlet
gunicorn==20.0.4
# via -r requirements.txt
humanize==3.2.0
# via -r requirements.txt
idna==2.10
# via
# -r requirements.txt
# requests
importlib-metadata==3.3.0
# via
# pluggy
# pytest
isort==4.3.21
# via -r requirements_for_test.in
itsdangerous==1.1.0
# via
# -r requirements.txt
# flask
# flask-wtf
# notifications-utils
jdcal==1.4.1
# via
# -r requirements.txt
# openpyxl
jinja2-cli[yaml]==0.7.0
# via -r requirements_for_test.in
jinja2==2.11.3
# via
# -r requirements.txt
# flask
# govuk-frontend-jinja
# jinja2-cli
# notifications-utils
jmespath==0.10.0
# via
# -r requirements.txt
# boto3
# botocore
lml==0.1.0
# via
# -r requirements.txt
# pyexcel
# pyexcel-io
lxml==4.6.2
# via
# -r requirements.txt
# pyexcel-ezodf
# pyexcel-ods3
markupsafe==1.1.1
# via
# -r requirements.txt
# jinja2
# wtforms
mccabe==0.6.1
# via flake8
mistune==0.8.4
# via
# -r requirements.txt
# notifications-utils
monotonic==1.5
# via
# -r requirements.txt
# notifications-python-client
# notifications-utils
more-itertools==8.6.0
# via pytest
notifications-python-client==5.7.1
# via -r requirements.txt
git+https://github.com/alphagov/notifications-utils.git@43.7.0#egg=notifications-utils==43.7.0
# via -r requirements.txt
openpyxl==3.0.5
# via
# -r requirements.txt
# pyexcel-xlsx
orderedset==2.0.3
# via
# -r requirements.txt
# notifications-utils
packaging==20.8
# via
# -r requirements.txt
# bleach
# pytest
phonenumbers==8.12.15
# via
# -r requirements.txt
# notifications-utils
pluggy==0.13.1
# via pytest
prometheus-client==0.9.0
# via
# -r requirements.txt
# gds-metrics
py==1.10.0
# via
# pytest
# pytest-forked
pyasn1==0.4.8
# via
# -r requirements.txt
# rsa
pycodestyle==2.5.0
# via
# flake8
# flake8-print
pyexcel-ezodf==0.3.4
# via
# -r requirements.txt
# pyexcel-ods3
pyexcel-io==0.6.4
# via
# -r requirements.txt
# pyexcel
# pyexcel-ods3
# pyexcel-xls
# pyexcel-xlsx
pyexcel-ods3==0.6.0
# via -r requirements.txt
pyexcel-xls==0.6.2
# via -r requirements.txt
pyexcel-xlsx==0.6.0
# via -r requirements.txt
pyexcel==0.6.6
# via -r requirements.txt
pyflakes==2.1.1
# via flake8
pyjwt==2.0.0
# via
# -r requirements.txt
# notifications-python-client
pyparsing==2.4.7
# via
# -r requirements.txt
# packaging
pypdf2==1.26.0
# via
# -r requirements.txt
# notifications-utils
pytest-env==0.6.2
# via -r requirements_for_test.in
pytest-forked==1.3.0
# via pytest-xdist
pytest-mock==1.11.2
# via -r requirements_for_test.in
pytest-xdist==1.31.0
# via -r requirements_for_test.in
pytest==5.3.2
# via
# -r requirements_for_test.in
# pytest-env
# pytest-forked
# pytest-mock
# pytest-xdist
python-dateutil==2.8.1
# via
# -r requirements.txt
# awscli-cwlogs
# botocore
# freezegun
python-json-logger==2.0.1
# via
# -r requirements.txt
# notifications-utils
pytz==2020.5
# via
# -r requirements.txt
# notifications-utils
pyyaml==5.3.1
# via
# -r requirements.txt
# awscli
# jinja2-cli
# notifications-utils
redis==3.5.3
# via
# -r requirements.txt
# flask-redis
requests-mock==1.7.0
# via -r requirements_for_test.in
requests==2.25.1
# via
# -r requirements.txt
# awscli-cwlogs
# govuk-bank-holidays
# notifications-python-client
# notifications-utils
# requests-mock
rsa==4.5
# via
# -r requirements.txt
# awscli
s3transfer==0.3.3
# via
# -r requirements.txt
# awscli
# boto3
shapely==1.7.1
# via -r requirements.txt
six==1.15.0
# via
# -r requirements.txt
# awscli-cwlogs
# bleach
# eventlet
# flake8-print
# freezegun
# govuk-bank-holidays
# pytest-xdist
# python-dateutil
# requests-mock
smartypants==2.0.1
# via
# -r requirements.txt
# notifications-utils
soupsieve==2.1
# via beautifulsoup4
statsd==3.3.0
# via
# -r requirements.txt
# notifications-utils
texttable==1.6.3
# via
# -r requirements.txt
# pyexcel
typing-extensions==3.7.4.3
# via importlib-metadata
urllib3==1.26.2
# via
# -r requirements.txt
# botocore
# requests
wcwidth==0.2.5
# via pytest
webencodings==0.5.1
# via
# -r requirements.txt
# bleach
werkzeug==1.0.1
# via
# -r requirements.txt
# flask
wtforms==2.3.3
# via
# -r requirements.txt
# flask-wtf
xlrd==1.2.0
# via
# -r requirements.txt
# pyexcel-xls
xlwt==1.3.0
# via
# -r requirements.txt
# pyexcel-xls
zipp==3.4.0
# via importlib-metadata
# The following packages are considered to be unsafe in a requirements file:
# setuptools

49
tests/app/notify_client/test_service_api_client.py
View File

@@ -555,3 +555,52 @@ def test_client_deletes_service_template_cache_when_service_is_updated(
assert len(mock_redis_delete.call_args_list) == 1
assert mock_redis_delete.call_args_list[0] == call(f'service-{SERVICE_ONE_ID}')
assert mock_redis_delete_by_pattern.call_args_list[0] == call(f'service-{SERVICE_ONE_ID}-template-*')
def test_client_updates_service_with_allowed_attributes(
mocker,
):
client = ServiceAPIClient()
mock_post = mocker.patch.object(client, 'post', return_value={'data': {'id': None}})
mocker.patch('app.notify_client.current_user', id='123')
allowed_attributes = [
'active',
'consent_to_research',
'contact_link',
'count_as_live',
'email_branding',
'email_from',
'free_sms_fragment_limit',
'go_live_at',
'go_live_user',
'letter_branding',
'letter_contact_block',
'message_limit',
'name',
'notes',
'organisation_type',
'permissions',
'prefix_sms',
'rate_limit',
'reply_to_email_address',
'research_mode',
'restricted',
'sms_sender',
'volume_email',
'volume_letter',
'volume_sms',
]
attrs_dict = {}
for attr in allowed_attributes:
attrs_dict[attr] = "value"
client.update_service(
SERVICE_ONE_ID,
**attrs_dict
)
mock_post.assert_called_once_with(
f'/service/{SERVICE_ONE_ID}',
{**{'created_by': '123'}, **attrs_dict}
)