Commit Graph

7862 Commits

Author SHA1 Message Date
Pea Tyczynska
3251fc4e00 Change content for email reply-to verification journey
Earlier commits used placeholder content while awaiting official
content.
2019-05-23 15:34:24 +01:00
Pea Tyczynska
441c1f441b Verify email address when editing reply-to address
Also fix the tests
2019-05-23 15:34:24 +01:00
Pea Tyczynska
431d2162c0 Fail reply-to email verification if no delivery within 5 minutes 2019-05-23 15:34:24 +01:00
Pea Tyczynska
ea314ad75f Deal with duplicate reply-to email addresses 2019-05-23 15:34:24 +01:00
Pea Tyczynska
8f3b560a4e Use ajax to auto-refresh reply-to email verifiaction page 2019-05-23 15:34:24 +01:00
Pea Tyczynska
9d2b60b56b Show try again link when email verification fails 2019-05-23 15:34:24 +01:00
Pea Tyczynska
ed599f0c03 Save new reply-to email if test notification delivered
Also check if it should be a default reply-to email address
2019-05-23 15:34:24 +01:00
Pea Tyczynska
45ac0d7812 Waiting page shows correct messages 2019-05-23 15:34:23 +01:00
Pea Tyczynska
d70afddf51 Send request to api to check if reply-to address is working 2019-05-23 15:34:23 +01:00
Chris Hill-Scott
238c56faec Merge pull request #2984 from alphagov/fix-double-heading-letter-branding
Fix duplicated H1 on ‘New letter branding’ page
2019-05-23 10:36:08 +01:00
Chris Hill-Scott
741114a9fd Merge pull request #2986 from alphagov/fidejoseph-patch-1
Update email_domains.yml
2019-05-22 16:07:32 +01:00
fidejoseph
efbb700cc2 Update email_domains.yml
Adding suttonmail.org (domain provided by London Grid for Learning) - a network of state-funded schools in Sutton
2019-05-22 15:54:47 +01:00
Chris Hill-Scott
9d1a7904a8 Fix duplicated H1 on ‘New letter branding’ page
For accessibility reasons a page should have one (and only one) H1. This
commit fixes an instance where the H1 was duplicated as a result of the
work done to componentize our page headings.

It also adds an extra check to `client_request` so that we don’t
introduce pages with multiple or no H1s in the future.
2019-05-21 16:09:00 +01:00
Chris Hill-Scott
0609229466 Merge pull request #2982 from alphagov/terse-org-set-text
Make ‘you must set organisation’ text shorter
2019-05-21 15:24:27 +01:00
Chris Hill-Scott
f0da3e877f Merge pull request #2981 from alphagov/new-new-button-manage-branding
Use new ‘add’ buttons on branding management pages
2019-05-21 15:24:20 +01:00
Chris Hill-Scott
0f43ed3f63 Merge pull request #2979 from alphagov/pyup-scheduled-update-2019-05-20
Scheduled weekly dependency update for week 20
2019-05-21 15:24:11 +01:00
Chris Hill-Scott
ee33f91621 Use new ‘add’ buttons on branding management pages
‘Add’ buttons are generally:
- at the bottom of the page
- sticky
- grey
2019-05-21 14:19:29 +01:00
Chris Hill-Scott
9d40986d53 Make ‘you must set organisation’ text shorter
So it fits in the column.
2019-05-20 16:15:47 +01:00
Chris Hill-Scott
431a966dee Freeze requirements 2019-05-20 16:08:00 +01:00
pyup-bot
4a7c0c8594 Update flask from 1.0.2 to 1.0.3 2019-05-20 14:55:06 +01:00
Chris Hill-Scott
b1df698cf7 Merge pull request #2978 from alphagov/wmca.org.uk
Adding wmca to allowed domains
2019-05-20 13:57:49 +01:00
Pete Herlihy
8abf8b85ca Adding wmca to allowed domains
West Midlands Combined Authority
2019-05-20 13:48:07 +01:00
Leo Hemsted
1b64388aee Merge pull request #2961 from alphagov/zdt-deploy
update manifest file to use zdt-push
2019-05-20 13:32:57 +01:00
Chris Hill-Scott
aca6f70c9e Merge pull request #2977 from alphagov/go-live-sla
Add a line about how long it takes to go live
2019-05-20 10:36:28 +01:00
Chris Hill-Scott
bd574e2aab Add a line about how long it takes to go live
We keep getting questions about this.
2019-05-20 09:59:00 +01:00
Leo Hemsted
813dc17388 Merge pull request #2976 from alphagov/healthcheck
use http healthcheck
2019-05-17 15:26:44 +01:00
Leo Hemsted
89c7a87af2 use http healthcheck
prevents traffic being routed to apps that haven't warmed up yet
2019-05-17 14:50:36 +01:00
Chris Hill-Scott
9dd1489d11 Merge pull request #2975 from alphagov/folder-summary-team-page
Folder summary team page
2019-05-17 14:30:20 +01:00
Chris Hill-Scott
5a0bba22ee Swap folder permissions and sign in method
This makes the order match what is shown on the individual team members
page.
2019-05-17 14:08:02 +01:00
Chris Hill-Scott
1f601cd807 Remove feature from from user model 2019-05-17 14:08:02 +01:00
Chris Hill-Scott
fd7a33d0a6 Remove folder permissions feature flag from team members 2019-05-17 14:08:01 +01:00
Tom Byers
a0ecbe473e Merge pull request #2957 from alphagov/add-js-tests-for-list-entry
Add JS tests for list entry module
2019-05-17 13:36:52 +01:00
Chris Hill-Scott
33b72d6abf Merge pull request #2889 from alphagov/enable-folder-permissions-globally
Remove edit_folder_permissions service setting (feature flag)
2019-05-17 12:49:03 +01:00
Alexey Bezhan
cab780b549 Remove edit_folder_permissions service setting (feature flag)
This removes the edit_folder_permission checks from the code, enabling
the folder permissions for all services.

This also fixes folder-related tests to set up appropriate user
permissions.

This should only be merged right after alphagov/notifications-api#2428,
when all other permission stories are done.
2019-05-17 11:20:16 +01:00
Chris Hill-Scott
c31dbd4de0 Merge pull request #2973 from alphagov/fidejoseph-patch-1
Update email_domains.yml
2019-05-17 11:18:26 +01:00
Chris Hill-Scott
2dc731c2d8 Merge pull request #2971 from alphagov/loading-indicator
Add a loading indicator component
2019-05-17 11:18:14 +01:00
Chris Hill-Scott
9cb6f05b88 Merge pull request #2895 from alphagov/dont-display-folder-permissions-form-for-platform-admin-users
Hide template folder permission editing for platform admin users
2019-05-17 11:18:09 +01:00
Chris Hill-Scott
81b299428f Add tests for editing folder permissions for platform admin users 2019-05-17 11:03:41 +01:00
Alexey Bezhan
5dbd229781 Hide template folder permission editing for platform admin users
Platform admin users can access all template folders, so the folder
permissions form always displays everything as checked for them,
which makes it look like the form isn't actually working. We could
do the check based on folder data, but the field still wouldn't
have any effect on permissions. So instead, we hide it completely
for platform admin users.

Submitting the form will remove any folder permissions from the DB
for the platform admin user (which can still be created by changing
permissions on the template folder 'Manage' page), but that's only
relevant if a user stops being a platform admin but keeps their
Notify services.
2019-05-17 10:46:56 +01:00
fidejoseph
6a0528f7c9 Update email_domains.yml
Adding "unifiedgov.co.uk" (Kingston/Sutton council_ and "tfwm.org.uk" (Transport for West Midlands)
2019-05-16 16:02:38 +01:00
Tom Byers
b9a2cc1ec5 Add tests for listEntry.js 2019-05-16 15:36:47 +01:00
Tom Byers
a6f39c08de Dedupe list-entry shared attributes
The `getSharedAttributes` method gathers all
attributes, and [DOM tokens](https://developer.mozilla.org/en-US/docs/Web/API/Element/classList)
in the `class` attribute not controlled by the
module for re-applying in the `render` method.

Because it gathered them for all items, many
duplicates ended up being added to new items.

Browser engines were tidying up the duplicates
but we shouldn't be adding them in the first
place.
2019-05-16 15:36:46 +01:00
Tom Byers
84b02ee57a Remove reference to global 'this' from listEntry
Also removes setting of the `$` variable to
jQuery.

This can mess up the unit tests if they run
against JSDOM, which doesn't set the global `this`
to `window`, as browsers do.

We don't set `$` in any other module scripts and
adding it to `this` without making explicit that
`this` means `window` isn't useful.
2019-05-16 15:36:46 +01:00
Tom Byers
293a7c544f Merge pull request #2972 from alphagov/un-revert-progressively-enhanced-folder-permissions
Add progressively enhanced folder permissions back
2019-05-16 11:45:39 +01:00
Katie Smith
5df3148610 Merge pull request #2954 from alphagov/support-welsh-characters
Allow Welsh characters in SMS templates
2019-05-15 16:34:02 +01:00
Chris Hill-Scott
61b056e490 Merge pull request #2964 from alphagov/different-back-link-from-job
Always go back to previous page from notification
2019-05-15 16:26:34 +01:00
Chris Hill-Scott
9c21541d2e Merge pull request #2955 from alphagov/auto-nhs-org-type
Set org type to NHS if user has NHS email address
2019-05-15 16:26:23 +01:00
Chris Hill-Scott
e6d03ec6f8 Check that users have to choose an org type
If we can’t guess a user’s organisation then they have to choose what
type of organisation they work for when they add a new service. This
commit adds a test to make sure they can’t just click the green button
and proceed without picking one.
2019-05-15 16:16:23 +01:00
Chris Hill-Scott
5b4edc92fd Add a loading indicator component
This will let us design a page which tells the user they need to wait.
2019-05-15 15:29:47 +01:00
Katie Smith
be71aec24f Update app/templates/views/pricing.html
Co-Authored-By: Chris Hill-Scott <me@quis.cc>
2019-05-15 14:30:34 +01:00