Merge pull request #2975 from alphagov/folder-summary-team-page

Folder summary team page

app/models/user.py

@@ -168,9 +168,6 @@ class User(UserMixin):
         """
         Returns list of template folders that a user can view for a given service
         """
-        if not service.has_permission('edit_folder_permissions'):
-            return service.all_template_folders
-
         return [
             template_folder
             for template_folder in service.all_template_folders

app/templates/views/manage-users.html

@@ -48,17 +48,8 @@
                 label
               ) }}
             {% endfor %}
-            {% if current_service.has_permission('email_auth') %}
-              <div class="tick-cross-list-hint">
-                {% if user.auth_type == 'sms_auth' %}
-                  Signs in with a text message code
-                {% else %}
-                  Signs in with an email link
-                {% endif %}
-              </div>
-            {% endif %}
             {# only show if the service has folders #}
-            {% if current_service.has_permission('edit_folder_permissions')  and current_service.all_template_folders %}
+            {% if current_service.all_template_folders %}
               <div class="tick-cross-list-hint">
                 {% set folder_count = user.template_folders_for_service(current_service) | length %}
 
@@ -71,6 +62,15 @@
                 {% endif%}
               </div>
             {% endif %}
+            {% if current_service.has_permission('email_auth') %}
+              <div class="tick-cross-list-hint">
+                {% if user.auth_type == 'sms_auth' %}
+                  Signs in with a text message code
+                {% else %}
+                  Signs in with an email link
+                {% endif %}
+              </div>
+            {% endif %}
           </div>
           {% if current_user.has_permissions('manage_service') %}
             <li class="tick-cross-list-edit-link">

tests/app/main/views/test_manage_users.py

@@ -124,6 +124,7 @@ def test_should_show_overview_page(
     client_request,
     mocker,
     mock_get_invites_for_service,
+    mock_get_template_folders,
     mock_has_no_jobs,
     fake_uuid,
     service_one,
@@ -157,6 +158,7 @@ def test_should_show_caseworker_on_overview_page(
     client_request,
     mocker,
     mock_get_invites_for_service,
+    mock_get_template_folders,
     fake_uuid,
     service_one,
 ):
@@ -276,6 +278,7 @@ def test_manage_users_page_shows_member_auth_type_if_service_has_email_auth_acti
     service_one,
     mock_get_users_by_service,
     mock_get_invites_for_service,
+    mock_get_template_folders,
     displays_auth_type
 ):
     if service_has_email_auth:
@@ -833,6 +836,7 @@ def test_manage_users_shows_invited_user(
     client_request,
     mocker,
     active_user_with_permissions,
+    mock_get_template_folders,
     sample_invite,
     invite_status,
     expected_text,
@@ -852,6 +856,7 @@ def test_manage_users_does_not_show_accepted_invite(
     mocker,
     active_user_with_permissions,
     sample_invite,
+    mock_get_template_folders,
 ):
     invited_user_id = uuid.uuid4()
     sample_invite['id'] = invited_user_id
@@ -897,6 +902,7 @@ def test_no_permission_manage_users_page(
     service_one,
     mock_get_users_by_service,
     mock_get_invites_for_service,
+    mock_get_template_folders,
     api_user_active,
     mocker,
 ):
@@ -997,6 +1003,7 @@ def test_can_invite_user_as_platform_admin(
     platform_admin_user,
     active_user_with_permissions,
     mock_get_invites_for_service,
+    mock_get_template_folders,
     mocker,
 ):
     mocker.patch('app.user_api_client.get_users_for_service', return_value=[active_user_with_permissions])