darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-25 19:50:49 -04:00
Code Issues Packages Projects Releases Wiki Activity
7,817 Commits 49 Branches 59 Tags
293a7c544fff9c74928cbb92bf6ae92e4284495d
Commit Graph

7817 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tom Byers
293a7c544f Merge pull request #2972 from alphagov/un-revert-progressively-enhanced-folder-permissions 
Add progressively enhanced folder permissions back
 2019-05-16 11:45:39 +01:00
Katie Smith
5df3148610 Merge pull request #2954 from alphagov/support-welsh-characters 
Allow Welsh characters in SMS templates
 2019-05-15 16:34:02 +01:00
Chris Hill-Scott
61b056e490 Merge pull request #2964 from alphagov/different-back-link-from-job 
Always go back to previous page from notification
 2019-05-15 16:26:34 +01:00
Chris Hill-Scott
9c21541d2e Merge pull request #2955 from alphagov/auto-nhs-org-type 
Set org type to NHS if user has NHS email address
 2019-05-15 16:26:23 +01:00
Chris Hill-Scott
e6d03ec6f8 Check that users have to choose an org type 
If we can’t guess a user’s organisation then they have to choose what
type of organisation they work for when they add a new service. This
commit adds a test to make sure they can’t just click the green button
and proceed without picking one.
 2019-05-15 16:16:23 +01:00
Katie Smith
be71aec24f Update app/templates/views/pricing.html 
Co-Authored-By: Chris Hill-Scott <me@quis.cc>
 2019-05-15 14:30:34 +01:00
Tom Byers
ccd09b9fd7 Revert "Merge pull request #2969 from alphagov/revert-2956-progressively-enhance-folder-permissions" 
This reverts commit 8266f3d65c, reversing
changes made to b2a38fe222.
 2019-05-15 14:26:51 +01:00
Katie Smith
5be6b41195 Allow Welsh characters in SMS 
- This brings in the latest version of notifications-utils which
allows Welsh characters in SMS templates.
- Updated the pricing page to show the new prices for SMS with certain
Welsh characters
 2019-05-15 14:20:49 +01:00
Katie Smith
00e7ccadad Merge pull request #2968 from alphagov/require-approval-on-go-live 
Allow custom notes when service goes live
 2019-05-15 10:51:31 +01:00
Chris Hill-Scott
4fc7498415 Include status when linking to notifications page 
Without this argument the 'sending' filter doesn’t get highlighted by
default.
 2019-05-15 10:04:43 +01:00
Katie Smith
da971b2da7 Allow custom notes when service goes live 
This adds an option on the organisation settings page to add
'request_to_go_live_notes'. When a service belonging to this
organisation requests to go live, any go live notes for the
organisation will be added to the Zendesk ticket in the 'Agreement
signed' section.
 2019-05-14 14:24:26 +01:00
Chris Hill-Scott
e4b1759b3b Merge pull request #2965 from alphagov/no-copy-paste-in-zendesk 
Remove redundant info from go live emails
 2019-05-14 11:43:19 +01:00
Chris Hill-Scott
d01ed30da0 Keep email address in go live ticket 
It’s useful because it’s not easy to see in the Zendesk UI.
 2019-05-14 11:17:47 +01:00
Tom Byers
8266f3d65c Merge pull request #2969 from alphagov/revert-2956-progressively-enhance-folder-permissions 
Revert "Progressively enhance folder permissions"
 2019-05-13 16:38:14 +01:00
Tom Byers
0e6caa7fda Revert "Progressively enhance folder permissions" 2019-05-13 16:19:24 +01:00
Tom Byers
b2a38fe222 Merge pull request #2956 from alphagov/progressively-enhance-folder-permissions 
Progressively enhance folder permissions
 2019-05-13 14:41:43 +01:00
Tom Byers
6f12a39b58 Move folder-black.png image into correct folder 
Was placed in app/assets/stylesheets/ by mistake
in fe457464a8
 2019-05-13 14:08:07 +01:00
Pea (Malgorzata Tyczynska)
828579ce05 Merge pull request #2958 from alphagov/precompiled_for_everyone 
Remove precompiled letters permission: precompiled for everyone
 2019-05-13 14:03:14 +01:00
Chris Hill-Scott
2b63b005ef Merge pull request #2967 from alphagov/fix-linking-notification-status 
Only link to message status if message has failed
 2019-05-13 13:55:37 +01:00
Chris Hill-Scott
61d9371134 Merge pull request #2966 from alphagov/folder-name-textbox-width 
Make folder name textbox full width
 2019-05-13 13:55:31 +01:00
Chris Hill-Scott
2737a8e438 Merge pull request #2938 from alphagov/schedule-buttons 
Style radio select component controls as buttons not links
 2019-05-13 13:55:22 +01:00
Chris Hill-Scott
3c6598cbc2 Only link to message status if message has failed 
This retores the behaviour to as it was before
https://github.com/alphagov/notifications-admin/pull/2962
which inadvertently started linking to the guidance for messages that
were delivered or in sending.
 2019-05-13 13:29:47 +01:00
Tom Byers
cd5f6251d1 Adjust selection summary spacing 
Co-Authored-By: Chris Hill-Scott <me@quis.cc>
 2019-05-13 13:15:45 +01:00
Tom Byers
bbc962298c Make selection summary use tabular numbers 
Stops them jumping around as much when the numbers change. As requested in: https://github.com/alphagov/notifications-admin/pull/2956/files#r283271635

Co-Authored-By: Chris Hill-Scott <me@quis.cc>
 2019-05-13 13:07:28 +01:00
Chris Hill-Scott
e8c1a7deea Make folder name textbox full width 
Folder names can be quite long. It’s annoying if they get cut off.
 2019-05-13 11:04:50 +01:00
Tom Byers
fe457464a8 Fixes for folder .svg icon 
Match format of .svg file to others in the same
folder to fix issues in IE11.

Add a .png alternative for IE8 users.
 2019-05-10 14:59:31 +01:00
Tom Byers
d75c26eb83 Make done button, and its surround, sticky 2019-05-10 14:21:58 +01:00
Tom Byers
19b68048d0 Fix undefined local variables in sticky JS 
Running the sticky JS in Jest raised errors due to
these variables not being assigned properly.

It's JavaScript so any variable not defined by the
`var` prefix will automatically become a property
of the global object. That is not what is intended
by the code so requires changing.
 2019-05-10 14:20:44 +01:00
Tom Byers
bb16626209 Split module out into objects for each component 
Is clearer than just having one large hierarchical
object and makes the relationships between the
module and its components clearer.
 2019-05-10 14:20:14 +01:00
Tom Byers
7328649537 Combine 'Change' and 'Done' buttons into one 
Includes addition of classes by JS to ensure CSS
selectors don't have to reference the data
attributes.
 2019-05-10 14:16:03 +01:00
Chris Hill-Scott
507b5b9933 Remove line about checklist from go live email 
It’s impossible for people to go live without technically completing the
checklist now.
 2019-05-10 10:46:15 +01:00
Katie Smith
1d7ce85443 Merge pull request #2962 from alphagov/update-links 
Fix broken links
 2019-05-10 10:35:19 +01:00
Katie Smith
f3f8f4085f Fix broken links 
There were still a few links pointing to `/features/using-notify`
 2019-05-10 09:05:07 +01:00
Chris Hill-Scott
d6b6f1689f Remove copy-pasteable version of go live info 
We’ve automated this now so we don’t need it in a format that’s easy to
copy and paste into a spreadsheet.
 2019-05-09 17:41:27 +01:00
Chris Hill-Scott
b4894e7a03 Always go back to previous page from notification 
When looking at a notification you can either be coming from the page
of all notifications, or from a job. Currently the back link always
takes you to the page of all notifications.

This commit makes it a bit more sophisticated so if you’ve come from
looking at a job, you go back to the job.
 2019-05-09 17:33:22 +01:00
Chris Hill-Scott
b786997c6b Merge pull request #2963 from alphagov/fix-missing-save-button-callbacks 
Fix missing save button on callbacks page
 2019-05-09 16:53:02 +01:00
Chris Hill-Scott
4673113451 Fix missing save button on callbacks page 
😳

74fb30ce5f (diff-d32e9daf34b835cda7c3b407e14a8feeL31)
 2019-05-09 16:44:34 +01:00
Pea (Malgorzata Tyczynska)
3e0ca91912 Merge pull request #2960 from alphagov/update_utils_version 
Update utils version to fix duplicate columns in csv upload bug
 2019-05-09 15:14:39 +01:00
Pea Tyczynska
a99a08ebf2 Update utils version to fix duplicate columns in csv upload bug 
When one of our users uploaded a csv with two phone number columns
and missing data for one of those duplicate columns, our app
crashed. We fixed the code in utils that was crashing now and
we are propagating this change to our service through updating
utils version in this commit.
 2019-05-09 14:54:38 +01:00
Chris Hill-Scott
923ac7190c Add a hint when no team members are selected 
This helps clarify that you will still be able to see the folder.
Follows the phrasing used for the "No folders…" message.
 2019-05-09 13:43:04 +01:00
Tom Byers
1ffa8c8915 Only show the folder icon if fields are folders 2019-05-09 11:25:28 +01:00
Chris Hill-Scott
78699ac995 Merge pull request #2953 from alphagov/numbers-in-excel-reports 
Don’t convert Excel reports to CSV before output
 2019-05-09 11:18:07 +01:00
Pea Tyczynska
18b545af51 Remove precompiled letters permission as everyone can send precompiled now 2019-05-09 11:01:11 +01:00
Chris Hill-Scott
3dc2130926 Align baseline of summary text with button text 2019-05-09 10:30:46 +01:00
Chris Hill-Scott
89478ac2ca Use larger folder icon 2019-05-09 10:27:14 +01:00
Chris Hill-Scott
f274759cd8 Add larger version of black folder icon 
This is for use in the folder permissions UI. It’s designed to be sized
at the same width as a GOV.UK style checkbox. The CSS to render it is
something like:

```css
background-image: file-url('folder-black.svg');
background-repeat: no-repeat;
background-size: 39px auto;
background-position: 0px 4px;
```
 2019-05-09 10:21:30 +01:00
Tom Byers
db12ec3a5c Make buttons work outside of context 
This is important for users who find buttons via
interfaces that present them out of the context of
the page, like screenreaders.
 2019-05-08 17:16:08 +01:00
Tom Byers
42a9a0cf23 Make selection summary a live region 
Live regions need to be in the original HTML of
the page to work. We were generating the summary
in JS.

This changes the JS to only generate the contents
of the summary so changes to its contents are
announces by the existing live-region.
 2019-05-08 17:16:06 +01:00
Tom Byers
089ebf2c7a Add tests for collapsible checkboxes 2019-05-08 17:08:20 +01:00
Tom Byers
90ad8b4ed0 Add helpers for JS tests 
To help with asserting some things which were
repeated in the tests.
 2019-05-08 17:08:20 +01:00