darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-20 00:29:29 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add permanent-failure to the format_notification_status formatter so the status appears on the activity page.

Browse Source
This commit is contained in:
Rebecca Law
2021-06-15 13:08:07 +01:00
parent aedf875110
commit d7364eb21a
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/formatters.py
View File

@@ -220,7 +220,7 @@ def format_notification_status(status, template_type):
'failed': '',
'technical-failure': 'Technical failure',
'temporary-failure': '',
'permanent-failure': '',
'permanent-failure': 'Permanent failure',
'delivered': '',
'received': '',
'accepted': '',

2
tests/app/main/views/test_activity.py
View File

@@ -741,7 +741,7 @@ def test_big_numbers_dont_show_for_letters(
('letter', 'received', '27 September at 5:30pm', True),
('letter', 'accepted', '27 September at 5:30pm', True),
('letter', 'cancelled', '27 September at 5:30pm', False), # The API won’t return cancelled letters
('letter', 'permanent-failure', '27 September at 5:31pm', False), # Deprecated for ‘cancelled’
('letter', 'permanent-failure', 'Permanent failure 27 September at 5:31pm', False),
('letter', 'temporary-failure', '27 September at 5:30pm', False), # Not currently a real letter status
('letter', 'virus-scan-failed', 'Virus detected 27 September at 5:30pm', False),
('letter', 'validation-failed', 'Validation failed 27 September at 5:30pm', False),