From d7364eb21a858669fccedfd8362c8f3d57639d77 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Tue, 15 Jun 2021 13:08:07 +0100 Subject: [PATCH] Add permanent-failure to the `format_notification_status` formatter so the status appears on the activity page. --- app/formatters.py | 2 +- tests/app/main/views/test_activity.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/formatters.py b/app/formatters.py index 91ecdbb5c..de413e7ac 100644 --- a/app/formatters.py +++ b/app/formatters.py @@ -220,7 +220,7 @@ def format_notification_status(status, template_type): 'failed': '', 'technical-failure': 'Technical failure', 'temporary-failure': '', - 'permanent-failure': '', + 'permanent-failure': 'Permanent failure', 'delivered': '', 'received': '', 'accepted': '', diff --git a/tests/app/main/views/test_activity.py b/tests/app/main/views/test_activity.py index 1b793f771..b44741051 100644 --- a/tests/app/main/views/test_activity.py +++ b/tests/app/main/views/test_activity.py @@ -741,7 +741,7 @@ def test_big_numbers_dont_show_for_letters( ('letter', 'received', '27 September at 5:30pm', True), ('letter', 'accepted', '27 September at 5:30pm', True), ('letter', 'cancelled', '27 September at 5:30pm', False), # The API won’t return cancelled letters - ('letter', 'permanent-failure', '27 September at 5:31pm', False), # Deprecated for ‘cancelled’ + ('letter', 'permanent-failure', 'Permanent failure 27 September at 5:31pm', False), ('letter', 'temporary-failure', '27 September at 5:30pm', False), # Not currently a real letter status ('letter', 'virus-scan-failed', 'Virus detected 27 September at 5:30pm', False), ('letter', 'validation-failed', 'Validation failed 27 September at 5:30pm', False),