darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-23 20:01:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

Nest child lists inside list items

Browse Source 
It's not valid HTML for <ol> or <ul> tags to have
<ol> or <ul>'s as direct children.

See:
https://www.w3.org/TR/html52/grouping-content.html#the-ol-element
https://www.w3.org/TR/html52/grouping-content.html#the-ul-element
This commit is contained in:
Tom Byers
2020-11-17 21:36:40 +00:00
parent ad3ff9e539
commit cd0b900c2f
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/templates/components/sub-navigation.html
View File

@@ -7,22 +7,32 @@
<a class="govuk-link govuk-link--no-visited-state" href="{{ url_for(item['link']) }}" itemprop="item">
<span itemprop="name">{{item['name']}}</span>
</a>
{% if caller %}
{{ caller() }}
{% endif %}
</li>
{% endmacro %}
{% macro sub_navigation_item_sub_navigation(item) %}
<ol itemscope itemtype="http://schema.org/ItemList">
{% for sub_item in item.sub_navigation_items %}
{{ sub_navigation_item(sub_item) }}
{% endfor %}
</ol>
{% endmacro %}
{% macro sub_navigation(
item_set
) %}
<nav class="sub-navigation">
<ol itemscope itemtype="http://schema.org/ItemList">
{% for item in item_set %}
{{ sub_navigation_item(item) }}
{% if item.sub_navigation_items %}
<ol itemscope itemtype="http://schema.org/ItemList">
{% for sub_item in item.sub_navigation_items %}
{{ sub_navigation_item(sub_item) }}
{% endfor %}
</ol>
{% call sub_navigation_item(item) %}
{{ sub_navigation_item_sub_navigation(item) }}
{% endcall %}
{% else %}
{{ sub_navigation_item(item) }}
{% endif %}
{% endfor %}
</ol>