From cd0b900c2fdb02a467df70280f731ead36cc3328 Mon Sep 17 00:00:00 2001
From: Tom Byers <tombaromba@gmail.com>
Date: Tue, 17 Nov 2020 21:36:40 +0000
Subject: [PATCH] Nest child lists inside list items

It's not valid HTML for <ol> or <ul> tags to have
<ol> or <ul>'s as direct children.

See:
https://www.w3.org/TR/html52/grouping-content.html#the-ol-element
https://www.w3.org/TR/html52/grouping-content.html#the-ul-element
---
 app/templates/components/sub-navigation.html | 22 ++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/app/templates/components/sub-navigation.html b/app/templates/components/sub-navigation.html
index f2148a1a0..7099ecd45 100644
--- a/app/templates/components/sub-navigation.html
+++ b/app/templates/components/sub-navigation.html
@@ -7,22 +7,32 @@
     <a class="govuk-link govuk-link--no-visited-state" href="{{ url_for(item['link']) }}" itemprop="item">
       <span itemprop="name">{{item['name']}}</span>
     </a>
+    {% if caller %}
+      {{ caller() }}
+    {% endif %}
   </li>
 {% endmacro %}
 
+{% macro sub_navigation_item_sub_navigation(item) %}
+  <ol itemscope itemtype="http://schema.org/ItemList">
+    {% for sub_item in item.sub_navigation_items %}
+      {{ sub_navigation_item(sub_item) }}
+    {% endfor %}
+  </ol>
+{% endmacro %}
+
 {% macro sub_navigation(
   item_set
 ) %}
   <nav class="sub-navigation">
     <ol itemscope itemtype="http://schema.org/ItemList">
       {% for item in item_set %}
-        {{ sub_navigation_item(item) }}
         {% if item.sub_navigation_items %}
-          <ol itemscope itemtype="http://schema.org/ItemList">
-            {% for sub_item in item.sub_navigation_items %}
-              {{ sub_navigation_item(sub_item) }}
-            {% endfor %}
-          </ol>
+          {% call sub_navigation_item(item) %}
+            {{ sub_navigation_item_sub_navigation(item) }}
+          {% endcall %}
+        {% else %}
+          {{ sub_navigation_item(item) }}
         {% endif %}
       {% endfor %}
     </ol>