darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-19 14:03:52 -04:00
Code Issues Packages Projects Releases Wiki Activity

clean up Makefile and checks.yml

Browse Source
This commit is contained in:
Kenneth Kehl
2024-09-10 07:17:41 -07:00
parent b8edfa8175
commit bdf4c9597b
2 changed files with 1 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
.github/workflows/checks.yml vendored
View File

@@ -89,31 +89,6 @@ jobs:
- uses: ./.github/actions/setup-project
- uses: jwalton/gh-find-current-pr@v1
id: findPr
#- name: Clone API
# uses: actions/checkout@v4
# with:
# repository: GSA/notifications-api
# path: 'notifications-api'
# - name: Install API dependencies
# working-directory: 'notifications-api'
# run: make bootstrap
# env:
# DATABASE_URL: postgresql://user:password@localhost:5432/test_notification_api
# SQLALCHEMY_DATABASE_TEST_URI: postgresql://user:password@localhost:5432/test_notification_api
# REDIS_URL: redis://localhost:6379
# NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
# NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}
# NOTIFY_ENVIRONMENT: development
#- name: Run API server
# working-directory: 'notifications-api'
# run: make run-procfile &
# env:
# DATABASE_URL: postgresql://user:password@localhost:5432/test_notification_api
# SQLALCHEMY_DATABASE_TEST_URI: postgresql://user:password@localhost:5432/test_notification_api
# REDIS_URL: redis://localhost:6379
# NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
# NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}
# NOTIFY_ENVIRONMENT: development
- name: Check API Server availability
run: |
curl --fail -v https://notify-api-staging.app.cloud.gov || exit 1

2
Makefile
View File

@@ -88,7 +88,7 @@ dead-code: ## 60% is our aspirational goal, but currently breaks the build
.PHONY: e2e-test
e2e-test: export NEW_RELIC_ENVIRONMENT=test
e2e-test: ## Run end-to-end integration tests; note that --browser webkit isn't currently working
DEBUG=pw:api,pw:browser poetry run pytest -vv --browser chromium tests/end_to_end
DEBUG=pw:api,pw:browser poetry run pytest -vv --browser chromium --browser firefox tests/end_to_end
.PHONY: js-lint
js-lint: ## Run javascript linting scanners