From bdf4c9597be7a07756f39d51dcab0e7ce946131f Mon Sep 17 00:00:00 2001
From: Kenneth Kehl <@kkehl@flexion.us>
Date: Tue, 10 Sep 2024 07:17:41 -0700
Subject: [PATCH] clean up Makefile and checks.yml

---
 .github/workflows/checks.yml | 25 -------------------------
 Makefile                     |  2 +-
 2 files changed, 1 insertion(+), 26 deletions(-)

diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
index 1923ff377..515f2c420 100644
--- a/.github/workflows/checks.yml
+++ b/.github/workflows/checks.yml
@@ -89,31 +89,6 @@ jobs:
       - uses: ./.github/actions/setup-project
       - uses: jwalton/gh-find-current-pr@v1
         id: findPr
-      #- name: Clone API
-      #  uses: actions/checkout@v4
-      #  with:
-      #   repository: GSA/notifications-api
-      #   path: 'notifications-api'
-      # - name: Install API dependencies
-      #  working-directory: 'notifications-api'
-      #  run: make bootstrap
-      #  env:
-      #    DATABASE_URL: postgresql://user:password@localhost:5432/test_notification_api
-      #    SQLALCHEMY_DATABASE_TEST_URI: postgresql://user:password@localhost:5432/test_notification_api
-      #    REDIS_URL: redis://localhost:6379
-      #    NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
-      #    NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}
-      #    NOTIFY_ENVIRONMENT: development
-      #- name: Run API server
-        # working-directory: 'notifications-api'
-        # run: make run-procfile &
-        # env:
-          # DATABASE_URL: postgresql://user:password@localhost:5432/test_notification_api
-          # SQLALCHEMY_DATABASE_TEST_URI: postgresql://user:password@localhost:5432/test_notification_api
-          # REDIS_URL: redis://localhost:6379
-          # NOTIFY_E2E_TEST_EMAIL: ${{ secrets.NOTIFY_E2E_TEST_EMAIL }}
-          # NOTIFY_E2E_TEST_PASSWORD: ${{ secrets.NOTIFY_E2E_TEST_PASSWORD }}
-          # NOTIFY_ENVIRONMENT: development
       - name: Check API Server availability
         run: |
           curl --fail -v https://notify-api-staging.app.cloud.gov || exit 1
diff --git a/Makefile b/Makefile
index d7161d453..ed9baf394 100644
--- a/Makefile
+++ b/Makefile
@@ -88,7 +88,7 @@ dead-code: ## 60% is our aspirational goal, but currently breaks the build
 .PHONY: e2e-test
 e2e-test: export NEW_RELIC_ENVIRONMENT=test
 e2e-test: ## Run end-to-end integration tests; note that --browser webkit isn't currently working
-	DEBUG=pw:api,pw:browser poetry run pytest -vv --browser chromium  tests/end_to_end
+	DEBUG=pw:api,pw:browser poetry run pytest -vv --browser chromium  --browser firefox tests/end_to_end
 
 .PHONY: js-lint
 js-lint: ## Run javascript linting scanners