Merge pull request #1874 from alphagov/add-min-validation-for-sms-sender

Added a validation for a minimum of 3 character.

app/main/forms.py

@@ -561,6 +561,7 @@ class ServiceSmsSenderForm(StripWhitespaceForm):
         validators=[
             DataRequired(message="Can’t be empty"),
             Length(max=11, message="Enter 11 characters or fewer"),
+            Length(min=3, message="Enter 3 characters or more"),
             LettersNumbersAndFullStopsOnly(),
         ]
     )

tests/app/main/test_validators.py

@@ -206,3 +206,11 @@ def test_sms_sender_form_validation(
     form.sms_sender.data = '###########'
     form.validate()
     assert 'Use letters and numbers only' == form.errors['sms_sender'][0]
+
+    form.sms_sender.data = '0'
+    form.validate()
+    assert 'Enter 3 characters or more' == form.errors['sms_sender'][0]
+
+    form.sms_sender.data = '000'
+    form.validate()
+    assert not form.errors