From 6bd99e0599d195130dcd699d5da7fb417c3f95e1 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Thu, 15 Feb 2018 16:06:44 +0000 Subject: [PATCH 1/2] Added a validation for a minimum of 3 character. If the SMS sender is less than 3 characters one of our providers will return an error. --- app/main/forms.py | 1 + tests/app/main/test_validators.py | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/app/main/forms.py b/app/main/forms.py index 8023f40bf..442809940 100644 --- a/app/main/forms.py +++ b/app/main/forms.py @@ -561,6 +561,7 @@ class ServiceSmsSenderForm(StripWhitespaceForm): validators=[ DataRequired(message="Can’t be empty"), Length(max=11, message="Enter 11 characters or fewer"), + Length(min=3, message="Enter 3 characters or more"), LettersNumbersAndFullStopsOnly(), ] ) diff --git a/tests/app/main/test_validators.py b/tests/app/main/test_validators.py index e3e222686..91a7c5fa5 100644 --- a/tests/app/main/test_validators.py +++ b/tests/app/main/test_validators.py @@ -206,3 +206,7 @@ def test_sms_sender_form_validation( form.sms_sender.data = '###########' form.validate() assert 'Use letters and numbers only' == form.errors['sms_sender'][0] + + form.sms_sender.data = '0' + form.validate() + assert 'Enter 3 characters or more' == form.errors['sms_sender'][0] From 2b739535d495688f90c05a5ee11ae0511f6af987 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Thu, 15 Feb 2018 16:39:42 +0000 Subject: [PATCH 2/2] Added an edge case test --- tests/app/main/test_validators.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/app/main/test_validators.py b/tests/app/main/test_validators.py index 91a7c5fa5..88673ee04 100644 --- a/tests/app/main/test_validators.py +++ b/tests/app/main/test_validators.py @@ -210,3 +210,7 @@ def test_sms_sender_form_validation( form.sms_sender.data = '0' form.validate() assert 'Enter 3 characters or more' == form.errors['sms_sender'][0] + + form.sms_sender.data = '000' + form.validate() + assert not form.errors