Make analytics send the same title for all pages

Sets it on the tracker which means this value gets
sent for each:
- pageview
- event

See: https://developers.google.com/analytics/devguides/collection/analyticsjs/pages

We can only test that this has been set on the
tracker, not how that effects what is sent to GA,
in the JS tests.

This change has been tested in-browser with the
Chrome Analytics Debugger. This revealed the
contents of what is in the beacon sent to GA and
allowed confirmation the title was being set
correctly.

See: https://chrome.google.com/webstore/detail/google-analytics-debugger/jnkmfdileelhofjcijamephohjechhna/related
This commit is contained in:
Tom Byers
2020-02-20 11:03:03 +00:00
parent 5ba5ee2502
commit 8a98c73b08
4 changed files with 7 additions and 5 deletions

View File

@@ -15,6 +15,7 @@
window.ga('set', 'anonymizeIp', config.anonymizeIp);
window.ga('set', 'allowAdFeatures', config.allowAdFeatures);
window.ga('set', 'transport', config.transport);
window.ga('set', 'title', 'GOV.UK Notify');
};

View File

@@ -52,6 +52,7 @@ describe("Analytics", () => {
expect(setUpArguments[1]).toEqual(['set', 'anonymizeIp', true]);
expect(setUpArguments[2]).toEqual(['set', 'allowAdFeatures', false]);
expect(setUpArguments[3]).toEqual(['set', 'transport', 'beacon']);
expect(setUpArguments[4]).toEqual(['set', 'title', 'GOV.UK Notify']);
});

View File

@@ -111,10 +111,10 @@ describe("Analytics init", () => {
test("A pageview will be registered", () => {
expect(window.ga.mock.calls.length).toEqual(5);
expect(window.ga.mock.calls.length).toEqual(6);
// The first 4 calls configure the analytics tracker. All subsequent calls send data
expect(window.ga.mock.calls[4]).toEqual(['send', 'pageview', '/privacy']);
// The first 5 calls configure the analytics tracker. All subsequent calls send data
expect(window.ga.mock.calls[5]).toEqual(['send', 'pageview', '/privacy']);
});

View File

@@ -231,8 +231,8 @@ describe("Cookie settings", () => {
expect(window.GOVUK.initAnalytics).toHaveBeenCalled();
expect(window.ga).toHaveBeenCalled();
// the first 4 calls are configuration
expect(window.ga.mock.calls[4]).toEqual(['send', 'pageview', '/privacy']);
// the first 5 calls are configuration
expect(window.ga.mock.calls[5]).toEqual(['send', 'pageview', '/privacy']);
});