darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 13:29:48 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3315 from alphagov/send-generic-title-to-google-analytics

Browse Source 
Make analytics send the same title for all pages
This commit is contained in:
Tom Byers
2020-02-20 13:09:39 +00:00
committed by GitHub
parent 5ba5ee2502 8a98c73b08
commit 7ed5c46f82
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/analytics/analytics.js
View File

@@ -15,6 +15,7 @@
window.ga('set', 'anonymizeIp', config.anonymizeIp); window.ga('set', 'anonymizeIp', config.anonymizeIp);
window.ga('set', 'allowAdFeatures', config.allowAdFeatures); window.ga('set', 'allowAdFeatures', config.allowAdFeatures);
window.ga('set', 'transport', config.transport); window.ga('set', 'transport', config.transport);
window.ga('set', 'title', 'GOV.UK Notify');
}; };

1
tests/javascripts/analytics/analytics.test.js
View File

@@ -52,6 +52,7 @@ describe("Analytics", () => {
expect(setUpArguments[1]).toEqual(['set', 'anonymizeIp', true]); expect(setUpArguments[1]).toEqual(['set', 'anonymizeIp', true]);
expect(setUpArguments[2]).toEqual(['set', 'allowAdFeatures', false]); expect(setUpArguments[2]).toEqual(['set', 'allowAdFeatures', false]);
expect(setUpArguments[3]).toEqual(['set', 'transport', 'beacon']); expect(setUpArguments[3]).toEqual(['set', 'transport', 'beacon']);
expect(setUpArguments[4]).toEqual(['set', 'title', 'GOV.UK Notify']);
}); });

6
tests/javascripts/analytics/init.test.js
View File

@@ -111,10 +111,10 @@ describe("Analytics init", () => {
test("A pageview will be registered", () => { test("A pageview will be registered", () => {
expect(window.ga.mock.calls.length).toEqual(5); expect(window.ga.mock.calls.length).toEqual(6);
// The first 4 calls configure the analytics tracker. All subsequent calls send data // The first 5 calls configure the analytics tracker. All subsequent calls send data
expect(window.ga.mock.calls[4]).toEqual(['send', 'pageview', '/privacy']); expect(window.ga.mock.calls[5]).toEqual(['send', 'pageview', '/privacy']);
}); });

4
tests/javascripts/cookieSettings.test.js
View File

@@ -231,8 +231,8 @@ describe("Cookie settings", () => {
expect(window.GOVUK.initAnalytics).toHaveBeenCalled(); expect(window.GOVUK.initAnalytics).toHaveBeenCalled();
expect(window.ga).toHaveBeenCalled(); expect(window.ga).toHaveBeenCalled();
// the first 4 calls are configuration // the first 5 calls are configuration
expect(window.ga.mock.calls[4]).toEqual(['send', 'pageview', '/privacy']); expect(window.ga.mock.calls[5]).toEqual(['send', 'pageview', '/privacy']);
}); });