darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 17:38:50 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant hidden H3s

Browse Source 
This commit replaces the H3s which only repeated information with some
hidden text that will make it read nicer for screenreaders.
This commit is contained in:
Chris Hill-Scott
2021-03-12 17:12:47 +00:00
parent f7989b84cb
commit 7583c8d9fa
4 changed files with 8 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/templates/views/performance.html
View File

@@ -21,7 +21,6 @@
<div class="govuk-grid-row">
<div class="govuk-grid-column-one-half">
<h3 class="govuk-visually-hidden">Total messages</h3>
<div class="product-page-big-number">{{ total_notifications|format_billions }}</div>
total
</div>
@@ -88,7 +87,6 @@
</h2>
<div class="govuk-grid-row">
<div class="govuk-grid-column-one-half">
<h3 class="govuk-visually-hidden">Average</h3>
{{ big_number(
'{:.1f}%'.format(average_percentage_under_10_seconds),
label='on average',
@@ -122,14 +120,15 @@
</h2>
<div class="govuk-grid-row bottom-gutter">
<div class="govuk-grid-column-one-half">
<h3 class="govuk-visually-hidden">Organisations</h3>
<span class="govuk-visually-hidden">There are</span>
<div class="product-page-big-number">{{ count_of_live_services_and_organisations.organisations|format_thousands }}</div>
organisations
</div>
<div class="govuk-grid-column-one-half">
<h3 class="govuk-visually-hidden">Services</h3>
<span class="govuk-visually-hidden">and</span>
<div class="product-page-big-number">{{ count_of_live_services_and_organisations.services|format_thousands }}</div>
services
<span class="govuk-visually-hidden">using Notify.</span>
</div>
</div>
<div class="dashboard-table">

5
app/templates/views/signedout.html
View File

@@ -123,14 +123,15 @@
<h2>Who’s using GOV.UK Notify</h2>
<div class="govuk-grid-row bottom-gutter">
<div class="govuk-grid-column-one-half">
<h3 class="govuk-visually-hidden">Organisations</h3>
<span class="govuk-visually-hidden">There are</span>
<div class="product-page-big-number">{{ counts.organisations|format_thousands }}</div>
organisations
</div>
<div class="govuk-grid-column-one-half">
<h3 class="govuk-visually-hidden">Services</h3>
<span class="govuk-visually-hidden">and</span>
<div class="product-page-big-number">{{ counts.services|format_thousands }}</div>
services
<span class="govuk-visually-hidden">using Notify.</span>
</div>
</div>
<p class="govuk-body">

5
tests/app/main/views/test_index.py
View File

@@ -34,10 +34,7 @@ def test_non_logged_in_user_can_see_homepage(
assert normalize_spaces(page.select_one('#whos-using-notify').text) == (
'Who’s using GOV.UK Notify '
'Organisations '
'111 organisations '
'Services '
'9,999 services '
'There are 111 organisations and 9,999 services using Notify. '
'See the list of services and organisations.'
)
assert page.select_one('#whos-using-notify a')['href'] == url_for(

5
tests/app/main/views/test_performance.py
View File

@@ -116,7 +116,6 @@ def test_should_render_performance_page(
'Performance data '
''
'Messages sent since May 2016 '
'Total messages '
'1.8 billion total '
'1.1 billion emails '
'987.7 million text messages '
@@ -134,7 +133,6 @@ def test_should_render_performance_page(
'Only showing the last 7 days '
''
'Messages sent within 10 seconds '
'Average '
'96.8% on average '
'Messages sent within 10 seconds '
'Date Percentage '
@@ -148,8 +146,7 @@ def test_should_render_performance_page(
'Only showing the last 7 days '
''
'Organisations using Notify '
'Organisations 111 organisations '
'Services 9,999 services '
'There are 111 organisations and 9,999 services using Notify. '
'Organisations using Notify '
'Organisation Number of live services '
'Department of Examples and Patterns 2 '