darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-06 11:23:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

post to get user by email

Browse Source 
that way we won't store any PII in logs
This commit is contained in:
Leo Hemsted
2021-03-05 12:43:15 +00:00
parent a85e20ed3e
commit 4a624ace32
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/notify_client/user_api_client.py
View File

@@ -40,7 +40,7 @@ class UserApiClient(NotifyAdminAPIClient):
return self.get("/user/{}".format(user_id))
def get_user_by_email(self, email_address):
user_data = self.get('/user/email', params={'email': email_address})
user_data = self.post('/user/email', params={'email': email_address})
return user_data['data']
def get_user_by_email_or_none(self, email_address):

4
tests/app/notify_client/test_user_client.py
View File

@@ -36,11 +36,11 @@ def test_client_uses_correct_find_by_email(mocker, api_user_active):
expected_params = {'email': api_user_active['email_address']}
user_api_client.max_failed_login_count = 1 # doesn't matter for this test
mock_get = mocker.patch('app.notify_client.user_api_client.UserApiClient.get')
mock_post = mocker.patch('app.notify_client.user_api_client.UserApiClient.post')
user_api_client.get_user_by_email(api_user_active['email_address'])
mock_get.assert_called_once_with(expected_url, params=expected_params)
mock_post.assert_called_once_with(expected_url, params=expected_params)
def test_client_only_updates_allowed_attributes(mocker):