From 4a624ace32bcd5bcfa73cb5142fb9022c07e2141 Mon Sep 17 00:00:00 2001 From: Leo Hemsted Date: Fri, 5 Mar 2021 12:43:15 +0000 Subject: [PATCH] post to get user by email that way we won't store any PII in logs --- app/notify_client/user_api_client.py | 2 +- tests/app/notify_client/test_user_client.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/notify_client/user_api_client.py b/app/notify_client/user_api_client.py index bafd22284..878ffd67f 100644 --- a/app/notify_client/user_api_client.py +++ b/app/notify_client/user_api_client.py @@ -40,7 +40,7 @@ class UserApiClient(NotifyAdminAPIClient): return self.get("/user/{}".format(user_id)) def get_user_by_email(self, email_address): - user_data = self.get('/user/email', params={'email': email_address}) + user_data = self.post('/user/email', params={'email': email_address}) return user_data['data'] def get_user_by_email_or_none(self, email_address): diff --git a/tests/app/notify_client/test_user_client.py b/tests/app/notify_client/test_user_client.py index a9777c7d5..264d293f9 100644 --- a/tests/app/notify_client/test_user_client.py +++ b/tests/app/notify_client/test_user_client.py @@ -36,11 +36,11 @@ def test_client_uses_correct_find_by_email(mocker, api_user_active): expected_params = {'email': api_user_active['email_address']} user_api_client.max_failed_login_count = 1 # doesn't matter for this test - mock_get = mocker.patch('app.notify_client.user_api_client.UserApiClient.get') + mock_post = mocker.patch('app.notify_client.user_api_client.UserApiClient.post') user_api_client.get_user_by_email(api_user_active['email_address']) - mock_get.assert_called_once_with(expected_url, params=expected_params) + mock_post.assert_called_once_with(expected_url, params=expected_params) def test_client_only_updates_allowed_attributes(mocker):