darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 01:55:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Updating variable name from et to preferred_tz
This commit is contained in:
Carlo Costino
2023-11-22 13:06:04 -05:00
committed by GitHub
parent 425f8eb742
commit 4571a8bd15
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/main/views/performance.py
View File

@@ -13,10 +13,10 @@ from app.utils.csv import get_user_preferred_timezone
@main.route("/performance") @main.route("/performance")
def performance(): def performance():
et = pytz.timezone(get_user_preferred_timezone()) preferred_tz = pytz.timezone(get_user_preferred_timezone())
stats = performance_dashboard_api_client.get_performance_dashboard_stats( stats = performance_dashboard_api_client.get_performance_dashboard_stats(
start_date=(datetime.now(et) - timedelta(days=7)).date(), start_date=(datetime.now(preferred_tz) - timedelta(days=7)).date(),
end_date=datetime.now(et).date(), end_date=datetime.now(preferred_tz).date(),
) )
stats["organizations_using_notify"] = sorted( stats["organizations_using_notify"] = sorted(
[ [

4
app/statistics_utils.py
View File

@@ -27,7 +27,7 @@ def sum_of_statistics(delivery_statistics):
def add_rates_to(delivery_statistics): def add_rates_to(delivery_statistics):
et = pytz.timezone(get_user_preferred_timezone()) preferred_tz = pytz.timezone(get_user_preferred_timezone())
return dict( return dict(
emails_failure_rate=get_formatted_percentage( emails_failure_rate=get_formatted_percentage(
delivery_statistics["emails_failed"], delivery_statistics["emails_failed"],
@@ -37,7 +37,7 @@ def add_rates_to(delivery_statistics):
delivery_statistics["sms_failed"], delivery_statistics["sms_requested"] delivery_statistics["sms_failed"], delivery_statistics["sms_requested"]
), ),
week_end_datetime=parser.parse( week_end_datetime=parser.parse(
delivery_statistics.get("week_end", str(datetime.now(et))) delivery_statistics.get("week_end", str(datetime.now(preferred_tz)))
), ),
**delivery_statistics **delivery_statistics
) )

4
app/utils/time.py
View File

@@ -7,8 +7,8 @@ from app.utils.csv import get_user_preferred_timezone
def get_current_financial_year(): def get_current_financial_year():
et = pytz.timezone(get_user_preferred_timezone()) preferred_tz = pytz.timezone(get_user_preferred_timezone())
now = datetime.now(et) now = datetime.now(preferred_tz)
current_month = int(now.strftime("%-m")) current_month = int(now.strftime("%-m"))
current_year = int(now.strftime("%Y")) current_year = int(now.strftime("%Y"))
return current_year if current_month > 9 else current_year - 1 return current_year if current_month > 9 else current_year - 1