Apply suggestions from code review

Updating variable name from et to preferred_tz

app/main/views/performance.py

@@ -13,10 +13,10 @@ from app.utils.csv import get_user_preferred_timezone
 
 @main.route("/performance")
 def performance():
-    et = pytz.timezone(get_user_preferred_timezone())
+    preferred_tz = pytz.timezone(get_user_preferred_timezone())
     stats = performance_dashboard_api_client.get_performance_dashboard_stats(
-        start_date=(datetime.now(et) - timedelta(days=7)).date(),
-        end_date=datetime.now(et).date(),
+        start_date=(datetime.now(preferred_tz) - timedelta(days=7)).date(),
+        end_date=datetime.now(preferred_tz).date(),
     )
     stats["organizations_using_notify"] = sorted(
         [

app/statistics_utils.py

@@ -27,7 +27,7 @@ def sum_of_statistics(delivery_statistics):
 
 
 def add_rates_to(delivery_statistics):
-    et = pytz.timezone(get_user_preferred_timezone())
+    preferred_tz = pytz.timezone(get_user_preferred_timezone())
     return dict(
         emails_failure_rate=get_formatted_percentage(
             delivery_statistics["emails_failed"],
@@ -37,7 +37,7 @@ def add_rates_to(delivery_statistics):
             delivery_statistics["sms_failed"], delivery_statistics["sms_requested"]
         ),
         week_end_datetime=parser.parse(
-            delivery_statistics.get("week_end", str(datetime.now(et)))
+            delivery_statistics.get("week_end", str(datetime.now(preferred_tz)))
         ),
         **delivery_statistics
     )

app/utils/time.py

@@ -7,8 +7,8 @@ from app.utils.csv import get_user_preferred_timezone
 
 
 def get_current_financial_year():
-    et = pytz.timezone(get_user_preferred_timezone())
-    now = datetime.now(et)
+    preferred_tz = pytz.timezone(get_user_preferred_timezone())
+    now = datetime.now(preferred_tz)
     current_month = int(now.strftime("%-m"))
     current_year = int(now.strftime("%Y"))
     return current_year if current_month > 9 else current_year - 1