From 4571a8bd15db3a4c130ac0f216e33277c1bf6144 Mon Sep 17 00:00:00 2001 From: Carlo Costino Date: Wed, 22 Nov 2023 13:06:04 -0500 Subject: [PATCH] Apply suggestions from code review Updating variable name from et to preferred_tz --- app/main/views/performance.py | 6 +++--- app/statistics_utils.py | 4 ++-- app/utils/time.py | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/main/views/performance.py b/app/main/views/performance.py index b0037c7cb..13445967b 100644 --- a/app/main/views/performance.py +++ b/app/main/views/performance.py @@ -13,10 +13,10 @@ from app.utils.csv import get_user_preferred_timezone @main.route("/performance") def performance(): - et = pytz.timezone(get_user_preferred_timezone()) + preferred_tz = pytz.timezone(get_user_preferred_timezone()) stats = performance_dashboard_api_client.get_performance_dashboard_stats( - start_date=(datetime.now(et) - timedelta(days=7)).date(), - end_date=datetime.now(et).date(), + start_date=(datetime.now(preferred_tz) - timedelta(days=7)).date(), + end_date=datetime.now(preferred_tz).date(), ) stats["organizations_using_notify"] = sorted( [ diff --git a/app/statistics_utils.py b/app/statistics_utils.py index 83c1eb154..fdb3c9dfa 100644 --- a/app/statistics_utils.py +++ b/app/statistics_utils.py @@ -27,7 +27,7 @@ def sum_of_statistics(delivery_statistics): def add_rates_to(delivery_statistics): - et = pytz.timezone(get_user_preferred_timezone()) + preferred_tz = pytz.timezone(get_user_preferred_timezone()) return dict( emails_failure_rate=get_formatted_percentage( delivery_statistics["emails_failed"], @@ -37,7 +37,7 @@ def add_rates_to(delivery_statistics): delivery_statistics["sms_failed"], delivery_statistics["sms_requested"] ), week_end_datetime=parser.parse( - delivery_statistics.get("week_end", str(datetime.now(et))) + delivery_statistics.get("week_end", str(datetime.now(preferred_tz))) ), **delivery_statistics ) diff --git a/app/utils/time.py b/app/utils/time.py index f8d874c96..9ae24b1bd 100644 --- a/app/utils/time.py +++ b/app/utils/time.py @@ -7,8 +7,8 @@ from app.utils.csv import get_user_preferred_timezone def get_current_financial_year(): - et = pytz.timezone(get_user_preferred_timezone()) - now = datetime.now(et) + preferred_tz = pytz.timezone(get_user_preferred_timezone()) + now = datetime.now(preferred_tz) current_month = int(now.strftime("%-m")) current_year = int(now.strftime("%Y")) return current_year if current_month > 9 else current_year - 1