darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-02-05 10:53:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add test for url and pluralisation

Browse Source
This commit is contained in:
Rebecca Law
2019-12-30 14:06:15 +00:00
parent 401828d1e0
commit 41be4c054b
2 changed files with 24 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/main/views/returned_letters.py
View File

@@ -31,7 +31,7 @@ def returned_letters_report(service_id, reported_at):
('template_version', 'Template version'),
('original_file_name', 'Spreadsheet file name'),
('job_row_number', 'Spreadsheet row number'),
('uploaded_letter_file_name', 'Uploaded letter')
('uploaded_letter_file_name', 'Uploaded letter file name')
])
# initialise with header row

24
tests/app/main/views/test_returned_letters.py
View File

@@ -1,3 +1,5 @@
from flask import url_for
from tests.conftest import SERVICE_ONE_ID, normalize_spaces
@@ -16,6 +18,26 @@ def test_returned_letter_summary(
expected_text = "Returned letters reported on Tuesday 24 December 2019 - 30 letters"
assert page.h1.string.strip() == 'Returned letters'
assert normalize_spaces(page.select('.table-field-left-aligned')[0].text) == expected_text
assert page.select_one('.table-field-left-aligned a')['href'] == url_for('.returned_letters_report',
service_id=SERVICE_ONE_ID,
reported_at='2019-12-24')
def test_returned_letter_summary_with_one_letter(
client_request,
mocker
):
summary_data = [{'returned_letter_count': 1, 'reported_at': '2019-12-24'}]
mock = mocker.patch("app.service_api_client.get_returned_letter_summary",
return_value=summary_data)
page = client_request.get("main.returned_letter_summary", service_id=SERVICE_ONE_ID)
mock.assert_called_once_with(SERVICE_ONE_ID)
expected_text = "Returned letters reported on Tuesday 24 December 2019 - 1 letter"
assert page.h1.string.strip() == 'Returned letters'
assert normalize_spaces(page.select('.table-field-left-aligned')[0].text) == expected_text
def test_returned_letters_reports(
@@ -44,7 +66,7 @@ def test_returned_letters_reports(
mock.assert_called_once_with(SERVICE_ONE_ID, '2019-12-24')
assert report.strip() == (
'Notification ID,Reference,Date sent,Sent by,Template name,Template ID,Template version,'
+ 'Spreadsheet file name,Spreadsheet row number,Uploaded letter\r\n'
+ 'Spreadsheet file name,Spreadsheet row number,Uploaded letter file name\r\n'
+ '12345678,2344567,2019-12-24 13:30,test@gov.uk,'
+ 'First letter template,3445667,2,,,test_letter.pdf'
)