diff --git a/app/main/views/returned_letters.py b/app/main/views/returned_letters.py index 39937e3d2..adda4e29d 100644 --- a/app/main/views/returned_letters.py +++ b/app/main/views/returned_letters.py @@ -31,7 +31,7 @@ def returned_letters_report(service_id, reported_at): ('template_version', 'Template version'), ('original_file_name', 'Spreadsheet file name'), ('job_row_number', 'Spreadsheet row number'), - ('uploaded_letter_file_name', 'Uploaded letter') + ('uploaded_letter_file_name', 'Uploaded letter file name') ]) # initialise with header row diff --git a/tests/app/main/views/test_returned_letters.py b/tests/app/main/views/test_returned_letters.py index ae7bf3b99..96df90981 100644 --- a/tests/app/main/views/test_returned_letters.py +++ b/tests/app/main/views/test_returned_letters.py @@ -1,3 +1,5 @@ +from flask import url_for + from tests.conftest import SERVICE_ONE_ID, normalize_spaces @@ -16,6 +18,26 @@ def test_returned_letter_summary( expected_text = "Returned letters reported on Tuesday 24 December 2019 - 30 letters" assert page.h1.string.strip() == 'Returned letters' assert normalize_spaces(page.select('.table-field-left-aligned')[0].text) == expected_text + assert page.select_one('.table-field-left-aligned a')['href'] == url_for('.returned_letters_report', + service_id=SERVICE_ONE_ID, + reported_at='2019-12-24') + + +def test_returned_letter_summary_with_one_letter( + client_request, + mocker +): + summary_data = [{'returned_letter_count': 1, 'reported_at': '2019-12-24'}] + mock = mocker.patch("app.service_api_client.get_returned_letter_summary", + return_value=summary_data) + + page = client_request.get("main.returned_letter_summary", service_id=SERVICE_ONE_ID) + + mock.assert_called_once_with(SERVICE_ONE_ID) + + expected_text = "Returned letters reported on Tuesday 24 December 2019 - 1 letter" + assert page.h1.string.strip() == 'Returned letters' + assert normalize_spaces(page.select('.table-field-left-aligned')[0].text) == expected_text def test_returned_letters_reports( @@ -44,7 +66,7 @@ def test_returned_letters_reports( mock.assert_called_once_with(SERVICE_ONE_ID, '2019-12-24') assert report.strip() == ( 'Notification ID,Reference,Date sent,Sent by,Template name,Template ID,Template version,' - + 'Spreadsheet file name,Spreadsheet row number,Uploaded letter\r\n' + + 'Spreadsheet file name,Spreadsheet row number,Uploaded letter file name\r\n' + '12345678,2344567,2019-12-24 13:30,test@gov.uk,' + 'First letter template,3445667,2,,,test_letter.pdf' )