darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-10 11:24:10 -04:00
Code Issues Packages Projects Releases Wiki Activity

Say ‘recently’ not ‘yet’ because jobs aren’t forever

Browse Source 
We’re going to change the jobs page so that it only shows jobs within
the last n days (your data retention)<sup>1</sup>.

This will match how long uploaded letters stick around for.

Therefore it’s not accurate to say ‘yet’, because that implies all-time.
Since the data retention for different channels could be different it’s
hard and maybe unhelpful to give an exact time period. ‘Recently’ is
content we used here before, but then changed.

1. https://www.pivotaltracker.com/story/show/171623239
This commit is contained in:
Chris Hill-Scott
2020-03-06 09:49:04 +00:00
parent dff182b24f
commit 3c3355536e
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/jobs/jobs.html
View File

@@ -19,7 +19,7 @@
{% endif %}
{% if not jobs and not show_scheduled_jobs %}
<p class="govuk-body">
You have not uploaded any files yet.
You have not uploaded any files recently.
</p>
{% if current_service.has_permission('upload_letters') %}
<p class="govuk-body">

4
tests/app/main/views/test_uploads.py
View File

@@ -39,11 +39,11 @@ def test_no_upload_letters_button_without_permission(
@pytest.mark.parametrize('extra_permissions, expected_empty_message', (
(['letter'], (
'You have not uploaded any files yet. '
'You have not uploaded any files recently. '
'To upload a list of contact details, first choose a template.'
)),
(['letter', 'upload_letters'], (
'You have not uploaded any files yet. '
'You have not uploaded any files recently. '
'Upload a letter and Notify will print, pack and post it for you. '
'To upload a list of contact details, first choose a template.'
)),