From 3c3355536e43a32a65bc7be2a7a464d9549bd779 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Fri, 6 Mar 2020 09:49:04 +0000 Subject: [PATCH] =?UTF-8?q?Say=20=E2=80=98recently=E2=80=99=20not=20?= =?UTF-8?q?=E2=80=98yet=E2=80=99=20because=20jobs=20aren=E2=80=99t=20forev?= =?UTF-8?q?er?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We’re going to change the jobs page so that it only shows jobs within the last n days (your data retention)1. This will match how long uploaded letters stick around for. Therefore it’s not accurate to say ‘yet’, because that implies all-time. Since the data retention for different channels could be different it’s hard and maybe unhelpful to give an exact time period. ‘Recently’ is content we used here before, but then changed. 1. https://www.pivotaltracker.com/story/show/171623239 --- app/templates/views/jobs/jobs.html | 2 +- tests/app/main/views/test_uploads.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/templates/views/jobs/jobs.html b/app/templates/views/jobs/jobs.html index 0c14dce42..347ac2a6d 100644 --- a/app/templates/views/jobs/jobs.html +++ b/app/templates/views/jobs/jobs.html @@ -19,7 +19,7 @@ {% endif %} {% if not jobs and not show_scheduled_jobs %}

- You have not uploaded any files yet. + You have not uploaded any files recently.

{% if current_service.has_permission('upload_letters') %}

diff --git a/tests/app/main/views/test_uploads.py b/tests/app/main/views/test_uploads.py index 943e5b205..df27e2a6d 100644 --- a/tests/app/main/views/test_uploads.py +++ b/tests/app/main/views/test_uploads.py @@ -39,11 +39,11 @@ def test_no_upload_letters_button_without_permission( @pytest.mark.parametrize('extra_permissions, expected_empty_message', ( (['letter'], ( - 'You have not uploaded any files yet. ' + 'You have not uploaded any files recently. ' 'To upload a list of contact details, first choose a template.' )), (['letter', 'upload_letters'], ( - 'You have not uploaded any files yet. ' + 'You have not uploaded any files recently. ' 'Upload a letter and Notify will print, pack and post it for you. ' 'To upload a list of contact details, first choose a template.' )),