darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-24 09:58:43 -04:00
Code Issues Packages Projects Releases Wiki Activity

Tell users that they can search whole postal address

Browse Source 
We’re now normalising and storing the whole address in the
`normalised_to` field. Previously we were only storing the first line
of the address.

Enough time should now have passed that the field will have been
populated for all letters in the database.

Thus we can now tell users that it’s not just the first line they can
search by.
This commit is contained in:
Chris Hill-Scott
2020-07-30 16:20:19 +01:00
parent 52c9cf3e76
commit 2789b6a596
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/main/views/jobs.py
View File

@@ -171,9 +171,7 @@ def view_notifications(service_id, message_type=None):
things_you_can_search_by={
'email': ['email address'],
'sms': ['phone number'],
# This should become ‘postal address’ not ‘first line…’ once
# we’ve finished populating normalised addresses
'letter': ['first line of address', 'file name'],
'letter': ['postal address', 'file name'],
# We say recipient here because combining all 3 types, plus
# reference gets too long for the hint text
None: ['recipient'],

6
tests/app/main/views/test_activity.py
View File

@@ -402,7 +402,7 @@ def test_shows_message_when_no_notifications(
{
'to': 'Firstname Lastname',
},
'Search by first line of address or file name',
'Search by postal address or file name',
'Firstname Lastname',
),
])
@@ -448,7 +448,7 @@ def test_search_recipient_form(
(None, 'Search by recipient or reference'),
('sms', 'Search by phone number or reference'),
('email', 'Search by email address or reference'),
('letter', 'Search by first line of address, file name or reference'),
('letter', 'Search by postal address, file name or reference'),
])
def test_api_users_are_told_they_can_search_by_reference_when_service_has_api_keys(
client_request,
@@ -473,7 +473,7 @@ def test_api_users_are_told_they_can_search_by_reference_when_service_has_api_ke
(None, 'Search by recipient'),
('sms', 'Search by phone number'),
('email', 'Search by email address'),
('letter', 'Search by first line of address or file name'),
('letter', 'Search by postal address or file name'),
])
def test_api_users_are_not_told_they_can_search_by_reference_when_service_has_no_api_keys(
client_request,