Use the same template for problems and questions

This commit is contained in:
Chris Hill-Scott
2020-03-24 17:48:12 +00:00
parent 11cdf58256
commit 17a3ee920c
3 changed files with 16 additions and 12 deletions
+3 -3
View File
@@ -52,7 +52,7 @@ def support():
else: else:
return redirect(url_for( return redirect(url_for(
'.feedback', '.feedback',
ticket_type=QUESTION_TICKET_TYPE, ticket_type=PROBLEM_TICKET_TYPE,
)) ))
return render_template('views/support/index.html', form=form) return render_template('views/support/index.html', form=form)
@@ -144,9 +144,9 @@ def feedback(ticket_type):
form.feedback.data = get_prefilled_message() form.feedback.data = get_prefilled_message()
return render_template( return render_template(
'views/support/{}.html'.format(ticket_type), 'views/support/{}.html'.format(PROBLEM_TICKET_TYPE),
form=form, form=form,
ticket_type=ticket_type, is_problem=(ticket_type == PROBLEM_TICKET_TYPE),
) )
@@ -5,24 +5,28 @@
{% from "components/page-header.html" import page_header %} {% from "components/page-header.html" import page_header %}
{% from "components/form.html" import form_wrapper %} {% from "components/form.html" import form_wrapper %}
{% set page_title = 'Report a problem' if is_problem else 'Ask a question or give feedback' %}
{% block per_page_title %} {% block per_page_title %}
Report a problem {{ page_title }}
{% endblock %} {% endblock %}
{% block maincolumn_content %} {% block maincolumn_content %}
{{ page_header( {{ page_header(
'Report a problem', page_title,
back_link=url_for('.support') back_link=url_for('.support')
) }} ) }}
<div class="govuk-grid-row"> <div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds"> <div class="govuk-grid-column-two-thirds">
<div class="panel panel-border-wide"> {% if is_problem %}
<p> <div class="panel panel-border-wide">
Check our <a class="govuk-link govuk-link--no-visited-state" href="https://status.notifications.service.gov.uk">system status</a> <p>
page to see if there are any known issues with GOV.UK Notify. Check our <a class="govuk-link govuk-link--no-visited-state" href="https://status.notifications.service.gov.uk">system status</a>
</p> page to see if there are any known issues with GOV.UK Notify.
</div> </p>
</div>
{% endif %}
{% call form_wrapper() %} {% call form_wrapper() %}
{{ textbox(form.feedback, width='1-1', hint='', rows=10, autosize=True) }} {{ textbox(form.feedback, width='1-1', hint='', rows=10, autosize=True) }}
{% if not current_user.is_authenticated %} {% if not current_user.is_authenticated %}
+1 -1
View File
@@ -96,7 +96,7 @@ def test_get_support_as_someone_in_the_public_sector(
_follow_redirects=True, _follow_redirects=True,
) )
assert normalize_spaces(page.select('h1')) == ( assert normalize_spaces(page.select('h1')) == (
'Ask a question or give feedback' 'Report a problem'
) )
assert page.select_one('form textarea[name=feedback]') assert page.select_one('form textarea[name=feedback]')
assert page.select_one('form input[name=name]') assert page.select_one('form input[name=name]')