darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-04-22 02:00:57 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove ‘originally’ from returned letters report

Browse Source 
We should remove Originally on the individual report pages.
It sounds like we're saying the letter has been sent more than once
since that date.

The dictionary definition for 'originally' as an adverb says:
> used to describe the situation that existed at the beginning of a
> particular period or activity, especially before something was changed

Examples given include:
> The book was originally published in 1935.
This commit is contained in:
Chris Hill-Scott
2020-02-20 11:51:41 +00:00
parent 678c3df53c
commit 0e8143da04
2 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/returned-letters.html
View File

@@ -42,7 +42,7 @@
{% call field(align='right') %}
<span class="align-with-message-body">
<span class="status-hint">
Originally sent {{ item.created_at|format_date_normal }}
Sent {{ item.created_at|format_date_normal }}
</span>
</span>
{% endcall %}

12
tests/app/main/views/test_returned_letters.py
View File

@@ -88,12 +88,12 @@ def test_returned_letters_page(
assert [
'Template name Originally sent',
'Example template Reference ABC123 Originally sent 24 December 2019',
'Example template Sent from Example spreadsheet.xlsx Originally sent 24 December 2019',
'Example template No reference provided Originally sent 24 December 2019',
'Example precompiled.pdf Reference DEF456 Originally sent 24 December 2019',
'Example one-off.pdf No reference provided Originally sent 24 December 2019',
'Provided as PDF Reference XYZ999 Originally sent 24 December 2019',
'Example template Reference ABC123 Sent 24 December 2019',
'Example template Sent from Example spreadsheet.xlsx Sent 24 December 2019',
'Example template No reference provided Sent 24 December 2019',
'Example precompiled.pdf Reference DEF456 Sent 24 December 2019',
'Example one-off.pdf No reference provided Sent 24 December 2019',
'Provided as PDF Reference XYZ999 Sent 24 December 2019',
] == [
normalize_spaces(row.text) for row in page.select('tr')
]