Ben Thorner 779b8e941f Rewrite broadcast Zendesk alert at approval time ...

The new alert happens earlier but is otherwise the same:

- We only create a ticket in Production.
- We only create a ticket on approval.

I took this opportunity to refactor the alert as a private function
and test this specifically in detail to avoid lots of repetitive
mocks, which are required when calling the main "update" function.

One test I haven't preserved was for when the "names" array is empty,
as this was added for a legacy data integrity scenario [^1].

[^1]: bf0bf4e31c

2022-04-05 12:57:08 +01:00

5.7 KiB

Raw Blame History

View Raw