Rebecca Law 93ce1d2503 There were some exceptions in production today where a one off message was sending a message with an invalid email address. ...

The admin app validation did not catch this problem. But the API did.
This PR is a small fix to catch the erorr thrown by the notifications-utils/recipient validation methods and return a 400 status rather than a 500.
This only solves the issue of the user seeing "We are experiencing technical difficulties" rather than "invalid email address"

The bug can be replicated if you enter use quotes when entering the email address.

More work needs to be done so that the admin app does the same validation as the api so the user sees a nice form validtion error rather than a 400 after clicking send.
See: https://www.pivotaltracker.com/story/show/154472625

2018-01-19 12:23:07 +00:00

4.2 KiB

Raw Blame History

View Raw